Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Nov 2022 16:05:19 +0100
From:   Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: pic32: treat port as signed integer
Message-ID: <20221111150519.GE13465@alpha.franken.de>
References: <20221028132344.1993934-1-Jason@zx2c4.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221028132344.1993934-1-Jason@zx2c4.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri, Oct 28, 2022 at 03:23:44PM +0200, Jason A. Donenfeld wrote:
> get_port_from_cmdline() returns an int, yet is assigned to a char, which
> is wrong in its own right, but also, with char becoming unsigned, this
> poses problems, because -1 is used as an error value. Further
> complicating things, fw_init_early_console() is only ever called with a
> -1 argument. Fix this up by removing the unused argument from
> fw_init_early_console() and treating port as a proper signed integer.
> 
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
> Thomas - this is part of the -funsigned-char work I've been accumulating
> in my unsigned-char branch. If you want to take this as a fix for 6.1,
> go ahead. Otherwise, Linus asked me to keep the 6.2 unsigned-char
> patches together in my branch, so I'll take this, pending your Ack.
> -Jason
> 
>  arch/mips/include/asm/fw/fw.h             |  2 +-
>  arch/mips/pic32/pic32mzda/early_console.c | 13 ++++++-------
>  arch/mips/pic32/pic32mzda/init.c          |  2 +-
>  3 files changed, 8 insertions(+), 9 deletions(-)

applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]