Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0cc025f5-0e1a-3666-9c39-3d09a37cea2d@nvidia.com>
Date:   Fri, 11 Nov 2022 14:39:20 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v7 1/3] xhci: Add hub_control to xhci_driver_overrides
Content-Language: en-US
To:     Jim Lin <jilin@nvidia.com>, thierry.reding@gmail.com,
        gregkh@linuxfoundation.org
Cc:     mathias.nyman@intel.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
References: <20221111101813.32482-1-jilin@nvidia.com>
 <20221111101813.32482-2-jilin@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20221111101813.32482-2-jilin@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3AyWkk2T29WUWdQQk1WM0cyR1JDU090WEhpWTlScW1qSTV6Y0JJaFpNVnFz?=
 =?utf-8?B?ckFTUWpOd3dVOG1HWVBQY3JzOEZhMUhYQVV0Wms0RmMzQ3RSMXMvUExWNXpm?=
 =?utf-8?B?Sy9RRXFtVXRleDRMY2VtZnI3RS9HRHBpcElsOEpPTWluMHgra3FXOUtUYlp1?=
 =?utf-8?B?THdvUHBMSzVpL3pqS0JWY1YyRXhqRUtFVlNrakFNWFJ2MHZIT0d2b3k3b0tw?=
 =?utf-8?B?dWFiclovU1hSSVBudDRjU3hTTkNTSkc0aTdPbitxYzI1b05YMndCUThEUDFq?=
 =?utf-8?B?c1lNR2dmVmNRTktzTHZQakdoTlZjUUd3WVBxNlhTTWpIM0REcGtFK0ZLV2x0?=
 =?utf-8?B?aTU1T2tOVWdGNC9Ta3R5UisyWXMwSExlY2JEWjFPa0RtMEhjOWNLRUZmeG9I?=
 =?utf-8?B?VXVEQWRSdThQNzFxc216Mm8zcytsaDN4WmM1QXB2akFGVTdOdzF6bW14SWhZ?=
 =?utf-8?B?NnJ5L2FVclhmaG02b1RuUEx0Z0NuRTBHMG1QeHI2bGhsUUFlZGRUdU1ENWNC?=
 =?utf-8?B?WlNpSTE2SkFzSkhCc3g0cS94OXVjZS9nbE9MV3pPMmkwNElKRHJyTkN0VEVY?=
 =?utf-8?B?UmhGdFRGNExMN0h3R3MrZUdJZ3o1Skt2enNqNFBKS0U2MklMT3V2YS9xeDlz?=
 =?utf-8?B?STVXN1M2NWRjR1F4Sy9UTkRWWWJNcENWRDRud1ltRUhhMzUzQUljV1BuTUZK?=
 =?utf-8?B?d2VEd0pRd0tpSktBU0FPckhkVGhkN0lLajBVdlMzZ3I0Zmhud2d4TjY0WXVn?=
 =?utf-8?B?VTRCbFA0NGdwNHI0UVlaNHhGUWNBN3BDWDBVdnZ6bzB5aWgwdDdjcjI2ME42?=
 =?utf-8?B?dmw2RUhyU0NtcGR3djZGckpIcDlKZ0hhRUVRa2ZkZVJvMFB5U0cxMjc5alc1?=
 =?utf-8?B?TjRhc1ZjOTBiQmVOWVZNeGttOWMwTkxaQUFROXMrVFprZG8xZnZIMExOekpi?=
 =?utf-8?B?bzNYOCtlQkVBMHdGQy8vN04wZmtBYVBTalErTnYyUlMrSWVTWExKMmZPY3JP?=
 =?utf-8?B?Z0Zsd3ZaYjlQNFd1V0RQZTlQbHhueFVCaDROYXJmeXJ5UlI1NW5jMTlJcWgx?=
 =?utf-8?B?TE5aMGw5NkE1eHhPMFJMaEJ6YytKTlZ1S3J5emE2SC9yYXYvMHNIL3A5aWpC?=
 =?utf-8?B?SWtLeHRadStSa25RdjllNlFscDZaWmlDdkZMNTdqMld2S3d4YjFjT2VLVnJp?=
 =?utf-8?B?cTh5Uzlmc0RDdTVkeUhpeHJ3alVhMnM1b1N6ZTRMM3pmdjRFQlhsZC9uSE9r?=
 =?utf-8?B?TGVJM0JKYytSN3VRYVVmMW85WVk4c2pjYWtpUlNaUXptNnU4b0YzMTBSUjhy?=
 =?utf-8?B?RXR4QkcyMzU3Mmp6cnZZYU5EWTlkVEtRUXpxMjUyVi9pd2taQWk0WFlQY3Zl?=
 =?utf-8?B?TlJMLzBNSVB2NmFCUHlLeUxDRTVIdFJWV1N2M0dkUytBWkQvd3N6YTFpbnNY?=
 =?utf-8?B?YXZoUGtkakQ1MExjclVDZDJReStWSG04MnQ5bkU3MDY2VkpPeG8rMWxHUWxF?=
 =?utf-8?B?bE5WdE1FR2VqZnNiZmdTRm8wanNXTlYyRkxma0FJbWNtbzhNa2RjVmR0OW9D?=
 =?utf-8?B?Y25wbkFINGpoU2JRWXVoemNJSkxKU1ZHQitjdlQxOFNib3NoSE94MWQxQ21Q?=
 =?utf-8?B?UEJvd2pkWWUxa2xCNENUTWwyRHBkQzV1UUp1cXE2MGhOd1dLbWc5TEJzZDNj?=
 =?utf-8?B?OENOVUZNRXpkbk4wVkI3OG5VUWxwN1MxZzRGaEdqNG9DV3F5U0owUm5JUG56?=
 =?utf-8?B?bi9XSTQ3Smo0YWwyWklxa3V4VkFqbXlzVUVhbGczdzdoZUJuYVpXWEFPQWV3?=
 =?utf-8?B?NUZOYnp6SzAxWmxWS2dNa0VPakNNSzdqNk9CRWIwKzNrN0UwYTB1V0FhOC9Z?=
 =?utf-8?B?SU9qOU1tQkg1bWgxVWo3c0xYZ2pMWWRwa0lsK1FvdlN0czVaODY1QXNEeWdN?=
 =?utf-8?B?YXlnelZWTGFxSjlqazV6S1NsMUM0cFAyeGFaWExhMDBmYjQ4dForcWo3Ujlv?=
 =?utf-8?B?NDNDQlI4Q3EybG84U3prQzFBS0VZcVVQdVhmdEVKNDZPRU1xODNXMFk1aEtP?=
 =?utf-8?B?ZTZkbk5OaVNoaHdkMDcwOFVwVjEzK2NKcmFsSElNNnB3SmJYUndzSHR5K1VV?=
 =?utf-8?B?anc3R2N6b1pmK3huNkpZamFzZ1RSaWVKMUp5eFdUUU1WZG9jaCtiekFpM0ll?=
 =?utf-8?B?NzZGdDh0Sm9CZjlyYkxwenlTY3RJUTVHbTgvVzczMmQrdmlXYXZwUXlSL3E2?=
 =?utf-8?B?MWhTeFBmekt1aXdpTHFCbTdDNE9nPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5240df62-a48b-4e9f-4aaf-08dac3f287ec
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:39:25.9070
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GBwVnmR0YiqfIXLpHRpLbAXdkGNOBK2sN7hp+5zUK26+wEbkRgPziu2ILQqPRzIr/T/2Q1va3gglTmxGs1rokQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7118
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/11/2022 10:18, Jim Lin wrote:
> Add a hub_control() callback to the xhci_driver_overrides structure to
> allow host drivers to override the default hub_control function. This
> is required for Tegra which requires device specific actions for power
> management to be executed during USB state transitions.
> 
> Signed-off-by: Jim Lin <jilin@nvidia.com>
> 
> ---
> v5: new change
> v6: adjust parameter alignment (xhci.h hub_control)
> v7: change commit message
> 
>   drivers/usb/host/xhci.c | 2 ++
>   drivers/usb/host/xhci.h | 2 ++
>   2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 902f410874e8..3c7bf0a0e0b4 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -5461,6 +5461,8 @@ void xhci_init_driver(struct hc_driver *drv,
>   			drv->check_bandwidth = over->check_bandwidth;
>   		if (over->reset_bandwidth)
>   			drv->reset_bandwidth = over->reset_bandwidth;
> +		if (over->hub_control)
> +			drv->hub_control = over->hub_control;
>   	}
>   }
>   EXPORT_SYMBOL_GPL(xhci_init_driver);
> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> index 5a75fe563123..f51b674fc10c 100644
> --- a/drivers/usb/host/xhci.h
> +++ b/drivers/usb/host/xhci.h
> @@ -1943,6 +1943,8 @@ struct xhci_driver_overrides {
>   			     struct usb_host_endpoint *ep);
>   	int (*check_bandwidth)(struct usb_hcd *, struct usb_device *);
>   	void (*reset_bandwidth)(struct usb_hcd *, struct usb_device *);
> +	int (*hub_control)(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
> +			   u16 wIndex, char *buf, u16 wLength);
>   };
>   
>   #define	XHCI_CFC_DELAY		10

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>

Thanks
Jon

-- 
nvpublic