Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2293397rwb; Fri, 11 Nov 2022 07:31:29 -0800 (PST) X-Google-Smtp-Source: AA0mqf54Dtt44QKFhMcm1zqnbJz8sf7FKXniG87/EmyfCNlcIBRtUCoZJvDCsfgfuCTHrxOJKn/9 X-Received: by 2002:a50:f60b:0:b0:461:8fbf:f607 with SMTP id c11-20020a50f60b000000b004618fbff607mr1871391edn.235.1668180689660; Fri, 11 Nov 2022 07:31:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668180689; cv=none; d=google.com; s=arc-20160816; b=eIs/ZDja0XbiMebWor4kdZye/W/ADKcqJOk4Bc5IvW8fOhQ7wqbFjS9yVOgNIqX2hI lBjhBui/gTNafx0Nel2zuwAYreufyKDeAmTBLA1oIovErm9h2UJPP5B56OOMqOrXbWFV sWFzMzDjz+SmpPhBjMdH7Zwd5jODAKv8M34pC1rds0IyaZZ2NKn81LGBCQFzxHQa+pJA K9VAKILac4oEwaU0zscQMyEhRHJHAc8BQ0Bs4/7JeFOKdNDHB42KIuTAsENU3Asa8foU 3YF4A+6ZAOe06cm3QcZse5tPAcD1pKl0Tg0NPvdGMmnGArZciz3pvLUK9J9nCp30ysUE ZNow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=24Y/zTC8veHZtHR52vxQ2aEUyRkiXDasy/7YMbH3POk=; b=BoVF/UqA1I803trD7CQGSPnbpw7JN9DCM9xEyUR4kopqeusLd+ytjP/MvtjQM961o6 Zrr11tCx4dJA7W/U0ucbEb40wldK+zX3m4yPKPynodXTpUuXXar9qVOk43OIQJcaTtim /n0WDIGas+d25jZWAQ4YTIne055qx0C7hfQ4Zm96LMXMBcy7+DkUz8wT73brXTcQ9Van /ARW8er9gCUOUf2h7HeUwSs+3r3tT6q1hbCPWV7xUrYHsV7qhcN33U3o3PoA+KPzz1cs NrGInEBMIIZVbM/kTonoJYrpAs2syULFYvDfWZiOmbEwZ4pOhw5nLvSXaO8o24KjPowi dA4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cLSf6Nn4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s24-20020a508d18000000b00461b8e2c7f4si2098177eds.548.2022.11.11.07.31.04; Fri, 11 Nov 2022 07:31:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cLSf6Nn4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234690AbiKKO6z (ORCPT + 91 others); Fri, 11 Nov 2022 09:58:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234694AbiKKO6u (ORCPT ); Fri, 11 Nov 2022 09:58:50 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDD0026AFA; Fri, 11 Nov 2022 06:58:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668178729; x=1699714729; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Iokqu3N3/AkaN5JzOotARpVC/tBGH0Hf1rFvyuCpV3A=; b=cLSf6Nn4CLsG+1mo1IRAJtvpB9aaZt3rl5RxLQ1uAF9C2Mh+LKEhJFk0 C0uuYIWsTVYlQdVOClC+dFghrdg//3nFoHRyquyQ02OB4DkqpKSFQtPej Dlai6khF9hryY8ZV4aBQg0RicqQwawVqofLC5iDFEyRleYwXzW7XCisZK bKWpKUkqS2i+btVGesqo136fvkBAf2gsigbW1fl/8bRjPwZb/71tJg+Ta M9lZkiVbhY5YE9bDQIY9sIzPhmoKKbSVqsmNmZ24rmFQvKHPNihOPV5yJ Li/ED5L5aysKq5wpbAGoZHnDa1AvBqT/gX6D1Ycb0dcJOU0aVrpMJyFN3 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10528"; a="397902725" X-IronPort-AV: E=Sophos;i="5.96,156,1665471600"; d="scan'208";a="397902725" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2022 06:58:49 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10528"; a="780201313" X-IronPort-AV: E=Sophos;i="5.96,156,1665471600"; d="scan'208";a="780201313" Received: from punajuuri.fi.intel.com (HELO paasikivi.fi.intel.com) ([10.237.72.43]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2022 06:58:47 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 91D5D2033F; Fri, 11 Nov 2022 16:58:45 +0200 (EET) Date: Fri, 11 Nov 2022 14:58:45 +0000 From: Sakari Ailus To: Andy Shevchenko Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Tianshu Qiu , Shawn Tu , Bingbu Cao , Mauro Carvalho Chehab Subject: Re: [PATCH v1 1/8] media: ov2740: Remove duplicative pointer in struct nvm_data Message-ID: References: <20220726120556.2881-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 11, 2022 at 02:08:48PM +0200, Andy Shevchenko wrote: > On Fri, Nov 11, 2022 at 02:05:37PM +0200, Andy Shevchenko wrote: > > On Tue, Aug 23, 2022 at 05:10:35PM +0300, Andy Shevchenko wrote: > > > On Tue, Jul 26, 2022 at 03:05:49PM +0300, Andy Shevchenko wrote: > > > > The struct i2c_client pointer is used only to get driver data, > > > > associated with a struct device or print messages on behalf. > > > > Moreover, the very same pointer to a struct device is already > > > > assigned by a regmap and can be retrieved from there. > > > > No need to keep a duplicative pointer. > > > > > > Thanks, Bungbu, for the review. Can it be now applied? > > > > Don't see this being applied or commented why not... > > > > Mauro? Or who is taking care of this driver nowadays? > > Okay, found a private response by Mauro where he tells that Sakari can take > care of this. Sakari, should I resend this to you with all tags applied? > Or you can use `b4` tool that allows to avoid unneeded resend. No need to. But please cc me on the next time. I'll take a look now... -- Sakari Ailus