Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b3e92294-0aa7-edc1-115b-7552b13f9e7d@gmail.com>
Date:   Fri, 11 Nov 2022 16:45:06 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2 2/4] ufs: core: Remove redundant desc_size variable
 from hba
To:     Arthur Simchaev <Arthur.Simchaev@wdc.com>,
        martin.petersen@oracle.com
Cc:     beanhuo@micron.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1667399353-10228-1-git-send-email-Arthur.Simchaev@wdc.com>
 <1667399353-10228-3-git-send-email-Arthur.Simchaev@wdc.com>
Content-Language: en-US
From:   Bean Huo <huobean@gmail.com>
In-Reply-To: <1667399353-10228-3-git-send-email-Arthur.Simchaev@wdc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 02.11.22 3:29 PM, Arthur Simchaev wrote:
> @@ -7446,25 +7428,24 @@ static u32 ufshcd_find_max_sup_active_icc_level(struct ufs_hba *hba,
>   static void ufshcd_set_active_icc_lvl(struct ufs_hba *hba)
>   {
>   	int ret;
> -	int buff_len = hba->desc_size[QUERY_DESC_IDN_POWER];
>   	u8 *desc_buf;
>   	u32 icc_level;
>   
> -	desc_buf = kmalloc(buff_len, GFP_KERNEL);
> +	desc_buf = kmalloc(QUERY_DESC_MAX_SIZE, GFP_KERNEL);
>   	if (!desc_buf)


Hi Arthur,

Do you think it is better to use kzalloc or kmalloc here? If item in the

descriptor is not supported by the device, it will be 0x00 and then the

relevant feature will be marked as disabled or not supported on the

device feature checkup logic.


Kind regards,

Bean