Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5782d31a-9a0c-33da-ff84-20cae29f977e@nvidia.com>
Date:   Fri, 11 Nov 2022 14:38:21 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2 02/13] dt-bindings: usb: Add NVIDIA Tegra234 XUSB host
 controller binding
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>, Wayne Chang <waynec@nvidia.com>
Cc:     mathias.nyman@intel.com, p.zabel@pengutronix.de,
        devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
        robh+dt@kernel.org, linux-tegra@vger.kernel.org,
        singhanc@nvidia.com, balbi@kernel.org,
        linux-phy@lists.infradead.org, vkoul@kernel.org,
        thierry.reding@gmail.com, ajayg@nvidia.com,
        heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
        treding@nvidia.com, jckuo@nvidia.com, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, linux-i2c@vger.kernel.org
References: <20221111101509.999589-1-waynec@nvidia.com>
 <20221111101509.999589-3-waynec@nvidia.com>
 <166817308790.3060162.14990231448404857914.robh@kernel.org>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <166817308790.3060162.14990231448404857914.robh@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEFhNWdPTS9zOVJBcS9hWkR5UXRNWXNQZkQzMHlwQ21ieG9vdTNrREc1YWdJ?=
 =?utf-8?B?V2czRTQwdHR1STQ0THRXUVJFRGRlQkFCQ3NtQXFHZCtzdklQTGV5M2ptZ2ZT?=
 =?utf-8?B?MXNmVWl5NU15YktDaEVVbzNhRDEyV2hDZ20vRm03U1hpMXFrMlUzeXJJdlNm?=
 =?utf-8?B?d3FhU3UweEx3K3ZuWC8vUDg1QTZmU1BFS3cvT3hoMFU4NXJZWTBwNlRwVWJj?=
 =?utf-8?B?RjJxeW4zY3RkMnhBWUNWMzVVMkZzVi94QXBKeUlPR1E2TWRmV2NVUG1FRGNx?=
 =?utf-8?B?bTFrcEo2Z0R3eUdabnZwNzdMbXNGbHE5d0J4ckFHTnJSalcxcm83UmlQM3hs?=
 =?utf-8?B?Wk1TL2RWS2plL0MyYUJQZUNqSFVLdTEveHE2ZEE4bmtzQ0dMeDJrelpMRG1C?=
 =?utf-8?B?KzI5OUpGZnROa2VtRnEwRWlKQlJYTjlJOURmT3B6NVlqcXVMQVZldTdVL25L?=
 =?utf-8?B?RkphbVNIZ3ZuZE9BdHV4b0FRdGJiRmFISXkvMG1iYmtPbkJZSWkvaWZieEhs?=
 =?utf-8?B?SDdWL1ZXKzhJYlVFVnhoMUpKNHRDRHpJcGo0VVptSjBraGdJMyt5a3plTTMx?=
 =?utf-8?B?NzE2L0JKNFNFWGI0VHhUOHhNdHF3Yy8rUDFuL1JrQ2hta1JFcUU2S2xqd1J1?=
 =?utf-8?B?NnlKbXczdnhwK0RXZjVwSERYL084RDdPc29NdjdlR0p3VlJUMUVMVFZqSytz?=
 =?utf-8?B?Z1Q3TkR1NkJSN3h4UDE1V3BpK05lb3d2UmdFYk1acmo0SVpJdFVndk53UTlM?=
 =?utf-8?B?ZG8xcXNqaWp0MFZ2RnFkK2QzQTRpZUwwb2hxRGZnbnRvWWN1bTZYSk15OEll?=
 =?utf-8?B?TlliYWN3UzlBblErZE1OQXN6VzdKcWdrbklybHV4TDhldXhmRFUxMHBCUVBQ?=
 =?utf-8?B?MlhOcXRoSDd3QkxXd3U3d3VvTjN3SzFEZ1Uzdm0yZ1ArK05zcmlNRGM0cWhO?=
 =?utf-8?B?RGZzMzRXUXVjTFVUU0I3akR6Vm1vWXhaMldMMXR1UllrUnlaeEU1Y0VVUlRn?=
 =?utf-8?B?YTlUcFlaVjN0Um5CWUs0TUdmMndScHl5Q2JVeU1KNVZGYmUrQTQ3QVNVeVlI?=
 =?utf-8?B?Q04yM3l5VUJJY0lvU1p2QkVUd0E3Q2Y4R2dqVk02dkRuYmJndkp6UDAyUFc1?=
 =?utf-8?B?UTdvMldRMTd5U0pqVWE0am9vK0pxcGtpU3FiSlkzeWhmQno3LzU2MTNYeERp?=
 =?utf-8?B?aVdDMllnWjl4U2hqNXBXZmI3MnNLaVBpNTMxaExMd1Q5b2I1NjNCRXE3TnNn?=
 =?utf-8?B?Q1c4RDR2TEZUU3kyaWNBSEpreEcvQ2lZTFYwWE9uZkRkZjRKWmdZZ1M3NlhG?=
 =?utf-8?B?TlBVQmNMTVA0TU9IcjNraktNMVlKbkl5aEZZb3QyR21mbVc1bno5NDNERDdr?=
 =?utf-8?B?TE9XSktTbmpVMlUzMkhiRDk1a3gxVk1sMC81MzluOVVFcVR0SlVvSDIrczZJ?=
 =?utf-8?B?UWNzNE5vT2lQZ0ZyRFZlZVhnbUMvdmpUUlZkVUx1NTk0UEN4TDdLT3RRZ3VV?=
 =?utf-8?B?U2F6YnJrdkZFTncvRUhTUUJ3aXpLK2FzbGk2blJYMFA2Qm1XZjhEMkpITDlP?=
 =?utf-8?B?aUxPSWwxQXVjNzdNYk5SajR4WDZVbTZCSjBsbUlLQWNsVkl6QUZWY1YxMUM4?=
 =?utf-8?B?akhFSjdCL0k1K0hOMXMxWjVTcFRQNkhFRGFTVnZ1RHkyYVA0UkdOYUNqakIy?=
 =?utf-8?B?SVJoU0VCcEdQSWFGZFNzMnR0RlJ0M053LzVkdzF3YlVMOVNEYmVLMjR0WFRK?=
 =?utf-8?B?MWlWSjJlWWxOd1VlYW94UTdmYWRldGVWdDI2YlVUVHo4U0ZOVzEyWC83c2ZT?=
 =?utf-8?B?ZE9uV3FUVnY3NWRWeW9xL0dTam82Z0U2V3ZLZCtpRGo1UTF6RGVsTzkvY2Rh?=
 =?utf-8?B?UWlZU0N1Q1NtZ0VWdnJNWHJlTlgrdmZ6d3NoTk9TYzQzVEFBZ2ZJN0dGeDlr?=
 =?utf-8?B?cWFYb0d1VWhwa3ltMEQvMHdOeE50MUxFeXczMWRsWWdSbGRNTHViU2FsaEo1?=
 =?utf-8?B?ajNWVWpiRU52d0M1Qm03WUZBN3ZYM2p6eDE0a0hLOHRYZ2hpS1JJOWF3NUFD?=
 =?utf-8?B?NXNGQXYzaWpKalI4QzJHZjVlRnU1NFo4L1p0b2NKQTNPK3dOODZlc3Vsd3pL?=
 =?utf-8?B?VWIrQVFpMDI4Uk9GRjJFWmw1VDBLejRTRHRtWVN5QUkyRjgrTFRlOERic2Fr?=
 =?utf-8?B?N244VmZlc0twUDZrb3d2WDhHUXFEL1pTKytRNm9KbDRlVkxOSWJDSUtDd3hn?=
 =?utf-8?B?cjltYjE3cnBUVmpIZTF3ZEE3ZHVBPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c7d33e8-a310-4faa-d5f3-08dac3f2664e
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 14:38:29.5571
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yFKDSKV40xIg8/yi98cqA3iBoJdC7fwgPYdPsBQTYZGmFa7lJGLnX0EZA1weSGHuc2YYFwKy0b45zjwz1S4/ew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7149
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/11/2022 13:30, Rob Herring wrote:
> 
> On Fri, 11 Nov 2022 18:14:58 +0800, Wayne Chang wrote:
>> Add device-tree binding documentation for the XUSB host controller present
>> on Tegra234 SoC. This controller supports the USB 3.1 specification.
>>
>> Signed-off-by: Wayne Chang <waynec@nvidia.com>
>> ---
>> V1 -> V2: new change for adding nvidia,tegra234-xusb.yaml
>>   .../bindings/usb/nvidia,tegra234-xusb.yaml    | 159 ++++++++++++++++++
>>   1 file changed, 159 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml
>>
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Error: Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.example.dts:36.27-28 syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.example.dtb] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1492: dt_binding_check] Error 2

This compiles fine on top of -next. We are just missing the change that 
populates the required definitions.

Jon

-- 
nvpublic