Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Nov 2022 16:12:11 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Linus Walleij <linus.walleij@linaro.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] gpiolib: of: Use correct fwnode for DT-probed chips
Message-ID: <Y25mS7bKQbww7a0A@orome>
References: <20221111113732.461881-1-thierry.reding@gmail.com>
 <Y241vwu47PbjrbBQ@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="FcC3BGDnC/jm6qBq"
Content-Disposition: inline
In-Reply-To: <Y241vwu47PbjrbBQ@smile.fi.intel.com>
User-Agent: Mutt/2.2.8 (2022-11-05)
Precedence: bulk


--FcC3BGDnC/jm6qBq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 11, 2022 at 01:45:03PM +0200, Andy Shevchenko wrote:
> On Fri, Nov 11, 2022 at 12:37:32PM +0100, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >=20
> > The OF node store in chip->fwnode is used to explicitly override the FW
> > node for a GPIO chip. For chips that use the default FW node (i.e. that
> > of their parent device), this will be NULL and cause the chip not to be
> > fully registered.
> >=20
> > Instead, use the GPIO device's FW node, which is set to either the node
> > of the parent device or the explicit override in chip->fwnode.
>=20
> Thank you!
>=20
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>=20
> P.S.
> It's good we have this report, which means I have to reconsider the
> followup I'm cooking. In any case I will send it after v6.2-rc1 for
> broader testing.

Feel free to add me on Cc if you need the patches tested on OF systems.

Thierry

--FcC3BGDnC/jm6qBq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmNuZkkACgkQ3SOs138+
s6ExSA/7BD6Hk92SBu9AfBzKPMAlKmHtdBADgIpNRLvSuvULJQuk8PCQA3YX6S4j
WCtL7HsnzLJ2mqXjAVTDVo8/hPj0R51yffSvKspswtW2Au3A9kBKerol9TPyJnZ3
9piQ/c3NbkrnvGIQaZzUl3dsRQ4u+sbh8k5suDCy3VIbt7QSiaj6LHyaPiO4gTu6
eL5j/YAYMGzetHYZnbSK8g0z8GtKWKDja1TPXp0RCuqQhNR2MkJ11gw6PE03iDdo
Ay1sEPc8slKLBewq+ph3+PjowitYgVRu0/9KKALdiDQsnTdespSerwCQqGdv5Q86
W/OiPMG8zWRL1UoI6xHQGFCMHJuVXn+m8oET8mOZOAqbSZfIOUVC2V+ZU+sP6pbt
cLZuXyjHmbE/PUfHqYSsIWoS6ky2u+nVc/yJbdDcLfCZ/HRn/EyZ9smb0thqJ1CZ
RyB7Z0wxaU58dH33iYKlZQZFvye3TcC6lQVGYZZTUGigaH0lsZoBndtBOzrcKnaL
ETpnAkjCWkXYZ+FlYzZcFFK+kcHaHM1k02YwbIHJ1tCHaRllu6nFQBIRKGvb8dT6
5N0GU5IHgzbxXA/0phXIdVWctHkLCNxx20FQ00R7KNJpfN+295IK0PGdaL0d58hA
nkfbff4489Gm5oVW9k7FVWlv4DoA+1l7WAAn3+fleCHevBgLZUw=
=vvq/
-----END PGP SIGNATURE-----

--FcC3BGDnC/jm6qBq--