Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7198b11e-e9e3-6cbe-e2e8-dce3eb998f7e@intel.com>
Date:   Fri, 11 Nov 2022 08:09:02 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.4.1
Subject: Re: [PATCH] dmaengine: idxd: Fix crc_val field for completion record
Content-Language: en-US
To:     Fenghua Yu <fenghua.yu@intel.com>, Vinod Koul <vkoul@kernel.org>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        dmaengine@vger.kernel.org, Nirav N Shah <nirav.n.shah@intel.com>
References: <20221111012715.2031481-1-fenghua.yu@intel.com>
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20221111012715.2031481-1-fenghua.yu@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/10/2022 5:27 PM, Fenghua Yu wrote:
> The crc_val in the completion record should be 64 bits and not 32 bits.
> 
> Fixes: 4ac823e9cd85 ("dmaengine: idxd: fix delta_rec and crc size field for completion record")
> 
> Reported-by: Nirav N Shah <nirav.n.shah@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
>   include/uapi/linux/idxd.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/idxd.h b/include/uapi/linux/idxd.h
> index 61ee43823622..09947ae61663 100644
> --- a/include/uapi/linux/idxd.h
> +++ b/include/uapi/linux/idxd.h
> @@ -329,7 +329,7 @@ struct dsa_completion_record {
>   		};
>   
>   		uint32_t	delta_rec_size;
> -		uint32_t	crc_val;
> +		uint64_t	crc_val;
>   
>   		/* DIF check & strip */
>   		struct {