Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Elliott, Robert (Servers)" <elliott@hpe.com>
To:     Zhen Lei <thunder.leizhen@huawei.com>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Frederic Weisbecker <frederic@kernel.org>,
        "Neeraj Upadhyay" <quic_neeraju@quicinc.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] rcu: Dump memory object info if callback function is
 invalid
Thread-Topic: [PATCH v2] rcu: Dump memory object info if callback function is
 invalid
Thread-Index: AQHY9bjXD1e3c0hMYEKiHo9i156+S6453hBA
Date:   Fri, 11 Nov 2022 15:50:34 +0000
Message-ID: <MW5PR84MB1842F925447B4BD175CF23C9AB009@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <20221111102822.224-1-thunder.leizhen@huawei.com>
In-Reply-To: <20221111102822.224-1-thunder.leizhen@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lxAkz7HvnTxL4rOsho7CT46R4A+SqTXtI52oCtyn4+0446i9k0EJ++wI/XdU?=
 =?us-ascii?Q?nvUSIvv3sE2w4Blu+KMbMZN46tFyTw2iuhonmUkEFQsD3l195WMmNRf+Qpwn?=
 =?us-ascii?Q?EgE+cVnRTCOJFIhj6zsT7vfRMpUTjDssAj1FYhkW/ff98drG2JagOApdxoZw?=
 =?us-ascii?Q?33WpVtORMPNDEdpkHFP9MqltA2hKpae7pXxA7vn2QqN32W38wPadGHGTsdiu?=
 =?us-ascii?Q?mD7XewVg2BQl3mX+uSUmEk2PF/ReH9Bl58MkaRr9FnYkPimGzXEuVnAsD9Pl?=
 =?us-ascii?Q?KE2KVj/bn9aZgaDxI20xLmfCydBVpwz4HwYbyzBT4DQaT2cIeAEBjt+kUqPX?=
 =?us-ascii?Q?VeJpMKJ/MCwF21FwQcewzt3/9xA/iT1z4p/wQiAIjcm/cstRWw7WkQM40xsv?=
 =?us-ascii?Q?LA3v2+/As9F/nt7/W0vUDqFvCnGt6pLewjlh0M4oB19Fz2ojPsFygVnx5LjX?=
 =?us-ascii?Q?N25zA8Ey6YaCrjzIh/MZeNby9FDhxvIhqRxtv3mln6zHqHlHi5WekUW/Tj4f?=
 =?us-ascii?Q?4ImEasfvaJjlEcrqTt5H2fDEk68c9fpVWYHIcW+LEkGdSMA9VQJhi6dsg8do?=
 =?us-ascii?Q?7DylJXGC25CF3DwqaiPaed4g9dLhPmR7ziH+/GfEbMT/OoDli6yW1o89hKBQ?=
 =?us-ascii?Q?jHCiZY73f9MBL7ZNZPco23H3YOBHdsZ1SeoFysGmJ7qZCIuy3YeNh/VUz7/l?=
 =?us-ascii?Q?1T+CK21ga+3e3+1+les2gdA5IiVlC6a9axQ41FPAsQc0MmSy7EX5+BlCpvop?=
 =?us-ascii?Q?lk6yycgOeS+PjDyCB5VyIP5QiksWLQedVtRiR+op0wkMQURvmC9dF/KgBRHG?=
 =?us-ascii?Q?8O2RFJOot8GylA0BxqOyDiZJur/4LmoG7k9RiqmPzCYovZN+TkcCBZC6zo3S?=
 =?us-ascii?Q?VBC7CGijHmzlcjO986vYg+BF6HmjreFnlK/ftW6uqQ+MJvgCCe7MHrScrbce?=
 =?us-ascii?Q?vRTw5qzeHXFbchkdFQx0iHNnYY1tFIxwSjHwClYuTDTPSAqAgCvcT0GYrNYE?=
 =?us-ascii?Q?64TnoGPqh13cf89b80zZ2qconymmpAMQ3HdX9TEI2f9sygOVQnMPA03EPkkC?=
 =?us-ascii?Q?sQyOHrSTEOzMRhLmFK3q7+5lpB97LtgPoRUiEi0b/77aWJ49P7pT5ePpwqc/?=
 =?us-ascii?Q?AbqcswzT4m7soWNcLl9hR9eBNz3StrlFB6/1j844Le23Kaqy0zs8h1t37Baq?=
 =?us-ascii?Q?WjrJy7yoogtpTg/hnZHEe1Gi+RksZJtDyLiY9IIcRbAyiKxah+2V9gykYAkw?=
 =?us-ascii?Q?TjdcvLmIm5DwsZFe4ni12UvSKJ78mpojmKkY/sjJ1VhMwRhqollJv+VaZQT2?=
 =?us-ascii?Q?ZF9PSO3BAHMsXhk6nDhzq+jR26w3OHylju7chN5aNUS7JjiKkBt0+hGHbjMa?=
 =?us-ascii?Q?sVGFeqrMbLsJ0RGR1XCxNqSOPz46qXsv0/1kD/4iWZd4Hhl+60jhtqrnCQQM?=
 =?us-ascii?Q?7oCUGE3AvlDPb/IH/D75hpzEJt5YUzRrPCSJmpqXf7+62ZeI3hL/iG6Dfbd7?=
 =?us-ascii?Q?dqEqIT//q2vmU4rK7RIZF9tmj/gg0PeuF4mSq9LWV9/ZOXzRy8jfMuGT3QmJ?=
 =?us-ascii?Q?wc8809y2zN2h6Zjqics=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 158bc376-a6d8-4a4e-d4fb-08dac3fc78a5
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2022 15:50:34.9342
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WAyKYcGtFHjS0XNVvMMDa/SCfjRub+0znK8QK2O3akyBgGKsHWYw7bsqOTdKD7HZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR84MB1357
X-OriginatorOrg: hpe.com
X-Proofpoint-ORIG-GUID: NKUUmKikswbXlIthkjlDzzMtt1M60KuH
X-Proofpoint-GUID: NKUUmKikswbXlIthkjlDzzMtt1M60KuH
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-11_08,2022-11-11_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 suspectscore=0 clxscore=1015 mlxscore=0 impostorscore=0 phishscore=0
 bulkscore=0 priorityscore=1501 mlxlogscore=999 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2211110105
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> +static inline void debug_rcu_head_callback(struct rcu_head *rhp)
> +{
> +	if (unlikely(!rhp->func))
> +		mem_dump_obj(rhp);
> +}
> +

The mm/util.c definition of mem_dump_object() says:
 * This function uses pr_cont(), so that the caller is expected to have
 * printed out whatever preamble is appropriate.

so this needs to call pr_alert() or pr_err() before that to explain what
is being printed (with no \n), like these:

kernel/rcu/rcutorture.c: pr_alert("mem_dump_obj(%px):", &rhp);
kernel/rcu/rcutorture.c: mem_dump_obj(&rhp);
...
kernel/rcu/tree.c: pr_err("%s(): Double-freed CB %p->%pS()!!!  ", __func__,=
 head, head->func);
kernel/rcu/tree.c: mem_dump_obj(head);