Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1f230520-b035-c14d-4262-49a52ec6a557@linaro.org>
Date:   Fri, 11 Nov 2022 17:44:11 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH RESEND] nvmem: Fix return value check in rmem_read()
Content-Language: en-US
To:     Yang Yingliang <yangyingliang@huawei.com>,
        linux-kernel@vger.kernel.org
Cc:     Wei Yongjun <weiyongjun1@huawei.com>,
        Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
References: <20221102032523.1488171-1-yangyingliang@huawei.com>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
In-Reply-To: <20221102032523.1488171-1-yangyingliang@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 02/11/2022 03:25, Yang Yingliang wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> In case of error, the function memremap() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
> 
> Fixes: 5a3fa75a4d9c ("nvmem: Add driver to expose reserved memory as nvmem")
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> The previous patch link:
> https://lore.kernel.org/all/2fff7c82d983baccb91c4a1c0891a9b6cdc50dd6.camel@suse.de/T/
> ---

Applied thanks,

--srini
>   drivers/nvmem/rmem.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/nvmem/rmem.c b/drivers/nvmem/rmem.c
> index b11c3c974b3d..80cb187f1481 100644
> --- a/drivers/nvmem/rmem.c
> +++ b/drivers/nvmem/rmem.c
> @@ -37,9 +37,9 @@ static int rmem_read(void *context, unsigned int offset,
>   	 * but as of Dec 2020 this isn't possible on arm64.
>   	 */
>   	addr = memremap(priv->mem->base, available, MEMREMAP_WB);
> -	if (IS_ERR(addr)) {
> +	if (!addr) {
>   		dev_err(priv->dev, "Failed to remap memory region\n");
> -		return PTR_ERR(addr);
> +		return -ENOMEM;
>   	}
>   
>   	count = memory_read_from_buffer(val, bytes, &off, addr, available);