Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <74694fa7-e3e6-986b-7bf3-ce2ec9ab3992@linaro.org>
Date:   Fri, 11 Nov 2022 17:47:17 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] nvmem: lan9662-otp: Change return type of
 lan9662_otp_wait_flag_clear()
Content-Language: en-US
To:     Horatiu Vultur <horatiu.vultur@microchip.com>,
        linux-kernel@vger.kernel.org
Cc:     gregkh@linuxfoundation.org, kernel test robot <lkp@intel.com>,
        Dan Carpenter <dan.carpenter@oracle.com>
References: <20220927205916.511556-1-horatiu.vultur@microchip.com>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
In-Reply-To: <20220927205916.511556-1-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 27/09/2022 21:59, Horatiu Vultur wrote:
> The blamed commit introduced the following smatch warning in the
> function lan9662_otp_wait_flag_clear:
> drivers/nvmem/lan9662-otpc.c:43 lan9662_otp_wait_flag_clear() warn: signedness bug returning '(-110)'
> 
> Fix this by changing the return type of the function
> lan9662_otp_wait_flag_clear() to be int instead of bool.
> 
> Fixes: 9e8f208ad5229d ("nvmem: lan9662-otp: add support")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---

Applied thanks,
--srini
>   drivers/nvmem/lan9662-otpc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvmem/lan9662-otpc.c b/drivers/nvmem/lan9662-otpc.c
> index f6732fd216d80..f4348c97f6e59 100644
> --- a/drivers/nvmem/lan9662-otpc.c
> +++ b/drivers/nvmem/lan9662-otpc.c
> @@ -36,7 +36,7 @@ struct lan9662_otp {
>   	void __iomem *base;
>   };
>   
> -static bool lan9662_otp_wait_flag_clear(void __iomem *reg, u32 flag)
> +static int lan9662_otp_wait_flag_clear(void __iomem *reg, u32 flag)
>   {
>   	u32 val;
>