Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2653142rwb; Fri, 11 Nov 2022 12:35:31 -0800 (PST) X-Google-Smtp-Source: AA0mqf4fRIFoyveG9IhyNl1ogpjBK0ZSDPZchakTJjsGAR2IkNeMgcD/UTscLoSyEkL7qETx5GXA X-Received: by 2002:aa7:ce03:0:b0:461:72cb:e5d with SMTP id d3-20020aa7ce03000000b0046172cb0e5dmr2924968edv.410.1668198931046; Fri, 11 Nov 2022 12:35:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668198931; cv=none; d=google.com; s=arc-20160816; b=Y+L17S5FblN7EibNY92GmIHm41gs1YoqpEEdQxS3q/KXkbKEKY5m1BoX/wyYlOJ8Mb o6Ha9keTeBv2eFhzml5qHamZIHgf3Kn9oOFIYsR7ugBn+1EqWV+15eT8gXRZKnMD47BI xofiuYbIVQDQPYToBxtVrdjhfDjlXqWREVDcvNqFkcnrbbZeYT0V5J8FdcPFW0nXen+C YLzAMgdi+/WBTa4l8FjmfOcG/8ODLFbGqXkybWS91mbO9ZzaLCNbHwDEDiJ3/1KWhvVw YWRM4iIOu+iAw1eDomEJgJWL9A6mOQFZjCZOGqTixLL8WAa4lUWGAZZFHnKZRoynifRF aUzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6BTtdqa8sdTYkRSCpHjA3mb/u7We27+oOjJ+vh2/0+I=; b=fnzV3TQhcowRXCP8xwLc8BnKYuDZQAYDVkBjGUQnJoU5OjxlrbDXtsktQwOgeQvGQI l2MNsZ8V68Yk3xT0nCsZovfuHEYa0d38q8YsISZj8LrgzvGE97NGk3o5tmZJtoOOnpRb hXVyG1uqxTDz/bEY7279ngxu4vykTJUyzqXYvt5oWzhghyCEd7H8bxJyZvwqCJgMcYIU TzEx+KefRv37Bf1vYoPrBNqRE8BBa2COPFmDNudEgcQO7eZijY22xhtCNb9HsAZZv2In iFlus+6z20JQ8t2uAAUmyCs9hQS+78nyQ3IZ05kiLdySEwu+UYK8O2rLKs/JASLfvn6w M8wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ZlU3ElOW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qw24-20020a1709066a1800b007807e1f3d9dsi2947795ejc.842.2022.11.11.12.35.09; Fri, 11 Nov 2022 12:35:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ZlU3ElOW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234271AbiKKTlf (ORCPT + 91 others); Fri, 11 Nov 2022 14:41:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234083AbiKKTld (ORCPT ); Fri, 11 Nov 2022 14:41:33 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0C657BE73; Fri, 11 Nov 2022 11:41:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668195692; x=1699731692; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6OKKKDy9v2C88/Cgkd/4gimgSJyIoKFF2eqslbtPTsU=; b=ZlU3ElOWPrdlqrW58Ne/QtgyYkc/ZqR+hQOETkLdSBtt64KTTDBKEkBj 5S3JoslYibFNNeM3DcvUTabQg23hh+B4kg3WfWwOO9Ji6x7sH2np4aRXq xucV3SKHw0qwON4uQHcR25vv1tIbXWCGPAElUoUEWdCvTLkGqJZPJnlO9 cwlyC0RNBxoL5SrisEROw5otjBEoZYX0YwztmHzKvLxZZ0kByf617MUm1 9QZ6nZO/k9YW/j2qBQzMX4Si9VTIIIywxiSAmJV5ogb1BU5ctADVA0Ofn 3h3cpBAV3oh+s+DBPmhIrqrCRQ1+i85PmpzdnBj942UbPIto2dmshIA7L g==; X-IronPort-AV: E=McAfee;i="6500,9779,10528"; a="311660459" X-IronPort-AV: E=Sophos;i="5.96,157,1665471600"; d="scan'208";a="311660459" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2022 11:41:32 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10528"; a="882852434" X-IronPort-AV: E=Sophos;i="5.96,157,1665471600"; d="scan'208";a="882852434" Received: from punajuuri.fi.intel.com (HELO paasikivi.fi.intel.com) ([10.237.72.43]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2022 11:41:30 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 58ACD2033F; Fri, 11 Nov 2022 21:41:28 +0200 (EET) Date: Fri, 11 Nov 2022 19:41:28 +0000 From: Sakari Ailus To: Andy Shevchenko Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Tianshu Qiu , Shawn Tu , Bingbu Cao , Mauro Carvalho Chehab , hans.verkuil@xs4all.nl Subject: Re: [PATCH v1 1/8] media: ov2740: Remove duplicative pointer in struct nvm_data Message-ID: References: <20220726120556.2881-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On Fri, Nov 11, 2022 at 05:29:16PM +0200, Andy Shevchenko wrote: > On Fri, Nov 11, 2022 at 02:58:45PM +0000, Sakari Ailus wrote: > > On Fri, Nov 11, 2022 at 02:08:48PM +0200, Andy Shevchenko wrote: > > > On Fri, Nov 11, 2022 at 02:05:37PM +0200, Andy Shevchenko wrote: > > > > On Tue, Aug 23, 2022 at 05:10:35PM +0300, Andy Shevchenko wrote: > > > > > On Tue, Jul 26, 2022 at 03:05:49PM +0300, Andy Shevchenko wrote: > > > > > > The struct i2c_client pointer is used only to get driver data, > > > > > > associated with a struct device or print messages on behalf. > > > > > > Moreover, the very same pointer to a struct device is already > > > > > > assigned by a regmap and can be retrieved from there. > > > > > > No need to keep a duplicative pointer. > > > > > > > > > > Thanks, Bungbu, for the review. Can it be now applied? > > > > > > > > Don't see this being applied or commented why not... > > > > > > > > Mauro? Or who is taking care of this driver nowadays? > > > > > > Okay, found a private response by Mauro where he tells that Sakari can take > > > care of this. Sakari, should I resend this to you with all tags applied? > > > Or you can use `b4` tool that allows to avoid unneeded resend. > > > > No need to. But please cc me on the next time. I'll take a look now... > > How should I know whom to Cc? Can we update MAINTAINERS accordingly, please? Good question. In media tree we've listed the maintainers in wiki, as the information would be hard to keep up-to-date file-wise: So it helps if you cc me to camera sensor driver patches, but they're neither ignored if you don't. It usually takes a little bit more time but not nearly as much as this time. Cc Hans. -- Kind regards, Sakari Ailus