Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4862f68d-090c-c73d-0711-2677a20ef874@intel.com>
Date:   Fri, 11 Nov 2022 12:41:29 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2 09/14] platform/x86/intel/ifs: Use generic microcode
 headers and functions
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
CC:     <hdegoede@redhat.com>, <markgross@kernel.org>,
        <tglx@linutronix.de>, <mingo@redhat.com>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>, <sohil.mehta@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-10-jithu.joseph@intel.com> <Y253FKtLnmV3r7Kj@zn.tnic>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <Y253FKtLnmV3r7Kj@zn.tnic>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHNiYVhrME5tMlRUTWVROXphZHFSU3Z2aG9RUnRUSGUwTlAwNjM3UHgxLzB2?=
 =?utf-8?B?K1hkSVF6RjFXSk45UkpQNmxvWnVQZ3dXbjByNm5iVW1BZmo2a3ZmN0FsQUJV?=
 =?utf-8?B?dXJ1RDV5bTdsUkJPV3oxYlV1R3lZdTVjMldlYWlQb0U0Y0FVM3JPaWprNXB0?=
 =?utf-8?B?dk9FYzJzejNuTHNyQmx4OUl4dVZJNTdEL3BoQi95TG9kNWhua0l1MEVMRDRv?=
 =?utf-8?B?K2NBcm5hWnNCaEhLakdtTUN1MDlENVI3QnhTdm1xNjRNa3lGZnBkM2hVQmg2?=
 =?utf-8?B?bDJHWFVYU2ZxRjl6cDluLzBlT2tCb3JyT054VFpUTytZakgxRll3Vm9YSXVU?=
 =?utf-8?B?UE4rYnJxYWdqZFA5bXBXOURmditxcGcxaEhVb0lIQ3R6ZXQxUEVuWWZCVk00?=
 =?utf-8?B?anVKY3dHcXZiQVJTc0R0VURqb3djWDBQTkpxNVZmRDVOaGVPdUZuTDBEUmcx?=
 =?utf-8?B?OGZRd0krQjd4UWpGNmR1L0phYVZQaDlTM0xwYmkzc2lBVjRZUVF6dkRDdFFV?=
 =?utf-8?B?RGZpVndUcExpa3lqMXRTSUtpUGF0eE1SaitoWkVHRGMxbXlrYkxWekE2MDcv?=
 =?utf-8?B?aGpqU0I3NTBmNHNlUHlhVEFzaVBTWHpKMGtYSkdmZWd2Sko4Si8zSnZNY2Qx?=
 =?utf-8?B?RDZQUzQ2alNzcjM2OExjVm4vQVlnNER3NmgrbHVJb0RpU1czOHZJWC9TWEhx?=
 =?utf-8?B?aGl3eGZEeEhDSHN6RGlQVEZBR1dkZDJsYVUzK2VJMk92QXVqY3lEdk1RTVBi?=
 =?utf-8?B?cG1BOUZSVDlGWUw0bjhYS0dRbmVzdTR1Z00wa3pVY0p0M0FTdXlaSWNMZ3Vo?=
 =?utf-8?B?TEJ3bVdValZlclc0ZjBhejE0cVhtcjgxK2k0cHdabzBLY25kb2xJeEFGUjRa?=
 =?utf-8?B?UDViSkJldUZZdktMREd6bDZyb0lVOWErVVlZMnVsellPbG4xOXdvcUZQMHli?=
 =?utf-8?B?UHo5VVhLUDYwRjYzN1Jqa1AyeVZWWkp1SlBNcVpwZklpbWh2R0wvalYvR2Jq?=
 =?utf-8?B?K0o4c2J2cklkd3gzNFFjWjVPMDF2eGh1UWYxY1dBNmlGSmlaS0FQKzBqYTVx?=
 =?utf-8?B?OEVGZDFPeXZTc3BjOGMrN2hiZ296aDZiVjgrUUNybkkvcGJMRFp5eit5clFN?=
 =?utf-8?B?d3M3RC9seXhhMWgyY3IzZFRaR0c3c0s0ckZxbngrSEI5L3V3RjVVcWJzbHI3?=
 =?utf-8?B?L2NacnhSblk5QWk2VDBHQnpFdmN1MndXemgwQ0JBZnhGWktrU09GNHo2a3BW?=
 =?utf-8?B?d01kVGFvY2VWM3VDOWdOd2UrSlBHd3E4MTZZTzRpVEZJelJjOGl0OUVSRDdH?=
 =?utf-8?B?a282ZHpSby9zYkVtUWtnZ2p2cjRQc0dINkdlSXBUY0s2eFFZRTlEenBQalJ4?=
 =?utf-8?B?WGFEN1NmS3k2bXVheTlRSHlZd2JNT0RXT0RKSTFCL1hna2tlWVE0RXA1dGtW?=
 =?utf-8?B?SkZPaU5DUFBwang5ckRWT0YxeTczcjNxWEVubzJ1Qm1xMFluT0l3OGM1RjJi?=
 =?utf-8?B?bUN0bzlRL05HMnpDdGJYS1pYZkNQaitPR2o1NU0rZkxuMlNYR1VHR1dBMGdP?=
 =?utf-8?B?cUxJK1hLcEZBa3pHWXNpdGIzaUlmS0NPRWdNdHJqWkhYOGtIRWhTOTF0bFhh?=
 =?utf-8?B?bUhmVy9wTkkwV1h2c1RGQ1BVMmxiZGQ5T2Vwd0Jzby96QjA3UG01dkh4UExC?=
 =?utf-8?B?MXRlWUE3ajh0TGUvM3Y0MjROUStsNFNEeUNUVzJZRE9JV2NWY2w1czNzTjFU?=
 =?utf-8?B?YVpEeWViNGJWS0tGdVd4dFIrcXpUMDRxUTFaQ3dqdUlUQkp1OEp6c3Y2RGlY?=
 =?utf-8?B?WDQyUzVUVnpsbVpaeGJVVThNMGhMNFBWU1ZlaWNjcFgzdE5jRFlaa1Q4eE5x?=
 =?utf-8?B?aDhJUzEyL28zWFRHQndIMEhJSkNmU2lZdkNDQVJNWFRzV1pQdVB6T3d6dzRC?=
 =?utf-8?B?c2ZJSkRkWWpDemZTSWFFOEN5bVpwQzNnRjJqV1ltOGpuTm1zWTg0SEFrMTRW?=
 =?utf-8?B?bm1IQi8vdDF2eDc2QnpYNGhyYmlnY3ExdjVsdjZ0VEhBZjl3NExaTXZWK3Nr?=
 =?utf-8?B?ODdKcjVjaE9oVUVVek43ZVJsZzN2N2pkeGV1YmVYL3V5dWc1S1BaSVhJTEFE?=
 =?utf-8?B?N09YWDJpcWcweTNYclRtRGFldVgzNk1KcWJCaThQcnBzbE9yV3FZOThUYUY0?=
 =?utf-8?B?SWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c1846a18-e26b-43a8-c728-08dac4251dee
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 20:41:32.2462
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c5arR2lba8uSiA2CPxfnVkjeLNveb+9DMriDdjnhQiLdYbqmMobczsoZI17qTM34BrSCGSKc9msj66epTa/LFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4932
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/11/2022 8:23 AM, Borislav Petkov wrote:
> On Mon, Nov 07, 2022 at 02:53:18PM -0800, Jithu Joseph wrote:
>>  static int scan_chunks_sanity_check(struct device *dev)
>>  {
>> -	int metadata_size, curr_pkg, cpu, ret = -ENOMEM;
>>  	struct ifs_data *ifsd = ifs_get_data(dev);
>> +	int curr_pkg, cpu, ret = -ENOMEM;
>>  	bool *package_authenticated;
>>  	struct ifs_work local_work;
>> -	char *test_ptr;
>>  
>>  	package_authenticated = kcalloc(topology_max_packages(), sizeof(bool), GFP_KERNEL);
>>  	if (!package_authenticated)
>>  		return ret;
> 
> Bah, how big is that thing so that you can't simply do a bitfield on the
> stack here instead of kcalloc-ing?

Will modify it to use individual bits from a u32 to store package authentication status.

> 
>> @@ -203,67 +174,33 @@ static int scan_chunks_sanity_check(struct device *dev)
>>  	return ret;
>>  }
>>  
>> -static int ifs_sanity_check(struct device *dev,
>> -			    const struct microcode_header_intel *mc_header)
>> +static int ifs_image_sanity_check(struct device *dev, const struct microcode_header_intel *data)
> 
> Yet another static function - no need for the ifs_ prefix.

Noted ... will change


Jithu