Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Besar Wicaksono <bwicaksono@nvidia.com>
To:     Will Deacon <will@kernel.org>
CC:     "rafael@kernel.org" <rafael@kernel.org>,
        "lenb@kernel.org" <lenb@kernel.org>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "guohanjun@huawei.com" <guohanjun@huawei.com>,
        "sudeep.holla@arm.com" <sudeep.holla@arm.com>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        Thierry Reding <treding@nvidia.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Vikram Sethi <vsethi@nvidia.com>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v2] ACPI: ARM Performance Monitoring Unit Table (APMT)
 initial support
Thread-Topic: [PATCH v2] ACPI: ARM Performance Monitoring Unit Table (APMT)
 initial support
Thread-Index: AQHY05p5Zh4pJFmZEk6UwzpU+Lc4ma40EgWAgAaXIeA=
Date:   Fri, 11 Nov 2022 23:54:07 +0000
Message-ID: <SJ0PR12MB5676DF8011687CFB0E124FC7A0009@SJ0PR12MB5676.namprd12.prod.outlook.com>
References: <20220929002834.32664-1-bwicaksono@nvidia.com>
 <20221107191034.GB21991@willie-the-truck>
In-Reply-To: <20221107191034.GB21991@willie-the-truck>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nT/5x8uOewOPBSiIVScWpxdnUGyatLJjXnRRZunv7f6iJx3ofxxUGYxuvZjG?=
 =?us-ascii?Q?siBpSh26S4loBmljAZNEMrIH2xeKX3ujL2+Dr581sPJg2O7qUQbC0X34JYVh?=
 =?us-ascii?Q?HkhCQo4D3XCEy24AHgXMg38iPbR5jxy/p2S8B4twBpcaXb+85tWiB+CbOCN3?=
 =?us-ascii?Q?vfaF9Am80aVMEpNS5WRCIXXNVXEg1brAg0IFp/PnoPfIKKu/WPWCWcKhmIhw?=
 =?us-ascii?Q?JZ/HHX59g3qDAB38Bu7EdkYml7At28R7PAg/jlihJI1HTB/HJy+dy+l0tf4Z?=
 =?us-ascii?Q?weYcFTHX6Z74yUIT4Jsep57GltbqCbMESgmHNk1O1ULulvtdQIMcs/SyHT4V?=
 =?us-ascii?Q?noGmlIzC8HCm+qU72yBXlPCaTeRmfN9J2U0SoW5H9P/A//2hGdtY+uHT4itj?=
 =?us-ascii?Q?5QYXo7C0QlHA747i/2GnUKlW3mnPh4ZPhaXfjub6EttTNHNLuHK/V9EN/XQq?=
 =?us-ascii?Q?1AFIMBv6I/9nR34/Y1m5KzTpeybHL2E3Zjkv+VbdVvvXSl6qiCu0ij4V62IN?=
 =?us-ascii?Q?doaO6aNX3RNXAvvW1wg3iMbO9vBkV4zuZsHYPO/J9xwHcxDncMaGmsQIu0uT?=
 =?us-ascii?Q?SJ4UMQS7CFL8wHxMF0dYzOz17OdUq23zJ6omZbb3L77/4vUC8L2WwozFg38M?=
 =?us-ascii?Q?XCXPB8i/gTN/2PpCfOPzICHP7TM0FoWikEZlhbBI01qF0X9yzfdrTqzVI+7A?=
 =?us-ascii?Q?ZjiSARU3nzyfNxSWLQkdcXyc4kebAv5I4/xvqaEwwelZD2hboluwwPbVtMU5?=
 =?us-ascii?Q?877xrx02DGL4ePgVBwQpcDye3gT78ZbCzVreAZ3N75JD0Jclgh9B1T8FSpu7?=
 =?us-ascii?Q?scxp0h4rboHJ6xBNi7B64Mlt6p81d9oSEk2KiaGN0ZYLvuXzYko/JSkhba5S?=
 =?us-ascii?Q?vt2hMysSZg8vXnYpWWX++h0M3In0s+NDp27jqTO7Vb81nwrtE7u/MVgx9Tqs?=
 =?us-ascii?Q?GdwiDYYS26q9XajYAS1gAN+k+jRGzlufm07bjWrMdWidPYwceJMjMhNea0IX?=
 =?us-ascii?Q?Y4BpGrhJb78SdT0CCnyClWbejQ5zbvc67x2n5/MLqSUJK0jWagyoeIC7PZ0P?=
 =?us-ascii?Q?hblbQgM3jZekJDL10MGLxPokzFXUbGp5JAW8DfR3lx4DKdWbvLaIK5vt6Mqv?=
 =?us-ascii?Q?ZtFRiud1GEIBmDh99mL1oKGdkhwifD3fo/m98D9YAdBpQByb8SDRf8camlqo?=
 =?us-ascii?Q?lbwLkMawcoa9QsVhKdfLPe2oDmtFfQIFI3M0CB+sb/LTIQYMak66zKq9iMeY?=
 =?us-ascii?Q?YiqKDJ+nfI3AL0gGm/6t5o4zaxG0pYfjZXCGRs6+rF/FlJ7sndRcSfMSxLFD?=
 =?us-ascii?Q?8BC/gaCZb3+bStnmqTMe+QeJb+rWgXNH/7SxDSHdJg6YvvlREpN+S9Rm9zZd?=
 =?us-ascii?Q?jOk+P6zyHor45pB06Vh5W+yz3mn1o1wozRo5odxBMK1RcqD5OCcj9/8r9K7a?=
 =?us-ascii?Q?gIk4zmCCKImSavGYr+42rR3HKhVhKhpsfvK9LxKRBmFP2JeGJ2UcqTvzRZAl?=
 =?us-ascii?Q?8T2+wTp3QHCghK5jB2UN278sqsQuoqX/Zp+KGVTOQLRalnZ/CskrHPBth1/o?=
 =?us-ascii?Q?ykBYfv22jwkQmhOBge7XcWbaRdhW9zW3MrGE85Pb?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR12MB5676.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4cf9d7ea-9945-46f6-44f4-08dac4400591
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2022 23:54:07.6079
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: f3DrQh94E2/t1g3d1X2GuFGZQyZ84YL/jaGt1PLoMZWeQV6k/MKSr7IBFZZamFSUtAqv5YNNF5o5S5DcWq6exQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5203
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Will,


> -----Original Message-----
> From: Will Deacon <will@kernel.org>
> Sent: Monday, November 7, 2022 1:11 PM
> To: Besar Wicaksono <bwicaksono@nvidia.com>
> Cc: rafael@kernel.org; lenb@kernel.org; catalin.marinas@arm.com;
> lorenzo.pieralisi@arm.com; guohanjun@huawei.com;
> sudeep.holla@arm.com; linux-tegra@vger.kernel.org; Thierry Reding
> <treding@nvidia.com>; Jonathan Hunter <jonathanh@nvidia.com>; Vikram
> Sethi <vsethi@nvidia.com>; linux-acpi@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH v2] ACPI: ARM Performance Monitoring Unit Table
> (APMT) initial support
>=20
> External email: Use caution opening links or attachments
>=20
>=20
> On Wed, Sep 28, 2022 at 07:28:34PM -0500, Besar Wicaksono wrote:
> > diff --git a/drivers/acpi/arm64/apmt.c b/drivers/acpi/arm64/apmt.c
> > new file mode 100644
> > index 000000000000..f55167ca51e7
> > --- /dev/null
> > +++ b/drivers/acpi/arm64/apmt.c
> > @@ -0,0 +1,177 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * ARM APMT table support.
> > + * Design document number: ARM DEN0117.
> > + *
> > + * Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES.
> > + *
> > + */
> > +
> > +#define pr_fmt(fmt)  "ACPI: APMT: " fmt
> > +
> > +#include <linux/acpi.h>
> > +#include <linux/acpi_apmt.h>
> > +#include <linux/init.h>
> > +#include <linux/kernel.h>
> > +#include <linux/platform_device.h>
> > +
> > +#define DEV_NAME "arm-cs-arch-pmu"
> > +
> > +/* There can be up to 3 resources: page 0 and 1 address, and interrupt=
. */
> > +#define DEV_MAX_RESOURCE_COUNT 3
> > +
> > +/* Root pointer to the mapped APMT table */
> > +static struct acpi_table_header *apmt_table;
> > +
> > +static int __init apmt_init_resources(struct resource *res,
> > +                                           struct acpi_apmt_node *node=
)
> > +{
> > +     int irq, trigger;
> > +     int num_res =3D 0;
> > +
> > +     res[num_res].start =3D node->base_address0;
> > +     res[num_res].end =3D node->base_address0 + SZ_4K - 1;
> > +     res[num_res].flags =3D IORESOURCE_MEM;
> > +
> > +     num_res++;
> > +
> > +     res[num_res].start =3D node->base_address1;
> > +     res[num_res].end =3D node->base_address1 + SZ_4K - 1;
> > +     res[num_res].flags =3D IORESOURCE_MEM;
> > +
> > +     num_res++;
> > +
> > +     if (node->ovflw_irq !=3D 0) {
> > +             trigger =3D (node->ovflw_irq_flags &
> ACPI_APMT_OVFLW_IRQ_FLAGS_MODE);
> > +             trigger =3D (trigger =3D=3D
> ACPI_APMT_OVFLW_IRQ_FLAGS_MODE_LEVEL) ?
> > +                     ACPI_LEVEL_SENSITIVE : ACPI_EDGE_SENSITIVE;
> > +             irq =3D acpi_register_gsi(NULL, node->ovflw_irq, trigger,
> > +                                             ACPI_ACTIVE_HIGH);
> > +
> > +             if (irq <=3D 0) {
> > +                     pr_warn("APMT could not register gsi hwirq %d\n",=
 irq);
> > +                     return num_res;
> > +             }
> > +
> > +             res[num_res].start =3D irq;
> > +             res[num_res].end =3D irq;
> > +             res[num_res].flags =3D IORESOURCE_IRQ;
> > +
> > +             num_res++;
> > +     }
> > +
> > +     return num_res;
> > +}
> > +
> > +/**
> > + * apmt_add_platform_device() - Allocate a platform device for APMT
> node
> > + * @node: Pointer to device ACPI APMT node
> > + *
> > + * Returns: 0 on success, <0 failure
> > + */
> > +static int __init apmt_add_platform_device(struct acpi_apmt_node
> *node,
> > +                                                     struct fwnode_han=
dle *fwnode)
>=20
> I queued this already, but my testing kicked up a nit that 'fwnode' is no=
t
> described in the kerneldoc. Please can you send a follow-up fix for that,
> based on for-next/acpi? The indentation is also pretty weird with extra
> parameter.
>=20

Thanks for getting this patch. I have sent the follow-up fix with:
https://lore.kernel.org/linux-arm-kernel/20221111234323.16182-1-bwicaksono@=
nvidia.com/

Regards,
Besar

> Will