Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3239258rwb; Sat, 12 Nov 2022 01:43:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf5/aq25dY8aoReg3WBDxGqrR/P7INSSzgYkNzkA9F+F/+FwPvHJ11nTBII2vFSx6lq7wuoX X-Received: by 2002:a17:906:36d9:b0:78d:7f22:2c53 with SMTP id b25-20020a17090636d900b0078d7f222c53mr4837555ejc.420.1668246201011; Sat, 12 Nov 2022 01:43:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668246201; cv=none; d=google.com; s=arc-20160816; b=QTxnFTF5rmtlhLx3nru3/PWYfwmCc3c130rZlJ2wm4ymbBI+woBi896gWg4xYvx/Rk 8UMk4ctOYdTFYvjxZJbG5EugPtWdR/C7ckjTNCdObrAm+nbVAKQdkTqZvjxmcX68cxrK GKeIFFUanhyOnx+hbyUJzur+jE1zOXXEDmN+Xb7A8siS3AHYdkFe0p1G7IGm2xt1sw8Q ELKfAqx+Mbekd6zD2trRx3fE2QnDRVldXkH/bTLrJGLbzM1b2LGZZMq+bPnSiRsxFQLd yRuYAUSZXRIV6bTAZ/3mmRS7IPT3SehiAiCJrZDzktNQvtNCfw+mESmnHOpdBSVU4Pwi Xj8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=bgei0G7J0hn1J9ahNNtVbNjaoXg+1srShnpAYNrbfbg=; b=Wuf6s2Tw8o2BbEMthYjILFppEmXj6mcnbvWOUEec7s9d33HVodFQl32Lgk1pc3KNnG /UOuG03qIoe9xhUcUcJFe2yNPk1b5hYZf8YyGCTRZMksui6pZXV+/B6fy9FpXOP2otHH MHLu2F6wmrzqMoZEg6cYdwmaYUdSZFxxcsMMzeI0SZ2886hiy2l6M6gNShO27AFoywoK cCkJkAzrBnLXl4y0CLewlOexKw6aZwqRHS9SKFTwsw3GwwPWyuPq0z6wZZ/lLEA3rCJI ZU8p9fumkWqm+wyB82niwXh5GdwS2q46H1iOsdw1NVRNfhwTtFJazVQ7ZMvyHPOLFeKV Ogwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hc14-20020a170907168e00b0078c9dd279b6si4421702ejc.345.2022.11.12.01.42.59; Sat, 12 Nov 2022 01:43:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234627AbiKLJbF (ORCPT + 90 others); Sat, 12 Nov 2022 04:31:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233223AbiKLJbD (ORCPT ); Sat, 12 Nov 2022 04:31:03 -0500 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7482114099 for ; Sat, 12 Nov 2022 01:31:02 -0800 (PST) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4N8Vg83Zq1z15MY2; Sat, 12 Nov 2022 17:30:44 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 12 Nov 2022 17:31:00 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 12 Nov 2022 17:31:00 +0800 From: Yang Yingliang To: CC: Subject: [PATCH 1/2] pcmcia: ds: fix refcount leak in pcmcia_device_add() Date: Sat, 12 Nov 2022 17:29:23 +0800 Message-ID: <20221112092924.3608240-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If device_register() returns error, the refcount of function_config need be put. Fixes: 360b65b95bae ("[PATCH] pcmcia: make config_t independent, add reference counting") Signed-off-by: Yang Yingliang --- drivers/pcmcia/ds.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c index ace133b9f7d4..7d3258a1f8f8 100644 --- a/drivers/pcmcia/ds.c +++ b/drivers/pcmcia/ds.c @@ -574,10 +574,12 @@ static struct pcmcia_device *pcmcia_device_add(struct pcmcia_socket *s, pcmcia_device_query(p_dev); if (device_register(&p_dev->dev)) - goto err_unreg; + goto err_put_ref; return p_dev; + err_put_ref: + kref_put(&p_dev->function_config->ref, pcmcia_release_function); err_unreg: mutex_lock(&s->ops_mutex); list_del(&p_dev->socket_device_list); -- 2.25.1