Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 12 Nov 2022 15:10:21 +0100
Message-ID: <87y1sg1cxe.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Mark Brown <broonie@kernel.org>
Cc:     syzbot <syzbot+9abda841d636d86c41da@syzkaller.appspotmail.com>,
        alsa-devel-owner@alsa-project.org, alsa-devel@alsa-project.org,
        clemens@ladisch.de, gregkh@linuxfoundation.org,
        lgirdwood@gmail.com, linux-kernel@vger.kernel.org, peda@axentia.se,
        perex@perex.cz, rafael@kernel.org, syzkaller-bugs@googlegroups.com,
        tiwai@suse.com
Subject: Re: [syzbot] WARNING in snd_usbmidi_output_open
In-Reply-To: <Y2+hCnVYWHuROAEF@sirena.org.uk>
References: <000000000000734a7305ed3608ba@google.com>
        <00000000000073937205ed45fe5c@google.com>
        <Y2+hCnVYWHuROAEF@sirena.org.uk>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sat, 12 Nov 2022 14:35:06 +0100,
Mark Brown wrote:
> 
> On Sat, Nov 12, 2022 at 05:29:21AM -0800, syzbot wrote:
> > syzbot has bisected this issue to:
> > 
> > commit 4f8ed19593872b710f27bbc3b7a9ce03310efc57
> > Author: Mark Brown <broonie@kernel.org>
> > Date:   Thu Jun 2 13:10:58 2022 +0000
> > 
> >     ASoC: tfa9879: Use modern ASoC DAI format terminology
> 
> This bisection really doesn't seem credible for an issue in a different
> driver...  The tfa9879 is neither a USB nor MIDI device, and the commit
> in question is a stylistic update.

Yes, the bisection result is bogus.

And, the problem here is just a kernel WARNING produced by
snd_BUG_ON() macro usage, and the check itself is valid.
We just need to drop snd_BUG_ON() wrapping.

Will submit the fix later.


thanks,

Takashi