Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 12 Nov 2022 15:40:40 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Cosmin Tanislav <demonsingur@gmail.com>
Cc:     Cosmin Tanislav <cosmin.tanislav@analog.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        William Breathitt Gray <william.gray@linaro.org>,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: addac: add AD74115
Message-ID: <20221112154040.54dc5cf2@jic23-huawei>
In-Reply-To: <c01b0e56563b2b6f8ef48ad90977646706a2c933.camel@gmail.com>
References: <20221103094436.2136698-1-demonsingur@gmail.com>
        <20221103094436.2136698-2-demonsingur@gmail.com>
        <20221106154634.2286faf3@jic23-huawei>
        <c01b0e56563b2b6f8ef48ad90977646706a2c933.camel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk


> >   
> > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > > +    description: |
> > > +      Conversion range for ADC conversion 2.
> > > +      0 - 0V to 12V
> > > +      1 - -12V to +12V
> > > +      2 - -2.5V to +2.5V
> > > +      3 - -2.5V to 0V
> > > +      4 - 0V to 2.5V
> > > +      5 - 0V to 0.625V
> > > +      6 - -104mV to +104mV
> > > +      7 - 0V to 12V  
> > 
> > For a lot of similar cases we handle these numerically to give
> > a human readable dts.  Is there a strong reason not to do so here (in mv)
> >   
> 
> I used this approach mostly because it maps dirrectly to register values
> and because it's easier to parse. dts isn't exactly nice at handling
> negative values. I can switch it to mv array if you insist.

We have quite a few existing cases of
adi,[output-]range-microvolt so it would be good to copy that style here.

> 
> >   
> > > +    minimum: 0
> > > +    maximum: 7
> > > +    default: 0
> > > +