Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <386734b3660eb3298cfbd5245f18994777a3296c.camel@linux.intel.com>
Subject: Re: [PATCH] HID: hid-sensor-custom: Allow more than one hinge angle
 sensor
From:   srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To:     Yauhen Kharuzhy <jekhor@gmail.com>, linux-input@vger.kernel.org,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Jiri Kosina <jikos@kernel.org>
Date:   Sat, 12 Nov 2022 08:09:42 -0800
In-Reply-To: <20221105223422.417316-1-jekhor@gmail.com>
References: <20221105223422.417316-1-jekhor@gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sun, 2022-11-06 at 00:34 +0200, Yauhen Kharuzhy wrote:
> Some devices has two sets of accelerometers and the sensor hub
> exports
> two hinge angle 'sensors' based on accelerometer values. To allow
> more
> than one sensor of the same type, use PLATFORM_DEVID_AUTO instead of
> PLATFORM_DEVID_NONE when registering platform device for it.
> 
> Checked on the Lenovo Yoga Book YB1-X91L tablet.
> 
> Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

> ---
>  drivers/hid/hid-sensor-custom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-
> sensor-custom.c
> index 32c2306e240d6..a6fc89ee1287c 100644
> --- a/drivers/hid/hid-sensor-custom.c
> +++ b/drivers/hid/hid-sensor-custom.c
> @@ -862,7 +862,7 @@ hid_sensor_register_platform_device(struct
> platform_device *pdev,
>                 return ERR_PTR(-ENOMEM);
>  
>         custom_pdev = platform_device_register_data(pdev->dev.parent,
> dev_name,
> -                                                  
> PLATFORM_DEVID_NONE, hsdev,
> +                                                  
> PLATFORM_DEVID_AUTO, hsdev,
>                                                     sizeof(*hsdev));
>         kfree(dev_name);
>         return custom_pdev;