Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 12 Nov 2022 17:49:55 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Jagath Jog J <jagathjog1996@gmail.com>
Cc:     Dong Chenchen <dongchenchen2@huawei.com>, dan@dlrobertson.com,
        lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, yuehaibing@huawei.com
Subject: Re: [Patch] iio: accel: bma400: Fix memory leak in
 bma400_get_steps_reg()
Message-ID: <20221112174955.2d1d294a@jic23-huawei>
In-Reply-To: <CAM+2EuLVr3ncC3FomFMxQnBzdVnEU+gcjJ9Q9cKwz6W8OX5H=w@mail.gmail.com>
References: <20221110010726.235601-1-dongchenchen2@huawei.com>
        <CAM+2EuLVr3ncC3FomFMxQnBzdVnEU+gcjJ9Q9cKwz6W8OX5H=w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 11 Nov 2022 23:12:32 +0530
Jagath Jog J <jagathjog1996@gmail.com> wrote:

> On Thu, Nov 10, 2022 at 6:37 AM Dong Chenchen <dongchenchen2@huawei.com> wrote:
> >
> > When regmap_bulk_read() fails, it does not free steps_raw,
> > which will cause a memory leak issue, this patch fixes it.
> >
> > Fixes: d221de60eee3 ("iio: accel: bma400: Add separate channel for step counter")
> > Signed-off-by: Dong Chenchen <dongchenchen2@huawei.com>  
> 
> Reviewed-by: Jagath Jog J <jagathjog1996@gmail.com>
> 
> Thanks for catching this

Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan

> 
> Regards,
> Jagath
> 
> > ---
> >  drivers/iio/accel/bma400_core.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/accel/bma400_core.c b/drivers/iio/accel/bma400_core.c
> > index ad8fce3e08cd..43976cf5a91b 100644
> > --- a/drivers/iio/accel/bma400_core.c
> > +++ b/drivers/iio/accel/bma400_core.c
> > @@ -805,8 +805,10 @@ static int bma400_get_steps_reg(struct bma400_data *data, int *val)
> >
> >         ret = regmap_bulk_read(data->regmap, BMA400_STEP_CNT0_REG,
> >                                steps_raw, BMA400_STEP_RAW_LEN);
> > -       if (ret)
> > +       if (ret) {
> > +               kfree(steps_raw);
> >                 return ret;
> > +       }
> >         *val = get_unaligned_le24(steps_raw);
> >         kfree(steps_raw);
> >         return IIO_VAL_INT;
> > --
> > 2.25.1
> >