Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b9ef96f3-724e-1696-3f22-d5e89cbd927d@paragon-software.com>
Date:   Sat, 12 Nov 2022 21:11:10 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH -next v2 2/2] fs/ntfs3: Eliminate unnecessary ternary
 operator in ntfs_d_compare()
Content-Language: en-US
To:     Nathan Chancellor <nathan@kernel.org>
CC:     Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, <ntfs3@lists.linux.dev>,
        <llvm@lists.linux.dev>, <patches@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>
References: <20221004232359.285685-1-nathan@kernel.org>
 <20221004232359.285685-2-nathan@kernel.org>
From:   Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
In-Reply-To: <20221004232359.285685-2-nathan@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/5/22 02:23, Nathan Chancellor wrote:
> 'a == b ? 0 : 1' is logically equivalent to 'a != b'.
> 
> Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> 
> v2: New patch.
> 
>   fs/ntfs3/namei.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ntfs3/namei.c b/fs/ntfs3/namei.c
> index 5d3a6ce3f05f..6b0d2c01d6ff 100644
> --- a/fs/ntfs3/namei.c
> +++ b/fs/ntfs3/namei.c
> @@ -432,7 +432,7 @@ static int ntfs_d_compare(const struct dentry *dentry, unsigned int len1,
>   	/* First try fast implementation. */
>   	for (;;) {
>   		if (!lm--)
> -			return len1 == len2 ? 0 : 1;
> +			return len1 != len2;
>   
>   		if ((c1 = *n1++) == (c2 = *n2++))
>   			continue;

Thank you for your work, applied!
First patch was already applied.