Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3748296rwb; Sat, 12 Nov 2022 11:59:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf78Gl/zVhdJO0wT6D3HFx35YNxdGv0v0zkbUImQXiUTjdHfok4XdvTB+EK7NgnEhPO2EQAp X-Received: by 2002:a05:6a00:1d05:b0:56c:4303:a93d with SMTP id a5-20020a056a001d0500b0056c4303a93dmr7828004pfx.73.1668283195545; Sat, 12 Nov 2022 11:59:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668283195; cv=none; d=google.com; s=arc-20160816; b=CtuIBPNRMzLG4vwbUWgfwKZQucoVBlePa7xiFEyEu+30yBNqjTiAD8GUm2WMpFpCeH QO4wKFiBXFtvaWXfWzDYJ0Atz0jH8QYaMhTuyClNBcrHqWlp7c2oKTiy0SsYbb/kqqIZ IkW3B14o6ROztgODFM27uJLJtz9zhQ79r2rkJuUpFGBLDqzBVsw6wZkzVe7kg4Onwy/W Og9VNtgau/ZNaWn4mDj7iu/sa+1C1HmcPiigzWus9wG1QLBXz6YUZgS39G+LbEZmWTig kA5LeRzW5uS9CO4yD0BAXbdhj+Y9RSVO2Zxy/QDyIJzvWeev0auVhTgfzbbg+iMhENNu l76A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=tpzQEeIzmJRMT71EzOyuzjEYJH59V57qil9eRYR5was=; b=WsmZ7EHk7QxrOigXhHK1wftEBjm3Ds4nErcl9P5r/mYzZKRBEknKCTshnc8QXT+Mq+ CohEz7HZTXjjK0f76F+pOiUvSzpQDzgI7k+oF7XqQ8yNyM5R1n0UMrKni/sGCRcMUG9J 9IMUgdopAajJ+puI29h/zhWMG/VDiDNfosi6kWn/95bNhdIq1xXn6d+xVVdGJjMOTNRB 0EbuxlYqzrUFdldkCw1E84N+wvDIDrsE4n0Uu1p22pddEvxN/3Gdtig272N3t6f5ZLry YmTVjDYd6ZYnsbxxcI0Jm1SBfQnD2zc/r412+2Q1nuLRvMh4sDBXkD9i18Npb8Gn0fKR +qZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=gpJ1Qdls; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c6-20020a170902724600b00186ab026646si5338589pll.394.2022.11.12.11.59.40; Sat, 12 Nov 2022 11:59:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=gpJ1Qdls; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235092AbiKLT2Y (ORCPT + 90 others); Sat, 12 Nov 2022 14:28:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231252AbiKLT2X (ORCPT ); Sat, 12 Nov 2022 14:28:23 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C380A5FD9; Sat, 12 Nov 2022 11:28:21 -0800 (PST) Received: from zn.tnic (p200300ea9733e71c329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e71c:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 151301EC054C; Sat, 12 Nov 2022 20:28:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1668281300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tpzQEeIzmJRMT71EzOyuzjEYJH59V57qil9eRYR5was=; b=gpJ1QdlsFW7DzD9zpQqhGQMdTgtqK1zVwI61F9UNacHLRApDLrjNJdzq3bhI3gP6+SMTDC nSUY3guIJ6IAINhmmZL0EhQnQ2YhIri1xq1OOdCQIbfbTqczHZZ5QqEmYDKUV8f+PPkt56 cxTM1MTW8zFS52smAuSy7QLnxN7ktEg= Date: Sat, 12 Nov 2022 20:28:19 +0100 From: Borislav Petkov To: "Luck, Tony" Cc: "Joseph, Jithu" , "hdegoede@redhat.com" , "markgross@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "gregkh@linuxfoundation.org" , "Raj, Ashok" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "patches@lists.linux.dev" , "Shankar, Ravi V" , "Macieira, Thiago" , "Jimenez Gonzalez, Athenas" , "Mehta, Sohil" Subject: Re: [PATCH v2 12/14] platform/x86/intel/ifs: Add current_batch sysfs entry Message-ID: References: <20221021203413.1220137-1-jithu.joseph@intel.com> <20221107225323.2733518-1-jithu.joseph@intel.com> <20221107225323.2733518-13-jithu.joseph@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 12, 2022 at 06:33:58PM +0000, Luck, Tony wrote: > We tried the full file name in an earlier version. GregKH was > unimpressed. But that was when we were trying to overload the meaning > of the “reload” file. I'm guessing the background of his lack of "impressiveness" was something along the lines of: "Attributes should be ASCII text files, preferably with only one value per file. It is noted that it may not be efficient to contain only one value per file, so it is socially acceptable to express an array of values of the same type." Question is, is a filename string one value per file or strings don't count? Suspend allows it: # echo "shutdown" > /sys/power/disk # echo "disk" > /sys/power/state Btw, do you guys really want to run this in production? As in, are you really that confident that all those test sequence executions really do not affect other CPU execution at all? Because if this is going to be run during downtime, as Thiago says, then you can just as well use debugfs for this. And then there's no need to cast any API in stone and so on. Hmmm. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette