Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Winkler, Tomas" <tomas.winkler@intel.com>
To:     Michael Kelley <mikelley@microsoft.com>,
        "peterhuewe@gmx.de" <peterhuewe@gmx.de>,
        "jarkko@kernel.org" <jarkko@kernel.org>,
        "jgg@ziepe.ca" <jgg@ziepe.ca>,
        "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/1] tpm/tpm_crb: Fix error message in
 __crb_relinquish_locality()
Thread-Topic: [PATCH 1/1] tpm/tpm_crb: Fix error message in
 __crb_relinquish_locality()
Thread-Index: AQHY9gVLP43QalYY0UyVn396YXCToq47ruMg
Date:   Sat, 12 Nov 2022 19:32:46 +0000
Message-ID: <MN2PR11MB409396A8C5CA6D4DFDF52B9AE5039@MN2PR11MB4093.namprd11.prod.outlook.com>
References: <1668195533-16761-1-git-send-email-mikelley@microsoft.com>
In-Reply-To: <1668195533-16761-1-git-send-email-mikelley@microsoft.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tXyOh9cN63eI0T0+bjYqcUMnFoGFqFh5BJmY22cgXcH/ZIZuG9y2F1rTcR+u?=
 =?us-ascii?Q?9U7Y+i2BLzOiWzAiYMdAC1TU3OM5x/ilCMzJfTUOT3vEC+L31m7KaIs5z5z8?=
 =?us-ascii?Q?yYvd9PgcuK1LU3gLkQAx6zJwcsKCrrHm7+lZuWlDiAXxzpurcHiZ2sB+GBZk?=
 =?us-ascii?Q?ZBBuKBWkUJJv36XNYsNcJ/2LB4C/P9HWHoKuzr7Ot06MWCQpB9hMIe45M1FX?=
 =?us-ascii?Q?lHdsHa+8CDxOX7bk7LQt50QyrRXKJLuK8tifvOcqcuwhnXqIHfioNSuohWOY?=
 =?us-ascii?Q?ktORPC/E10d9U4gZosvfI/4ryze66oGoM4CTC74WjGKVyjkuyT/j7JU1gbJ9?=
 =?us-ascii?Q?hxsxHjhDtjSnArRHsj5YLuPVgoc3ccihxXkX0yhNZShljuUUyUudhQuID+1k?=
 =?us-ascii?Q?VcwHBQHWeCgwJfbOguB68TvKkwqlh9jyD/g96EI9+eI4Er9MPY9BH1l0KDuj?=
 =?us-ascii?Q?HG9TDJQqaELqS6kPxAz4KsX8wJI1Q1PETqebZtmuZJ6YF+m0CRQM+0iL1g55?=
 =?us-ascii?Q?fty737DZq8KexVAO5OCrH/pppk5vTQbsB3eQKPJNih8fRuml8GI8M+o507IQ?=
 =?us-ascii?Q?KLoistsFMppgGoqrjaIWFG0dlYECaTOEA1Cpz6SQ50PrPh5RaJ05MXZt/5xZ?=
 =?us-ascii?Q?0+MBDT5K3KAM+4NIGlD3GbFydAxlxlOcEX8xAs/c1cr+r6WCRuV0R8IpO//I?=
 =?us-ascii?Q?mX56MOWy5TGbiljl1Dh/l9XNEXDDNyEvUckZRIIrzRvmzeo+bdBUj0aIgxdo?=
 =?us-ascii?Q?OYjDMxgdwHfAvStBFvzzi+qr34UR9bNR6K0exrSZAnDIGrK1ykZLBB4ueNFp?=
 =?us-ascii?Q?yQGaN1vlvNPZS5uhbqs5d4KBS2jsAkogsv6F0wUuLx1UMXQnHUQmuH9oXjgw?=
 =?us-ascii?Q?DMTzKkpPdgR1voSEcRSSPWi+AM8djyBXXnurDFuN9DdRsrf0Xb+7kUakxH87?=
 =?us-ascii?Q?BrMX5c/QS3PJffzkenwXMj2rmUrnsS2XPt6/hM2z3U5EA75BCz1a0oQQvR5b?=
 =?us-ascii?Q?ET2/9qBpXHwwLCcHDz5g1T4dzcwppIuA7MPxeGcl+Uf/agxo70W2gBPrQ9lJ?=
 =?us-ascii?Q?6FXSVboUZ6zkqq51oiKwPKgHei0Xo1FF+GF3HZlNaBUXapUu4scAlLCK9Wtl?=
 =?us-ascii?Q?At+4W4yX6UA218HZ0rXcis9GAYt/OMQgDdDDO3Y++Sx3tx53oDOYJkgc9RtW?=
 =?us-ascii?Q?OSZ6dXtiwNPvu1/ko9xyRXJxaS4uvPQpWmuiGt3KXH0Q7YZmT2uRt9nZlrfe?=
 =?us-ascii?Q?UUzv9wgmTLJfb2Zr+ddcXTEImEwd5VwvNx1lyQ/e7SKaG+iEabGY0fI2fT8D?=
 =?us-ascii?Q?EtFKlVs6eNtt1URuhbY8haQfalIn6s9XZ9s8ZvZ+WCOzv4c3X8GCGZC3Qj23?=
 =?us-ascii?Q?7YJyJyVn+MbLrNktjdkzf2Z7FJHVfC9Z3OxKgU5EJkT6TPDgCepvliMIt1Tz?=
 =?us-ascii?Q?Nv8y7DwZZzbohVTvnHvubkEGa7iXVAKXYeiJsEzAK6qXYXTtcKsdMLqXsu0V?=
 =?us-ascii?Q?LUVCkr8iXVunN0JeZjqRaH/o6/zVJ5a1gmCIANk66QbXqie9wwBoOf7BJqcM?=
 =?us-ascii?Q?UfHnbTfbklZzN1e6QUVPbTv+zbKXaL3wso4HeWro?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4093.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47a696b5-274f-415b-4031-08dac4e4ad14
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2022 19:32:46.1563
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RnO31Ru3SxxhiDy9nL5QLEQH/zccLxpOGa4yc7s+l7HBfXG+UKDdn2/x81+5DfV/um7hjfpYczVCzLjj5i1IWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4545
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Michael Kelley <mikelley@microsoft.com>
> Sent: Friday, November 11, 2022 21:39
> To: peterhuewe@gmx.de; jarkko@kernel.org; jgg@ziepe.ca; Winkler, Tomas
> <tomas.winkler@intel.com>; linux-integrity@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: mikelley@microsoft.com
> Subject: [PATCH 1/1] tpm/tpm_crb: Fix error message in
> __crb_relinquish_locality()
>=20
> The error message in __crb_relinquish_locality() mentions requestAccess
> instead of Relinquish. Fix it.
>=20
> Fixes: 888d867df441 ("tpm: cmd_ready command can be issued only after
> granting locality")
> Signed-off-by: Michael Kelley <mikelley@microsoft.com>
Acked-by: Tomas Winkler <tomas.winkler@intel.com>=20

> ---
>  drivers/char/tpm/tpm_crb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c inde=
x
> 1860665..65f8f17 100644
> --- a/drivers/char/tpm/tpm_crb.c
> +++ b/drivers/char/tpm/tpm_crb.c
> @@ -252,7 +252,7 @@ static int __crb_relinquish_locality(struct device *d=
ev,
>  	iowrite32(CRB_LOC_CTRL_RELINQUISH, &priv->regs_h->loc_ctrl);
>  	if (!crb_wait_for_reg_32(&priv->regs_h->loc_state, mask, value,
>  				 TPM2_TIMEOUT_C)) {
> -		dev_warn(dev, "TPM_LOC_STATE_x.requestAccess timed
> out\n");
> +		dev_warn(dev, "TPM_LOC_STATE_x.Relinquish timed
> out\n");
>  		return -ETIME;
>  	}
>=20
> --
> 1.8.3.1