Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1df133ef-d5e9-f323-7c67-fc9ffed04274@infradead.org>
Date:   Sat, 12 Nov 2022 16:34:18 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: include: linux: slab: kmalloc_trace undefined when compiling
 drivers
To:     Ian Cowan <ian@linux.cowan.aero>
Cc:     cl@linux.com, penberg@kernel.org, rientjes@google.com,
        iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev,
        42.hyeyoo@gmail.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <Y2/Luovqgz8O+Kqa@rhino>
 <f83aca33-3a5f-97ac-625e-aa7c72bf60ba@infradead.org> <Y3AXVRAoZA5YEho+@rhino>
Content-Language: en-US
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <Y3AXVRAoZA5YEho+@rhino>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/12/22 13:59, Ian Cowan wrote:
> On Sat, Nov 12, 2022 at 09:21:34AM -0800, Randy Dunlap wrote:
>> Hi--
>>
>> On 11/12/22 08:37, Ian Cowan wrote:
>>> When compiling drivers (speficially drivers/pci/hotplug), I am receiving
>>> the following modpost error for both `kmalloc_trace` and
>>> `kmalloc_node_trace` on the staging/staging-next branch:
>>>

Ian, what do you mean by "on the staging/staging-next branch"?

What kernel version are you trying to build?

The .config that you sent is for v6.1.0-rc1.

>>> ERROR: modpost: "kmalloc_trace" [drivers/pci/hotplug/acpiphp_ibm.ko] undefined!
>>>
>>> This only occurs when I have 'CONFIG_TRACING=y' in my config, and I
>>> have traced it down to the slab header where the kmalloc_trace is
>>> defined. It appears that when CONFIG_TRACING is set, the kmalloc_trace
>>> and kmalloc_node_trace do not get defined by the compiler. I do not have
>>> enough context in this area of the code base to propose a fix or to even
>>> know if maybe it's a local compiling issue for myself. It looks like
>>> there are a few recent commits from August that did some refactoring in this header,
>>> and when compiling prior to that refactoring I am able to compile the
>>> specified drivers without error.
>>>
>>> I will mention that I am using Red Hat gcc version 12.2.1 and make version
>>> 4.3 and am on Fedora.
>> Please post a full failing kernel .config file for this.
>> Thanks.
>>
>> -- 
>> ~Randy
>>
> Below is my .config file. This is pretty much a default Fedora .config
> (copied from my system) with possibly a few additions to make sure the
> modules I needed to compile did compile. I was compiling using the
> command: `make M=drivers/pci/hotplug`.

Sorry, I cannot reproduce the problem.
Hopefully someone else has some ideas.

-- 
~Randy