Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp4216619rwb; Sun, 13 Nov 2022 01:07:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf6gKqGB85QeVoymT3rov5rLMmomeh/P9fW9fsXtTceeI1q0t/5awTkMLymxwfUU6khlCo8L X-Received: by 2002:a63:4e16:0:b0:41e:2cc8:447e with SMTP id c22-20020a634e16000000b0041e2cc8447emr8104086pgb.299.1668330443313; Sun, 13 Nov 2022 01:07:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668330443; cv=none; d=google.com; s=arc-20160816; b=XdEp9/6Cu/CcH1P5+QLafpYkkI/75HQ9Zyw88zWtetPk/t5Y8njjZ1MOuSV1rOb6NA G6v1dNZdZuLLJ0PosBJyW5E9xgawFNvX4QtsHvV3GJesMTHU6N3/y4xa4ve72C7en9+J FFKAhX7VgfXSkwYkWJhTP4jfSUdEoXHO3ZdDgWCo7+e+boQOhS1lvo0rILNjB0+KHhTv E8cGk3LxfGezJ9rH/F3v0ItStOE+wVtIeFHzwXElJGMi953znMH+hlMADl5mdRPwR6Jm wK0133Yh+HAWMFOMBjsZbo7d0FffbQqF8U33nm42ay/6qYJcYaXT3UPmA/+sv5JWjtpB sDdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=a9182V/IG+/5twUq9taGkM0Bi8a7sVT66vYIuy9XqOg=; b=d4dUHIDz/QvsBQXSE19KyeFRNQ2ZkK2Rf8Qnt0xvg5UXoxy3vMYif3/PGcq5yeHFBf WhO1b0a82jseZ7zxwe/3jGdl9oRUzIg1Bn8xVNyN1nLnht24ChE50dsnrOCGCo/p3fOO DADIpOSm21dyslg2dq5SffLxf1WUvRv+OlLOXk5zMzQMaEdmokd5nuH70oVJeiLHZFjP zEUkyq3LU085Iz8Y8IOJlQctBRDq2Ok5RQ/wtHKynJA+XIr1Z+38qY97J3+m+XeP/gM8 T5NOSNBA6yk95Ad7Mr4I1H2OEfVDObv2EKdzuYoVB30O+sSaqCjHmTTBF85XtTH91Ds/ ZkzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hth5qIr6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mq10-20020a17090b380a00b00200b5c30f73si8430262pjb.106.2022.11.13.01.07.07; Sun, 13 Nov 2022 01:07:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hth5qIr6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235171AbiKMHhk (ORCPT + 89 others); Sun, 13 Nov 2022 02:37:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbiKMHhj (ORCPT ); Sun, 13 Nov 2022 02:37:39 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D5A613DC5; Sat, 12 Nov 2022 23:37:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5439CB80B28; Sun, 13 Nov 2022 07:37:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3613BC433D6; Sun, 13 Nov 2022 07:37:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1668325054; bh=K5f5WERRWkb6eqwCLLHTvYjdz0b2Y79tLB/FkGJ2uno=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hth5qIr6K/BXeGN+nzXp2dlIgHD/8Y+bVXeBqE7WvHKkC232mjN6XRBTxXk0dMgCb LWw7sCYrzy/vWO/vEKzVlfAUUN5YQKTnTbCiCrdEJVgoMQtVJcDcorSPy347BcAqYS Etib0blRgZ74dFduuHbC7by8fPcRhkfooIq0LAgE= Date: Sun, 13 Nov 2022 08:37:32 +0100 From: "gregkh@linuxfoundation.org" To: "Luck, Tony" Cc: Borislav Petkov , "Joseph, Jithu" , "hdegoede@redhat.com" , "markgross@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "Raj, Ashok" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "patches@lists.linux.dev" , "Shankar, Ravi V" , "Macieira, Thiago" , "Jimenez Gonzalez, Athenas" , "Mehta, Sohil" Subject: Re: [PATCH v2 12/14] platform/x86/intel/ifs: Add current_batch sysfs entry Message-ID: References: <20221021203413.1220137-1-jithu.joseph@intel.com> <20221107225323.2733518-1-jithu.joseph@intel.com> <20221107225323.2733518-13-jithu.joseph@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 12, 2022 at 06:33:58PM +0000, Luck, Tony wrote: > > > Dunno - sounds silly to me. Means one needs to go and look up which > > files are there and echo those batch numbers into sysfs and so on. > > > > What I would do is make it real trivial for the user so that latter can > > simply do: > > > > for f in $(ls /lib/firmware/intel/ifs_0/*.scan); > > do > > echo $f > /sys/devices/virtual/misc/intel_ifs_0/test_file > > done > > > > and simply supply the full filename. > > We tried the full file name in an earlier version. GregKH was unimpressed. But that was when we were trying to overload the meaning of the “reload” file. > > Is it different now? No, please do not force the driver to resolve a filename path in the kernel.