Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 13 Nov 2022 08:21:21 -0500
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        michael@walle.cc, robert.marko@sartura.hr
Cc:     linus.walleij@linaro.org, brgl@bgdev.pl,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        broonie@kernel.org
Subject: Re: [PATCH v2 1/4] gpio: regmap: Always set gpio_chip get_direction
Message-ID: <Y3DvUaA7YYAsypGv@fedora>
References: <cover.1668129763.git.william.gray@linaro.org>
 <1805d1ddb5bbce8e86164e66421ddde481cce4f9.1668129763.git.william.gray@linaro.org>
 <Y3DlsTAQMi6kKObJ@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="H1NUJboC79HDNr5p"
Content-Disposition: inline
In-Reply-To: <Y3DlsTAQMi6kKObJ@smile.fi.intel.com>
Precedence: bulk


--H1NUJboC79HDNr5p
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Nov 13, 2022 at 02:40:17PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 10, 2022 at 08:55:50PM -0500, William Breathitt Gray wrote:
> > If you only have reg_dat_base set, then it is input-only; if you only
> > have reg_set_base set, then it is output-only. Thus, we can always set
> > gpio_chip get_direction to gpio_regmap_get_direction and return
> > GPIO_LINE_DIRECTION_IN/GPIO_LINE_DIRECTION_OUT given the respective
> > register base addresses configuration.
>=20
> Seems legit to me. Have you checked if we have any gpio-regmap drivers th=
at
> have something like this in their configuration already? In such cases we=
 need
> to be sure they behave as expected.
>=20
> From the code perspective:
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I see gpio-sl28cpld has two device types SL28CPLD_GPO (output-only) and
SL28CPLD_GPI (input-only); gpio-tn48m similarly has two device types
TN48M_GPO (output-only) and TN48M_GPI (input-only). It doesn't look like
the change in this patch will cause problems for them, but I'll let
Michael Walle and Robert Marko comment if they see issues here.

William Breathitt Gray

> > Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
> > ---
> >  drivers/gpio/gpio-regmap.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/gpio/gpio-regmap.c b/drivers/gpio/gpio-regmap.c
> > index 6383136cbe59..f907c9c19fce 100644
> > --- a/drivers/gpio/gpio-regmap.c
> > +++ b/drivers/gpio/gpio-regmap.c
> > @@ -111,6 +111,11 @@ static int gpio_regmap_get_direction(struct gpio_c=
hip *chip,
> >  	unsigned int base, val, reg, mask;
> >  	int invert, ret;
> > =20
> > +	if (gpio->reg_dat_base && !gpio->reg_set_base)
> > +		return GPIO_LINE_DIRECTION_IN;
> > +	if (gpio->reg_set_base && !gpio->reg_dat_base)
> > +		return GPIO_LINE_DIRECTION_OUT;
> > +
> >  	if (gpio->reg_dir_out_base) {
> >  		base =3D gpio_regmap_addr(gpio->reg_dir_out_base);
> >  		invert =3D 0;
> > @@ -265,8 +270,8 @@ struct gpio_regmap *gpio_regmap_register(const stru=
ct gpio_regmap_config *config
> >  	else if (gpio->reg_set_base)
> >  		chip->set =3D gpio_regmap_set;
> > =20
> > +	chip->get_direction =3D gpio_regmap_get_direction;
> >  	if (gpio->reg_dir_in_base || gpio->reg_dir_out_base) {
> > -		chip->get_direction =3D gpio_regmap_get_direction;
> >  		chip->direction_input =3D gpio_regmap_direction_input;
> >  		chip->direction_output =3D gpio_regmap_direction_output;
> >  	}
> > --=20
> > 2.38.1
> >=20
>=20
> --=20
> With Best Regards,
> Andy Shevchenko
>=20
>=20

--H1NUJboC79HDNr5p
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCY3DvUQAKCRC1SFbKvhIj
K78gAP9AJ0CWHYsCwOO5NsGRTrWtZ6ivLgeigZrj4RLRuvBkSwEAo+yJF2CJ5Sxr
Uo/oeieaP1mPRjx/HA7+RGOnAiFC9AI=
=d440
-----END PGP SIGNATURE-----

--H1NUJboC79HDNr5p--