Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761595AbXHHLJx (ORCPT ); Wed, 8 Aug 2007 07:09:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751782AbXHHLJk (ORCPT ); Wed, 8 Aug 2007 07:09:40 -0400 Received: from wa-out-1112.google.com ([209.85.146.180]:50380 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758633AbXHHLJh (ORCPT ); Wed, 8 Aug 2007 07:09:37 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Qmo/VaybSAhp9tEfgSO6b0Sce0YhYBb1ue6XltBF2H9h3tLAXQlXR6o52tjhbc95sHtd/H3Muld7rS3lOauQdw0ZvGLYCdNUX1LzeBIr4zL2FBFMtWw0BffemMj6o9OjGnto0yarJhQkhBz3Cw42vk9aYcwcQzF3Vc6dSroUIqE= Message-ID: <4bacf17f0708080409t116b5c84ye60dff7da51d0fdf@mail.gmail.com> Date: Wed, 8 Aug 2007 13:09:36 +0200 From: "=?ISO-8859-2?Q?Marcin_=A6lusarz?=" To: "Jarek Poplawski" Subject: Re: 2.6.20->2.6.21 - networking dies after random time Cc: "Ingo Molnar" , "Thomas Gleixner" , "Linus Torvalds" , "Jean-Baptiste Vignaud" , linux-kernel , shemminger , linux-net , netdev , "Andrew Morton" , "Alan Cox" In-Reply-To: <20070807121339.GA3946@ff.dom.local> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070726085523.GA3423@ff.dom.local> <4bacf17f0707300029g5116e70bq4808059dc8b069f1@mail.gmail.com> <20070731132037.GC1046@ff.dom.local> <4bacf17f0708060000n5a00bb77i74adc3b4b28ac42b@mail.gmail.com> <20070806070300.GA4509@elte.hu> <4bacf17f0708070046o14403089v8376a4544f72fec3@mail.gmail.com> <20070807082321.GB2120@ff.dom.local> <4bacf17f0708070237w19d184b3p7f74b53612edb9a6@mail.gmail.com> <20070807095246.GB3223@ff.dom.local> <20070807121339.GA3946@ff.dom.local> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4826 Lines: 126 2007/8/7, Jarek Poplawski : > So, the let's try this idea yet: modified Ingo's "x86: activate > HARDIRQS_SW_RESEND" patch. > (Don't forget about make oldconfig before make.) > For testing only. > > Cheers, > Jarek P. > > PS: alas there was not even time for "compile checking"... > > --- > > diff -Nurp 2.6.22.1-/arch/i386/Kconfig 2.6.22.1/arch/i386/Kconfig > --- 2.6.22.1-/arch/i386/Kconfig 2007-07-09 01:32:17.000000000 +0200 > +++ 2.6.22.1/arch/i386/Kconfig 2007-08-07 13:13:03.000000000 +0200 > @@ -1252,6 +1252,10 @@ config GENERIC_PENDING_IRQ > depends on GENERIC_HARDIRQS && SMP > default y > > +config HARDIRQS_SW_RESEND > + bool > + default y > + > config X86_SMP > bool > depends on SMP && !X86_VOYAGER > diff -Nurp 2.6.22.1-/arch/x86_64/Kconfig 2.6.22.1/arch/x86_64/Kconfig > --- 2.6.22.1-/arch/x86_64/Kconfig 2007-07-09 01:32:17.000000000 +0200 > +++ 2.6.22.1/arch/x86_64/Kconfig 2007-08-07 13:13:03.000000000 +0200 > @@ -690,6 +690,10 @@ config GENERIC_PENDING_IRQ > depends on GENERIC_HARDIRQS && SMP > default y > > +config HARDIRQS_SW_RESEND > + bool > + default y > + > menu "Power management options" > > source kernel/power/Kconfig > diff -Nurp 2.6.22.1-/kernel/irq/manage.c 2.6.22.1/kernel/irq/manage.c > --- 2.6.22.1-/kernel/irq/manage.c 2007-07-09 01:32:17.000000000 +0200 > +++ 2.6.22.1/kernel/irq/manage.c 2007-08-07 13:13:03.000000000 +0200 > @@ -169,6 +169,14 @@ void enable_irq(unsigned int irq) > desc->depth--; > } > spin_unlock_irqrestore(&desc->lock, flags); > +#ifdef CONFIG_HARDIRQS_SW_RESEND > + /* > + * Do a bh disable/enable pair to trigger any pending > + * irq resend logic: > + */ > + local_bh_disable(); > + local_bh_enable(); > +#endif > } > EXPORT_SYMBOL(enable_irq); > > diff -Nurp 2.6.22.1-/kernel/irq/resend.c 2.6.22.1/kernel/irq/resend.c > --- 2.6.22.1-/kernel/irq/resend.c 2007-07-09 01:32:17.000000000 +0200 > +++ 2.6.22.1/kernel/irq/resend.c 2007-08-07 13:57:54.000000000 +0200 > @@ -62,16 +62,24 @@ void check_irq_resend(struct irq_desc *d > */ > desc->chip->enable(irq); > > + /* > + * Temporary hack to figure out more about the problem, which > + * is causing the ancient network cards to die. > + */ > + > if ((status & (IRQ_PENDING | IRQ_REPLAY)) == IRQ_PENDING) { > desc->status = (status & ~IRQ_PENDING) | IRQ_REPLAY; > > - if (!desc->chip || !desc->chip->retrigger || > - !desc->chip->retrigger(irq)) { > + if (desc->handle_irq == handle_edge_irq) { > + if (desc->chip->retrigger) > + desc->chip->retrigger(irq); > + return; > + } > #ifdef CONFIG_HARDIRQS_SW_RESEND > - /* Set it pending and activate the softirq: */ > - set_bit(irq, irqs_resend); > - tasklet_schedule(&resend_tasklet); > + WARN_ON_ONCE(1); > + /* Set it pending and activate the softirq: */ > + set_bit(irq, irqs_resend); > + tasklet_schedule(&resend_tasklet); > #endif > - } > } > } > Works fine with: WARNING: at kernel/irq/resend.c:79 check_irq_resend() Call Trace: [] check_irq_resend+0xc0/0xd0 [] enable_irq+0xed/0xf0 [] :8390:ei_start_xmit+0x14d/0x30c [] lock_release_non_nested+0xe5/0x190 [] __qdisc_run+0x98/0x1f0 [] __qdisc_run+0xae/0x1f0 [] dev_hard_start_xmit+0x26e/0x2d0 [] __qdisc_run+0xc0/0x1f0 [] dev_queue_xmit+0x24f/0x310 [] neigh_resolve_output+0xe7/0x290 [] dst_output+0x0/0x10 [] ip_output+0x19f/0x340 [] ip_queue_xmit+0x217/0x430 [] tcp_transmit_skb+0x40a/0x7c0 [] __tcp_push_pending_frames+0x11b/0x940 [] tcp_sendmsg+0x87a/0xc80 [] inet_sendmsg+0x45/0x80 [] sock_aio_write+0x104/0x120 [] do_sync_write+0xf1/0x130 [] autoremove_wake_function+0x0/0x40 [] vfs_write+0x159/0x170 [] sys_write+0x50/0x90 [] system_call+0x7e/0x83 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/