Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 13 Nov 2022 09:13:34 -0500
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linus.walleij@linaro.org, brgl@bgdev.pl,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        michael@walle.cc, broonie@kernel.org
Subject: Re: [PATCH v2 4/4] gpio: i8255: Migrate to regmap API
Message-ID: <Y3D7jipyk5L655AE@fedora>
References: <cover.1668129763.git.william.gray@linaro.org>
 <61327a67cc308af413471a69a4810b2785e53e8e.1668129763.git.william.gray@linaro.org>
 <Y3Dol6rHduFNQT85@smile.fi.intel.com>
 <Y3D6Lji9bKeSbJaI@fedora>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="oTGlfTqifU6OR20N"
Content-Disposition: inline
In-Reply-To: <Y3D6Lji9bKeSbJaI@fedora>
Precedence: bulk


--oTGlfTqifU6OR20N
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Nov 13, 2022 at 09:07:42AM -0500, William Breathitt Gray wrote:
> On Sun, Nov 13, 2022 at 02:52:39PM +0200, Andy Shevchenko wrote:
> > On Thu, Nov 10, 2022 at 08:55:53PM -0500, William Breathitt Gray wrote:
> > >  drivers/gpio/Kconfig            |   2 +
> > >  drivers/gpio/gpio-104-dio-48e.c | 397 ++++++++++-------------------
> > >  drivers/gpio/gpio-gpio-mm.c     | 151 +++--------
> > >  drivers/gpio/gpio-i8255.c       | 429 +++++++++++-------------------=
--
> > >  drivers/gpio/gpio-i8255.h       |  80 +++---
> >=20
> > Can we actually split this to a few steps:
> >  - providing gpio-i8255-regmap
> >  - providing gpio-mm-regmap
> >  - converting the driver
> >  - removing not used modules (one by one)
> > ?
> >=20
> > In this case if any regression somewhere appears, we can always perform=
 a
> > (semi-)revert for a certain driver.
>=20
> Sure, I can split the regmap_irq migration for 104-dio-48e into a
> separate precursor patch to reduce the amount of changes we see here and
> provide a revert path for these IRQ changes. I can do a similar change
> for 104-idi-48 as well.
>=20
> The rest of the changes for 104-dio-48 and gpio-mm are essentially just
> the regmap configurations, so the patch will be largely identical even
> if we migrate gpio-i8255 to regmap API first before migrating again to
> the gpio_regmap in a second patch.

Sorry, I realize now that you meant to split the i8255 gpio_regmap
additions to their own patch, perform the driver migrations in the own
respective patches, and then finally remove the dangling unused i8255
functions and structures. Yes I think that would make for a cleaner
patch series so I'll split it up that way.

William Breathitt Gray

--oTGlfTqifU6OR20N
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCY3D7jgAKCRC1SFbKvhIj
K9xoAQChK9V3hkCewQu4U/YzHkR8KOf3J7N1Pl+9IK7YoX3TgwD+L7FDU83nXmWi
g3MvYstO9i7FwtgWranyHbVBbcbCSwU=
=bAac
-----END PGP SIGNATURE-----

--oTGlfTqifU6OR20N--