Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5e65889d-d68c-b29d-6cea-7b4ce4c87b4a@intel.com>
Date:   Sun, 13 Nov 2022 08:41:47 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2 12/14] platform/x86/intel/ifs: Add current_batch sysfs
 entry
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        Thiago Macieira <thiago.macieira@intel.com>
CC:     "Luck, Tony" <tony.luck@intel.com>,
        "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "markgross@kernel.org" <markgross@kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "Jimenez Gonzalez, Athenas" <athenas.jimenez.gonzalez@intel.com>,
        "Mehta, Sohil" <sohil.mehta@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-13-jithu.joseph@intel.com> <Y2/JNAmSoYlLKq3A@zn.tnic>
 <CC3629D6-B205-4150-80E5-FC7A7A76DD25@intel.com> <Y3CevK2zhAmiUyG9@kroah.com>
 <Y3DZmKYV+8HBtZ+Q@zn.tnic>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <Y3DZmKYV+8HBtZ+Q@zn.tnic>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVRHZzQ2S1pGOU5DOGtlcU0wZWEvcWY2T3JKSmkvK0JoMitqdFZEamZMV2hL?=
 =?utf-8?B?RE5SNElhdU0zeXUwdWpnNGQxci9QcGdNK1piU0ZmeXRoSjdmQkNCakgzSkVj?=
 =?utf-8?B?cW91YkxCTmI0MGRIbjJuZ1NNbkxjRTNBRzV2WHNSTzhLSVBoNm5KV3BycFhF?=
 =?utf-8?B?cVBrVzFGanNrb05QRElVVmlPbFhjblZ5U0RzQzNOMkRiTUNyZDN0N0p0ekNu?=
 =?utf-8?B?VEkyYkZWOVp4Rk9heVE3Z21aSWErYjM0dUpNdFEvYjhqMDd4MlBvdklsUmNN?=
 =?utf-8?B?VmpSbldXRWZDSUhidlEwejZ6WnQ0QkNBYk1UQk80RGdlQVA0M1NmZjFEMHVl?=
 =?utf-8?B?anUzU1JjZEdHSmFDSlZ1VmNFdE01b2p1VzJTYlFXcHQ0VUZIUzFNTGJEblBu?=
 =?utf-8?B?MVFFNGNrRjVPN3hLK0lKYk9rMFdZMlN5RlEyazhoWnVXUjlQTEFtRGJPSjZS?=
 =?utf-8?B?bUlzSHA3NDVNS0lndmU0ZzNPVU9tbkgxUllPUWxxa3k4ZVNHUERGRm1KQ2Q3?=
 =?utf-8?B?TjJRd1ovK1o3bmF5ckhNaHM1RXlKa0k0cU90WTZjVFVBalpZNW9RRVpWVk5i?=
 =?utf-8?B?MWw4R21hWTQzYUEwQ0R4dStOeFZ1d2R0bFdYMVhkTXR0cFhBN1FqYXN6LzBK?=
 =?utf-8?B?dUpQT205SDYyTWR3L1FDN2FrTGxublhYdDJyR1ZSeHZFOU5XWm9kSW13YjBi?=
 =?utf-8?B?cGdBNy9uVUxIZlBtdFB5YnZJeVFnZVB2bnorWG5PT0sxdjFHU0tVT0tZZU9F?=
 =?utf-8?B?bDk0NmM3NHF0RWdtT003czIrOW0yK2crSjBSMzNQcXlwNVJtbHhCcHVtV3di?=
 =?utf-8?B?Ykh0RTZoaFJ4bW1wTjkrWkthQ016L0E5dklXWWlXYXg2RUQvZ2p0RFNQUHpl?=
 =?utf-8?B?djM4cTd4QmFCN3RSWkZvOU82c0MzdzhwWTcxRFlNNEpML28xUmFDeFhZaWNT?=
 =?utf-8?B?V3FabWNjeTc5VXVaaDFKb1pWdUk0amczd3lhbENmM1dvdlY1UTFIM3NtT0Zy?=
 =?utf-8?B?VGFKWm80RzhBUFZpS3hzS213d3pTeGVuandPRUorNGpQb0lBdjAyVEtQelU1?=
 =?utf-8?B?bWxsNHRFUnJUeDFiekk5c05KaHZtN1ZCUEZXekF3WlFtNUJuOWp1Nk94dDBi?=
 =?utf-8?B?SXNzSjFheFpIYTl0MUtjb0lnaFBUWHRyY1FYMk5aMjVmTnc4YlBGMUdTZjJM?=
 =?utf-8?B?VEhYaUVnelI3VFk5TVhJbWRBdno5WU95ZVIzZDBLamgyRC9LNUIyVEJJcHln?=
 =?utf-8?B?U1BZQi9xcHh3cEpMWUZ2UTlkb0QzdlVod29UTGk5ZjZtY09qMVg4eCt5YUVi?=
 =?utf-8?B?enptUVRUV0ViSTVCaWMvY1hPN2g5RW0yUGI4TXpQYlRoL3RQaXN3dForZUMy?=
 =?utf-8?B?ZG9PZ0JDOE5keTh3S2VlY0xOcHU2T1dYaUpzSTdBbnp2UmdER24wWGhvWHI1?=
 =?utf-8?B?TkJ6VnAzRXB2MHh6UVNKVVdPS0VORjArQk1Gb2dLUm1hdkpXanFrRnZCNWYx?=
 =?utf-8?B?aGZyOXVROXRqVW12ajZOQ1J3cGxwNm5ZU0ZVdmt1K3c1c1NTTWxtUzBYZjRx?=
 =?utf-8?B?N1dlU3g1QVpWNjFqaU9QL3hGUDZoa2pOUWhaVEx0S1NNcGkwZmxVQm1rS21k?=
 =?utf-8?B?WXlJaG5sQldyTS9RNTJMTjVIMUlQS3l5aHlLVTlyb255QzdNdU55OTNlaHF4?=
 =?utf-8?B?Y09VZnFmVFRVTzA2Y1hGYk02eHpmWDR4SnMzVG16RzEwa0habTlGTGlIZGcy?=
 =?utf-8?B?Vk5QM0ZwQU1WQVpHcHlFQTBmd2tYMTBhRFppM252WVlEQWpEelo4eTVQbk5v?=
 =?utf-8?B?aWZIUWJUWFlqVGFJY28xOXB6M0sxSkNmRzJUWW1yb3dESmkzN1QxVG5HckZm?=
 =?utf-8?B?YVovM25ZalJlNmthMGZyUzZ6V1VRZUViVHVmRGxlRi9JalVOODkrK3h2WnNL?=
 =?utf-8?B?VGplbGNzYlFQcXcwRERjWFplL0N4aDdzVXFRUXJwcWFuRDZ0Nm93VHEvOWVT?=
 =?utf-8?B?NW5QbElTVDlFNHU4cGJBaG5PK2Q0YXlnMlc4V2tnZm1ndVhheDA2Z2c3TnNl?=
 =?utf-8?B?SUc5aXdYcGZOVkMvUU1wSytPeTBka0JINmg4TjFkQWpYRWFlN1JkeW1DWDFV?=
 =?utf-8?B?d2FhaU1DWEJ3cHE2UEJ2dndWbkthSURoUmJrbFdQd095MHZEOWtXaGlRL0U0?=
 =?utf-8?B?U0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b5bbca1a-f477-456d-a4c4-08dac595f6ad
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2022 16:41:50.7751
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7FuKmdu9+n6XGsLtDFNAfp3y4wRJGa4NuWcRwD/4ZAKP4mughRZ84DG7CZiFz1g58In7p2mzAU5RAknGxedxVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5435
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/13/2022 3:48 AM, Borislav Petkov wrote:

> 
> So instead of what the code does now:
> 
> +	snprintf(scan_path, sizeof(scan_path), "intel/ifs_%d/%02x-%02x-%02x-%02x.scan",
> +		 ifsd->test_num, boot_cpu_data.x86, boot_cpu_data.x86_model,
> +		 boot_cpu_data.x86_stepping, ifsd->cur_batch);
> 
> It would still use the *same* scan_path - /lib/firmware/intel/ifs_0/ -
> no one is proposing to give a full path name - it would only use the
> filename string - 06-8f-06-00.scan, for example - instead of the "0" in
> it to build that string.
> 
> And, ofcourse it would check the format of that string against family,
> model, stepping and sequence number (btw this way you drop your
> limitation of 256 for the sequence number which you don't really need
> either).
> 
> And then if the format passes, it would check the headers.

Do you think it is better to restrict filename input to confirm to
ff-mm-ss-xy.<test> format rather than accepting any string and treating it as
a file-name and trying to load it, if it is present ?

(Given that, before loading, We do intel_find_matching_signature(), which validates if the
 signature/pf entries in header confirms to the machine we are on before loading)

We did accepting file-name as input before [1] (except for validating if the filename confirms to ff-mm-ss format) 

> 
> And only if those pass too, then it would load.
> 


[1] https://lore.kernel.org/lkml/20220710160011.995800-1-jithu.joseph@intel.com/