Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 13 Nov 2022 09:01:32 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        Thiago Macieira <thiago.macieira@intel.com>,
        "Luck, Tony" <tony.luck@intel.com>,
        "Joseph, Jithu" <jithu.joseph@intel.com>,
        "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "markgross@kernel.org" <markgross@kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "Jimenez Gonzalez, Athenas" <athenas.jimenez.gonzalez@intel.com>,
        "Mehta, Sohil" <sohil.mehta@intel.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH v2 12/14] platform/x86/intel/ifs: Add current_batch sysfs
 entry
Message-ID: <Y3Ei7Nc+1wGOF6fk@a4bf019067fa.jf.intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-13-jithu.joseph@intel.com>
 <Y2/JNAmSoYlLKq3A@zn.tnic>
 <CC3629D6-B205-4150-80E5-FC7A7A76DD25@intel.com>
 <Y3CevK2zhAmiUyG9@kroah.com>
 <Y3DZmKYV+8HBtZ+Q@zn.tnic>
 <Y3EJ93xzgC/1v0WV@a4bf019067fa.jf.intel.com>
 <Y3EUPKWDefnkeObR@zn.tnic>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y3EUPKWDefnkeObR@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SsljLLKUREKBlIhMpITRly6yfPkQZoFhp0PXOJSJkj99ZBelINZgdX66YcSk?=
 =?us-ascii?Q?H6up1H6cAc+HGEP66q76nCkieqrZZ7mU4hjseXUcAwE6AoKhed/LwF0PK4g1?=
 =?us-ascii?Q?83t3wWBK8+0ZRDhe0oOoOMPif2dEcNk/Eg0Ytx3fe4lMsjMa6t74WUcsktGZ?=
 =?us-ascii?Q?9y8vBuDJ7YBi6hWhJVKV/B+qdFvX/+aq3bRbZmPXv1S2xCm2FYNDGDRc9Nsj?=
 =?us-ascii?Q?Kj+GpRmm2KXCgEWJq3oDO5OBejibrF7bzhVM1gpmpL84wBpxVyUV6SCaX/7T?=
 =?us-ascii?Q?Rr1slAl9R/B2NhWiH4ypLuB6jAanpc+qSIUFpJ9EMk0AtuHIW+HKDuLacXkm?=
 =?us-ascii?Q?RBe0re5iYtJjApdhBOco3YhIJVL9evDdPllj3hXspv1x8M/ffjrjW/GGaRhi?=
 =?us-ascii?Q?ybmlvn3+rRX7Jxa23NXImGvoopdka3vytgFXBmTLMgAU1rUz5Ck9Zokk6+1L?=
 =?us-ascii?Q?QTUgcacv7QOjYQshTQPyjB57KRFQc1uDz5JWaZXd3DxzJiSJXY5Zia7ZtFlB?=
 =?us-ascii?Q?htrI8iiGmyZDDpacsanysw3rq11IVSv48mqUZvGXU6+ez166y7Wg7gh2Qivy?=
 =?us-ascii?Q?Nj+fMyfDPegN1pBCgHreYMckY7/B3x9lFsXHwi5vk+AiMMkTLBHVPEbaNQ06?=
 =?us-ascii?Q?7Q3iX2HZbyfhbejA0tlmPyiS0VmAnVphGCQehKtkJrQN+YGmt/tCuCBS9OY7?=
 =?us-ascii?Q?BZvHT5mqhW2lBQ7pps7WY9dHGqkKNGHUW+Xwy2hYlU0zd/eCEKNamGvz4K4J?=
 =?us-ascii?Q?GTFiHBWO/D9yQpb4GIngT91wfFmGzNHLK0fhvLdLRlvmKMGe6IIBFF8VEdKO?=
 =?us-ascii?Q?8qrUSK41B5GZuWmT+rFxaPO98K34MuEWCVk1oeV6KGplIkRVmA808AM3RRel?=
 =?us-ascii?Q?HVL8TJ/RxUmAgVLwnQU6wigqNqbcUBoLOhEPAPmlyJmgR1wpoED3uHZGmgMU?=
 =?us-ascii?Q?P2EC7JcFNghhLcL5dWRn1F1Y923zCM7qtmIXr3qycxxhPlNcPh5sCjso15JY?=
 =?us-ascii?Q?tDbeOTBgIw/bJJw01NctaprpXqri7o5gR6yGj8xRsAi3dD3RNfyxnEq0ytbY?=
 =?us-ascii?Q?AvQ9J87eikOcxjoq88i2h9s9z7ax7Py59GmPEjxhi0hBxKhVtBSxT0un07UC?=
 =?us-ascii?Q?i7kndNcNj6KSUH+/1/20IuYzoS18kdIBSQyQ9q/PRYou8Fl0vHA/dHTM8WDD?=
 =?us-ascii?Q?KbQNAxmyG+UhLoN9UaCD40DnH9Yh7IV6igi0GoYb0Fpk9HYqkw5ODui0Dx0h?=
 =?us-ascii?Q?1xZd1CxBYozxB/7Z7+QqnyhwtzLIhBmNwJWL5GqaRHlwLVG6isdayj26kRes?=
 =?us-ascii?Q?DfVXuXSgPY3ctcGEIIHV3unGz+sFLwtqwSBIQR5hrEEkLuQdk0Ft9ueMiIhR?=
 =?us-ascii?Q?sOw7N4a4cqHBKKcoRI0yNN5QQX8aWa1kVKRpoMP4X5tHTq1X6IJIG5LmCMIO?=
 =?us-ascii?Q?evxw4TM/LyRmofKc1bDntcq69YaX4wPLhc2oWUf88Bcca5k8j9NEK+XWinLH?=
 =?us-ascii?Q?S2t0eEaRpwfADg0At2BwbSrmQPUlnBsfQNaX+3zlW1U+6srT2oxpOLC290od?=
 =?us-ascii?Q?CoF58t7w86i6R5/MDkq8TtLIRbHTjfOvkH24C0YT?=
X-MS-Exchange-CrossTenant-Network-Message-Id: caa78c14-80a9-4b98-b453-08dac598ba7b
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2022 17:01:39.6507
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zJ+4MU1MPA4gqA12NvrnPgz0YWhhapwp3YBcvX2Bb/L1MvuniUoWylt2Ll/OH2FK7QPBpImxvFlgXay2rHhC6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5142
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Nov 13, 2022 at 04:58:52PM +0100, Borislav Petkov wrote:
> On Sun, Nov 13, 2022 at 07:15:03AM -0800, Ashok Raj wrote:
> > Do you expect the /lib/firmware/intel/ifs_0/ to contain *ONLY* files for
> > this platform? For microcode we have everything in the public release
> > included here.
> 
> Same as microcode, as I said further down in my mail:
> 
> "And, ofcourse it would check the format of that string against family,
-----------------^^ It is user space or the kernel driver?

> model, stepping and sequence number (btw this way you drop your
> limitation of 256 for the sequence number which you don't really need
> either)."
> 
> > In the above proposal, you can *ONLY* put files for this platform
> > unlike simply copying everything released and let the kernel pick the
> > right one since it does the ff-mm-ss-*.scan lookup. Only the batch
> > number is supplied from user space.
> 
> No, see above. You check the filename against the current f/m/s. Just
> like microcode.

If it's Ok to ask a question. "You" above is the kernel?

Microcode has no such functionality today right? User space 
never inputs a filename, only performs echo 1 > reload.

If a file name composed by the kernel exists, then it checks the header
validity before proceeding.

Apologize if I misunderstood you.

> 
> > Even in the current implementation, user doesn't need to know f/m/s.
> > That's something the driver selects automatically, just like what
> > microcode does for reload.
> 
> Basically what I'm saying all this time.
> 
> > Isn't it simple now? No need to check if user supplied the right f/m/s
> > since its not a user input, kernel composes that automatically.
> 
> Let's see
> 
> * try echoing a magic number into some sysfs file
> 
> vs
> 
> * simply try *all* files in a directory
> 
> Latter is even simpler because you don't have to explain anything about
> sequence numbers - the user doesn't need to know.

Ok, so can you take through how that is going to work.. 

for i in *
do
	echo $i > batch
done

If some of the files are for a different fms, kernel will check the format
and ignores the input.

So some of the files will work, some will fail, and user space doesn't
care? 

Please pardon if I misunderstood you.

> Ashok, you prove for the nth time that you don't really read my emails.
> Sorry, try again.

I absolutely read your emails Boris. But when I have a misunderstanding its
an iterative process. 

Asking a question or responding to your email doesn't mean I'm willfully
ignoring, or have a ill/malice intend. 

You are reviewing the code and I'm simply discussing what each person
means. I hope its OK to have a dialog.

Cheers,
Ashok