Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f307b37f-26de-cb8f-e199-f327f2c7f807@intel.com>
Date:   Sun, 13 Nov 2022 09:55:00 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2 12/14] platform/x86/intel/ifs: Add current_batch sysfs
 entry
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        Thiago Macieira <thiago.macieira@intel.com>,
        "Luck, Tony" <tony.luck@intel.com>,
        "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "markgross@kernel.org" <markgross@kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "Jimenez Gonzalez, Athenas" <athenas.jimenez.gonzalez@intel.com>,
        "Mehta, Sohil" <sohil.mehta@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-13-jithu.joseph@intel.com> <Y2/JNAmSoYlLKq3A@zn.tnic>
 <CC3629D6-B205-4150-80E5-FC7A7A76DD25@intel.com> <Y3CevK2zhAmiUyG9@kroah.com>
 <Y3DZmKYV+8HBtZ+Q@zn.tnic> <5e65889d-d68c-b29d-6cea-7b4ce4c87b4a@intel.com>
 <Y3EiKUzpShqwzEf6@zn.tnic>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <Y3EiKUzpShqwzEf6@zn.tnic>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkJhNVRHLzV0eE1mSTVKdkpMODVYckZuNkdYbjZteHdaZkdGSURXWnFWNm9l?=
 =?utf-8?B?NWQrUHNkQm1DR241MjlPSENLUWgwenhhZllaMWp0dVhwSmpvU0VFTVRaU2NF?=
 =?utf-8?B?VFc5L1lpMjZ2bERxNjBxeG1weUxUNnZtWWpCMGdkNUovOHF4MU5nQzdjdUNs?=
 =?utf-8?B?T1Bjc1NKZ1crNW9RWUR1cXMxV3NYS0FPU2N2S2paOVNrUytuUnY4SER3Tm1H?=
 =?utf-8?B?cG9rcGl3anhyVmZJbEUweis0R1ZWUTl1UVdmY2xuK3YwVVVGNkQxSm5nRzlq?=
 =?utf-8?B?Kzc5SjREbkR0VXluZ2ppN3VTbkZOeG1MWEhhcXJjczQ1dUZ6M3lmMEloWjdo?=
 =?utf-8?B?VTFFaFJva2toOEpNYmVrLzFnY0hWMktiQUZPdDFvLzVRV0pPcnZiTjgrSHRp?=
 =?utf-8?B?TUNkUTdIdTJNU3AyOWZtK2RTTitsN0hyNDlzRVBSdmJkLzhFV24xb1FDTVd6?=
 =?utf-8?B?L3d1ZHdOYmI2U3VkSVErZjMwL1hkOHBEZDQvWlo1RmdNMGFWN3NXSGlMYkRw?=
 =?utf-8?B?V3BFZkpENnJVeHYyemMvZUw3NWRjbmFNMTcwY3RjYnd6cjFITUQwSVBpU29w?=
 =?utf-8?B?ZzhaNzlnNllSKzkycGZYRSs5YjRSVTdrd3FIMG45MzA4cnRtdUNMWDExbzZW?=
 =?utf-8?B?OS9uelAySStQSVNaamVsMXdRd0ZLbmE2Z3RQK2ZpOXZCWk5oSWlYUyswK3VH?=
 =?utf-8?B?dGxzdWhBbEc3aHVWNlIyK3BvMkg3aEcrMnJmQ1owQUFDdWJNVm5saXlMbkdR?=
 =?utf-8?B?ZDVzakpSaTRtTURobmM5Y3FLdFBFbkZoMno2NW5udkQyTXVkWE9tRFE3cEZx?=
 =?utf-8?B?SGVXS2UrTjV1K3NxcytEdlZSSEFiOFNEZHRWMFY2RDRIOE1WMzVJQlJuVTBr?=
 =?utf-8?B?TDlBWURiaWU5ZEdVbVBjeHIzRS9Yb1JCQmxZa3dwdHYwUzJ3NkRHb0dpdTh3?=
 =?utf-8?B?NGVkRDUrUjI3eE5FYW9lUlEvUmdoNEpaUVFaOFJYS2EzVllxYUtJWkEyZlNp?=
 =?utf-8?B?Wit1d0xwSWliZi8zSEpxRTBSbCswN1ZwMTBLWGdZeVYvVklmZVM1RCtDVTZC?=
 =?utf-8?B?elFHTlJabWtjeWJuS0ZWRUdzWEtaWTJQcWNjcG9tdnpyT3lOa1pVOFovWEJm?=
 =?utf-8?B?N0tIRHVmYWFJUDRlWHlRMFNXWTNZeUM3M3pvZmkvU3V3ZHZLcWZuSHlCNkR6?=
 =?utf-8?B?TEVqeFZhdEczUlE1WlBwRkQrUnJmdWdXNlpjbVc1cFAvMkJHWUozQWV2WjBm?=
 =?utf-8?B?aVpjcFYrZkJINU1iaDZ4bnRyNk5DbFM2MXJCRkg3aFVvMjlUMkphMi9wUmY2?=
 =?utf-8?B?czB3SktKOXU5OTFTTkpFYnlPMzB6ZXgzWXJ1K0wyUEpIdWtMZWpmYTgzMitO?=
 =?utf-8?B?bHkwMDdIVFl1cW94T0QzcndCU25GdlFrMXZiODlkTzZQWUU3dnVta1Y2VVR2?=
 =?utf-8?B?N1JDTENCMEhsTE8vVUdXd0pFNE0vdHpGOEtpLzkxVzk5czV2UjZtbW9IWHFZ?=
 =?utf-8?B?TTYxZE9aRlJMelFMOHJ0d2RSaG1ScnlIdWdIekxhenNaT0VDK0p2RHdJMGxk?=
 =?utf-8?B?V3JwY2prbUEzcnFRb21BbGY4NERiaGJDQVJCM2ZFdWlFTGxPRVVzYWVDcDU2?=
 =?utf-8?B?Tk90cHZZS3k3WWVRb2ZucFRXOG9CbHpsSjZuYVZYS3hvRHFwRWk1dE9WWjEr?=
 =?utf-8?B?ZWNraFlZVlNCN0NKRXgrK01KZmVUdzlLTk5obmJ6UHlrTGVPeTdlVFhMRU5q?=
 =?utf-8?B?KzVNRlA2VTJNaUJQVnBHMFQrT0VGei9BdUo0c1BhMHp2NnI2ZkJoZnIxNld5?=
 =?utf-8?B?OGtXbWFQM0s4V2hvMG9saGVqTFcyTktnWTRNNmd1YXZyUWNLcWc4ZzUyb0Ns?=
 =?utf-8?B?QUs4S0U5Zzk2R3JRcHpHeFArN2VVZlNmQTJzNG8vVm51UUlkeGsxRG84RVoy?=
 =?utf-8?B?cnh1U1U3SFl5azdWeTlObDk0bVYxcFdDOTNBRjdyVnFtMHp2MkJ0U1dEc3Ux?=
 =?utf-8?B?UnFGNG8yR2J4R0VISEU1QkNONDdQVmRYWVE0dERrT29nYXpZZExNRmM5Y2Vk?=
 =?utf-8?B?dHlITWt3dDNyN01xS2VrSzRISU82K0tVM0l0UmlzeU1VelhGTjVuWlowMU1J?=
 =?utf-8?B?VEt2bU5iazRvVzBYUnQrd0tRVE5YWFdmYTM1d3Q0YWI5MVB3NlpKalVQOWxs?=
 =?utf-8?B?dmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ca870ecc-3c7f-46fa-a0da-08dac5a030d8
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2022 17:55:03.2538
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XOjLNOojiuhni9Skl10E3PdqZyij2+gPPPiap2/uaKhoVJB6ZoHtYuSidvkdllb2kKiES4Aq5VqSUtpr0pHB4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7641
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/13/2022 8:58 AM, Borislav Petkov wrote:
> On Sun, Nov 13, 2022 at 08:41:47AM -0800, Joseph, Jithu wrote:
>> Do you think it is better to restrict filename input to confirm
>> to ff-mm-ss-xy.<test> format rather than accepting any string and
>> treating it as a file-name and trying to load it, if it is present ?
> 
> Yap, that way you pre-filter filenames. Yeah, the header checks *must*
> absolutely happen too but it would be a simple first test.
> 
> Also, you can check for:
> 
> ff-mm-ss-X.<test>
> 
> where X is a [0-9]+ of arbitrary length and this way won't have the
> artificial 256 limit you have now.
> 

Thanks for clarifying

>> (Given that, before loading, We do intel_find_matching_signature(),
>> which validates if the signature/pf entries in header confirms to the
>> machine we are on before loading)
>>
>> We did accepting file-name as input before [1] (except for validating
>> if the filename confirms to ff-mm-ss format)
> 
> Yeah, except now you want to do multiple sets of scan files.

The earlier change (which modified reload sysfs file from accepting a file-name instead of 1) was for
allowing multiple test files (i.e no different from what we are doing now)

Then we were told not to specify a filename via sysfs file (apologies for being repetitive)


Jithu


[1] https://lore.kernel.org/lkml/20220710160011.995800-1-jithu.joseph@intel.com/