Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764587AbXHHMA1 (ORCPT ); Wed, 8 Aug 2007 08:00:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758034AbXHHMAH (ORCPT ); Wed, 8 Aug 2007 08:00:07 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:38302 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753490AbXHHMAF (ORCPT ); Wed, 8 Aug 2007 08:00:05 -0400 From: "Rafael J. Wysocki" To: Andrew Morton Subject: Re: [RFC][PATCH] uli526x: Add suspend and resume routines Date: Wed, 8 Aug 2007 14:09:41 +0200 User-Agent: KMail/1.9.5 Cc: LKML , Jeff Garzik , pm list , Grant Grundler , Kyle McMartin References: <200708052114.01790.rjw@sisk.pl> <20070807160357.d6ea9731.akpm@linux-foundation.org> <200708081405.00778.rjw@sisk.pl> In-Reply-To: <200708081405.00778.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708081409.42384.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1132 Lines: 31 On Wednesday, 8 August 2007 14:05, Rafael J. Wysocki wrote: > On Wednesday, 8 August 2007 01:03, Andrew Morton wrote: > > On Sun, 5 Aug 2007 21:14:01 +0200 > > "Rafael J. Wysocki" wrote: > > > > > +#ifdef CONFIG_PM_SLEEP > > > + > > > +/* > > > + * Suspend the interface. > > > + */ > > > + > > > +static int uli526x_suspend(struct pci_dev *pdev, pm_message_t state) > > > > Since when did suspend and resume methods become dependent upon CONFIG_PM_SLEEP? > > > > We have eight thousand implementations of this, all of which presently > > use CONFIG_PM. > > Yes, they do, but if CONFIG_PM_SLEEP is not set, they won't be used. Well, not all of them. There are some in USB used for runtime power management and there may be some others like that, but the majority of them are really only useful for suspend/hibernation. Like the ones in this patch. Greetings, Rafael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/