Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762194AbXHHMPv (ORCPT ); Wed, 8 Aug 2007 08:15:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752998AbXHHMPh (ORCPT ); Wed, 8 Aug 2007 08:15:37 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:38435 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752491AbXHHMPf (ORCPT ); Wed, 8 Aug 2007 08:15:35 -0400 From: "Rafael J. Wysocki" To: Tejun Heo Subject: Re: Disk spin down issue on shut down/suspend to disk Date: Wed, 8 Aug 2007 14:24:47 +0200 User-Agent: KMail/1.9.5 Cc: Maciej Rutecki , Michael Sedkowski , trenn@suse.de, Robert Hancock , Henrique de Moraes Holschuh , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-acpi@vger.kernel.org References: <200708072233.52500.rjw@sisk.pl> <46B930ED.6040607@gmail.com> In-Reply-To: <46B930ED.6040607@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708081424.48382.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1473 Lines: 40 On Wednesday, 8 August 2007 04:56, Tejun Heo wrote: > Rafael J. Wysocki wrote: > > Well, on my box (nx6325) with the appended (experimental) patch applied > > on top of 2.6.23-rc1 with the patchset from > > http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.23-rc2/patches/ , the > > double spin down doesn't occur during hibernation and the system is shut down > > notceably faster. > > Can you please explain what the patch does? It replaces the shutting down of devices done by kernel_shutdown_prepare() with the suspending of the (just like before entering S3, but the target state is now S4) and the shutting down of sysdevs with suspending them. It also disables the nonboot CPUs before entering the sleep state (S4), which generally always is a good idea. In short, it makes hibernation_platform_enter() execute the enter-a-sleep-state sequence instead of the mixed shutdown-with-entering-S4 thing. > So, I take it that entering S4 also spins down the disk. Yes. > Does the patch remove the ACPI spin down or libata one? I _think_ that it removes the ACPI one, although I'll need to do some more testing to confirm that. Greetings, Rafael -- "Premature optimization is the root of all evil." - Donald Knuth - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/