Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Nov 2022 04:01:40 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Akhil R <akhilrajeev@nvidia.com>
Cc:     ldewangan@nvidia.com, jonathanh@nvidia.com,
        thierry.reding@gmail.com, p.zabel@pengutronix.de,
        dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
        sfr@canb.auug.org.au
Subject: Re: [PATCH v4 0/3] Tegra GPCDMA: dma-channel-mask support
Message-ID: <Y3FwTHpWgeK6x6kh@matsya>
References: <20221110171748.40304-1-akhilrajeev@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221110171748.40304-1-akhilrajeev@nvidia.com>
Precedence: bulk

On 10-11-22, 22:47, Akhil R wrote:
> Read dma-channel-mask from device tree and register only the
> specified channels. This is useful to reserve some channels for the
> firmware.
> 
> Also update the channel number and interrupts to include all 32
> channels. The current DT bindings has only 31 interrupts which is wrong
> and doesn't align with the hardware. This was done to reserve channel0
> for the firmware. Now with this change, the driver can align more to the
> actual hardware. but this implies that there will be a breakage in the
> ABI and device tree must be updated along with the driver change
> for it to pickup the right interrupt corresponding to the channel.
> 
> This breakage is okay right now because GPC DMA was introduced on
> Tegra186 and the DT bindings were added in 5.19. Any products released
> with this IP were released with kernels prior to 5.19 and bindings that
> were never in-tree. Any of those products that are supported upstream we
> know have replaceable DTB images (i.e. by default they are flashed at the
> same time as the kernel image).

Applied 1 & 3, thanks

-- 
~Vinod