Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Nov 2022 03:58:08 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Fenghua Yu <fenghua.yu@intel.com>
Cc:     Dave Jiang <dave.jiang@intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        dmaengine@vger.kernel.org, Nirav N Shah <nirav.n.shah@intel.com>
Subject: Re: [PATCH] dmaengine: idxd: Fix crc_val field for completion record
Message-ID: <Y3FveOiymPb3fpWc@matsya>
References: <20221111012715.2031481-1-fenghua.yu@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221111012715.2031481-1-fenghua.yu@intel.com>
Precedence: bulk

On 10-11-22, 17:27, Fenghua Yu wrote:
> The crc_val in the completion record should be 64 bits and not 32 bits.
> 
> Fixes: 4ac823e9cd85 ("dmaengine: idxd: fix delta_rec and crc size field for completion record")
> 

Please no empty line after the fixes tag!

Applied after removing the empty line, thanks

> Reported-by: Nirav N Shah <nirav.n.shah@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> ---
>  include/uapi/linux/idxd.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/idxd.h b/include/uapi/linux/idxd.h
> index 61ee43823622..09947ae61663 100644
> --- a/include/uapi/linux/idxd.h
> +++ b/include/uapi/linux/idxd.h
> @@ -329,7 +329,7 @@ struct dsa_completion_record {
>  		};
>  
>  		uint32_t	delta_rec_size;
> -		uint32_t	crc_val;
> +		uint64_t	crc_val;
>  
>  		/* DIF check & strip */
>  		struct {
> -- 
> 2.32.0

-- 
~Vinod