Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp4824359rwb; Sun, 13 Nov 2022 14:52:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf7+mqtY0M7lB2zy+AKCF0V2WYFsroRkJLC6nQz2wSfj3l1BFaQ+BwGJYPMczGYbeMd5ZD5i X-Received: by 2002:a17:90a:cf14:b0:213:2039:64c2 with SMTP id h20-20020a17090acf1400b00213203964c2mr11320579pju.165.1668379947572; Sun, 13 Nov 2022 14:52:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668379947; cv=none; d=google.com; s=arc-20160816; b=g4shHpYrFhkVbgWUW6MZyr93h/a621y0KG/XzPLQ1PB/7PdY+adnUb2YpygoBgUqea ZoYWG/swY0Bi4Om4ECHlCD5TqGyNBbeMBajRN1dWhjVcOoSPiI8HnTibtWPUJppgEby6 tPQezT6DeFEY69N+GBLB4SbDLQi8lA5UOGQC2LqpKxG4U83v8f6+RKX9eo5UxA9XLKCD xVJjTvfox0tc8msCN2A5CfAyihmPTQe2AdK7Q+4vqFfLD90LOdAq3ZfXVGbrVcywQy8R hSiGiUlWhXc7M2VKjqREMn9R+uAR/4BcToWeIZtHZGJBLLt0AjCykRoyJ6kkxF0Q56xJ Hj3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=q6qApWsmJ9Ez30h5inmNVLzzV4IIlxvn+kq5fZSc6wA=; b=vZniwC8iBHLfvOLiPTsphLdQH+11KfEUEaFfBvJVxW5167J0N+ZNbBuonGaj019epK pSpY8sdgToXEQElA2BfzXtuVXcjKP3DanZ535YEjYLk3Co3urwfgQ7k61+HShiONXtTc bpcAfznf76Z9HVb3n2WVfThPlGdQQ79itrYoHAxiYuGA/ZYOsPJKe8MqwbdEr74INE6T mraW60w61T/X/PoZqZWt1cP0sIGENc4Xoz5M/vRKeyEotEycbxpdCd8NEuP1FCpKYWTe IG470jEgouQTQ8i6EdFFoxoPKhi2jC3fXFkSlYp1Po6WAtl5Y3NoTGxshm/oq0sc7qcC 8qhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=ogGDDoyV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z4-20020a656644000000b004706a2c7d4fsi8160489pgv.611.2022.11.13.14.52.16; Sun, 13 Nov 2022 14:52:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=ogGDDoyV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235495AbiKMWlC (ORCPT + 90 others); Sun, 13 Nov 2022 17:41:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230525AbiKMWlA (ORCPT ); Sun, 13 Nov 2022 17:41:00 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E8E5EE2E; Sun, 13 Nov 2022 14:40:58 -0800 (PST) Received: from zn.tnic (p200300ea9733e773329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e773:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B7EFC1EC02DD; Sun, 13 Nov 2022 23:40:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1668379256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=q6qApWsmJ9Ez30h5inmNVLzzV4IIlxvn+kq5fZSc6wA=; b=ogGDDoyVnAa0TF1K4T6Pfrr9sLDVXeT8lkRv+RSX41PlXZtI7+cpdqDxf2+sH8FjsNJuju gfPWxd4HM7hYu0mYum0pt2dtQX7ouzExDiH/TroLLNarmPSf6uFQ4GUdrYLg9dc42au6HD wbr3wgUCwsf+mlSzqlbaeCeYcp7em4A= Date: Sun, 13 Nov 2022 23:40:51 +0100 From: Borislav Petkov To: Thiago Macieira Cc: "Joseph, Jithu" , "gregkh@linuxfoundation.org" , "Luck, Tony" , "hdegoede@redhat.com" , "markgross@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "Raj, Ashok" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "patches@lists.linux.dev" , "Shankar, Ravi V" , "Jimenez Gonzalez, Athenas" , "Mehta, Sohil" Subject: Re: [PATCH v2 12/14] platform/x86/intel/ifs: Add current_batch sysfs entry Message-ID: References: <20221021203413.1220137-1-jithu.joseph@intel.com> <5e65889d-d68c-b29d-6cea-7b4ce4c87b4a@intel.com> <2206677.iZASKD2KPV@tjmaciei-mobl5> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2206677.iZASKD2KPV@tjmaciei-mobl5> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 13, 2022 at 01:21:41PM -0800, Thiago Macieira wrote: > I'm assuming that the kernel would provide different error conditions for > those. But handling those in shell scripting is very difficult: you'd need to > start a subshell and parse stderr. You call that "very difficult"?! > And this is part of my argument of why it's unlikely people will use their > shells to do this. That shell function is easily another 10 lines of > scripting, if it's meant to do its job properly. To make that easier, we've > developed two tools, one of them the OpenDCDiag tool I linked to, but both > just happen to be written in C and C++ instead of shell. I've told you already that having a special tool is always more problematic. I guess you'll make your own experience distributing it but if you see pushback and people start complaining, you shouldn't wonder why. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette