Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp4899686rwb; Sun, 13 Nov 2022 16:41:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf743AuzzOlGkWUe2xN+mBqt+uWf0g+c5ocmQLQKCZ/wMp9GTn7QcmbJfUWNLDO1CqIU1OEe X-Received: by 2002:a05:6402:1750:b0:467:d741:f359 with SMTP id v16-20020a056402175000b00467d741f359mr2347590edx.100.1668386515284; Sun, 13 Nov 2022 16:41:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668386515; cv=none; d=google.com; s=arc-20160816; b=tmRh1iUpCQkArbK1fZ7ZllPOni2xku+mEGWwQLs+wejSkgUGYD2LkCWDAPkWLJoM3r 8pRgjrLaWewNyscK7+Msy21A+f6L18/cUUIqHmO5mmIj9ucjpt4VskVaEA3IPLxtUDbR bhaJ/mYDPUsdiqo8/xMjTj18db0nzZsGKkTXJ887S6A1U08DRBicr/ycnIuoa8Atuvu6 b4iAr4Ht+Y0ix0TzvKDP36oH4eHbyz2RXci8T4ZTMLksHstOqNqrcynXnls8JlrXZKHQ 31EWBeHxjDfkAbweuZMCTErxqtQJwed9eud/JSHFraf/EP+ybTzhK5CHyR2XmecCQSkY ZHQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=8kz1DEcjSZFrbtX+E0/EuqP/aOzm5uWRY6IedeZzrxg=; b=T+INaDQ/jxOLyeKG9vh04uUNZ6mGjjYNAAYG+YNWCy2m6zrpMhJhxBcFi8eV7QeLUX sN6xS16iICEwWJ8yK1HuwejUk37n/x1vcnak4t+roYnDOK6KBzVBxP9v8dK48e2c5R8Q ggnJ0q72zzjT7N4BlRMDqasZ6Y5YqVLHmU/KhAVnigtBbbhQUtoFeCqTCMZW4XlCdtND LeqWsuKt+t4jIXOsLfgBNlImWG8ZgH3hf5tRrqJXtYaZLlGBp46dgwFXZaF/LtPPVOrz BOxEris18URDcjVGlG7j/C9k3aqVHUYnGBsW+8nSxHqMzVjuGLQD9iBHSaf9EDg39Hj6 Gteg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Mk3H3aAt; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h24-20020a50ed98000000b00459101ecc5esi6238492edr.468.2022.11.13.16.41.32; Sun, 13 Nov 2022 16:41:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Mk3H3aAt; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235550AbiKNAda (ORCPT + 90 others); Sun, 13 Nov 2022 19:33:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235481AbiKNAd3 (ORCPT ); Sun, 13 Nov 2022 19:33:29 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D074E3B4 for ; Sun, 13 Nov 2022 16:33:27 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1668386005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8kz1DEcjSZFrbtX+E0/EuqP/aOzm5uWRY6IedeZzrxg=; b=Mk3H3aAtLNVxoLG4TXeRB6G8wtPqpPCHhIvjSno5eurVoZ6qwN2cXwoFu1Wsf7bhuqkHnv kyewZqMtadC1ljOCegs96Gk+znQwNdhv8yW6t0tZVEx8gysS8NW4etvzjzDD4w7IBqCTbs PQA3IRPddaRK8jsvqzmUBreU0Pgh2GO+02+iBN9Lxt3GtuRTtdoHFvhbUcczw1WYxu14Pm MVRssnrvjjQW0ixABRKipQOdvow4cHh5dw2/q3OYynEsR++ESAPkUj5dvoA6xBLnLCRLKU ZOX8PxXnR3rwBvHuTKq7cYIbtnGARaBLYwsbl+3s86oVMOq7Q4ry6BQBUcUUkQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1668386005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8kz1DEcjSZFrbtX+E0/EuqP/aOzm5uWRY6IedeZzrxg=; b=N7Cic6nF7vggvcWYlb99PCkUdp992DG3FKzDNztE+8w2uuFSGfjEFtpZWv3Cw5H2MVJGja i8zuedVcf3p8oyDA== To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , Julia Lawall Subject: Re: [PATCH v6 4/6] timers: Add timer_shutdown_sync() to be called before freeing timers In-Reply-To: <20221113191518.0a3b29b1@rorschach.local.home> References: <20221110064101.429013735@goodmis.org> <20221110064147.343514404@goodmis.org> <875yfitpdu.ffs@tglx> <20221113191518.0a3b29b1@rorschach.local.home> Date: Mon, 14 Nov 2022 01:33:25 +0100 Message-ID: <87sfims7ca.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 13 2022 at 19:15, Steven Rostedt wrote: > Thomas Gleixner wrote: >> You surely have spent a massive amount of analysis on this! >> >> Can you please explain how you came up with the brilliant idea of asking >> Linus to pull this post -rc4 without a review from the timer maintainers >> or anyone else who understands concurrency? > > I trusted the source of this code: > > https://lore.kernel.org/all/87pmlrkgi3.ffs@tglx/ Sure because uncomplied suggestions are the ultimate source of truth and correctness, right? I'm terribly sorry that I misled you on this, but OTOH it's pretty obvious that you decided to ignore: https://lore.kernel.org/all/87v8vjiaih.ffs@tglx/ Thanks, tglx