Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: y8XEENLI3PYfRdO+xPHLEilTq7nmSw8TlPZhLNdZx4wpyX7CF+mCfjHr6pUo5LAULVs+8sVDfx
 fNa54kaotiZHMW+1KIc6+0+3ONr+JvLuyMrbEoxzGcVp0mXYx7kM3TrMFXz2U5rGv4ieZJ9Fx4
 h6gyVD/eyIZlZ+djoHFEWt0LS5UPB8x9VJol9K1yGNmI4MzbMDOYiV3+cELgcG1v4WHpwq9S4B
 jfUs9YGxV5tN1eenvw7Ey+3mPAJJ3N5Res4y/tn8u39siMZY2SjbnKaUFIFV+i8K8Pu9jl4h9/
 Kng=
IronPort-SDR: 5HmcQCsd89CoSBRIlRkDg1oB6tKpKwuB94xvnBJTn6FBSEj5V8MoWFVbiJtL/awTnKL9A63ZEP
 RyJm+uIK1AXE0tevRWTxzXcdUtjSW2gzEb2oZCufWQh6f+Z92fAfHZ8XAmg7wIocfGVnrGUEEh
 NawmabjkZhAaRP2rD/NFriXckIFrB8grKOCJyaeBPt0dgsYBozQzkDwQ7hmuKpUjZH2L4fDg5m
 92afxOvu+fgvAH+zuyO5fN7UtOEgdG8Uw/elwx+ZMtTnmEkcks9thE9YF01tKKhMyUS6KPkcsk
 TJs=
WDCIronportException: Internal
Message-ID: <50e1411a-54c4-d9d2-7567-2388219c5bb1@opensource.wdc.com>
Date:   Mon, 14 Nov 2022 09:30:58 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [RFC PATCH 0/5] scsi:scsi_debug:Add error injection for single
 lun
Content-Language: en-US
To:     dgilbert@interlog.com, Wenchao Hao <haowenchao@huawei.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221109155950.3536976-1-haowenchao@huawei.com>
 <58472d12-c1e4-59f3-bb37-a98db17ef2ba@interlog.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <58472d12-c1e4-59f3-bb37-a98db17ef2ba@interlog.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/14/22 06:48, Douglas Gilbert wrote:
> On 2022-11-09 10:59, Wenchao Hao wrote:
>> The original error injection mechanism was based on scsi_host which
>> could not inject fault for a single SCSI device.
>>
>> This patchset provides the ability to inject errors for a single
>> SCSI device. Now we supports inject timeout errors, queuecommand
>> errors, and hostbyte, driverbyte, statusbyte, and sense data for
>> specific SCSI Command
>>
>> The first patch add an sysfs interface to add and inquiry single
>> device's error injection info; the second patch defined how to remove
>> an injection which has been added. The following 3 patches use the
>> injection info and generate the related error type.
>>
>> Wenchao Hao (5):
>>    scsi:scsi_debug: Add sysfs interface to manager single devices' error inject
>>    scsi:scsi_debug: Add interface to remove injection which has been added
>>    scsi:scsi_debug: make command timeout if timeout error is injected
>>    scsi:scsi_debug: Return failed value for specific command's queuecommand
>>    scsi:scsi_debug: fail specific scsi command with result and sense data
>>
>>   drivers/scsi/scsi_debug.c | 295 ++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 295 insertions(+)
> 
> Hi,
> This patchset seems to assume all scsi_debug devices will be disk (-like) SCSI
> devices. That leaves out other device types: tapes, enclosures, WLUNs, etc.
> 
> Have you considered putting these device specific additions under:
>     /sys/class/scsi_device/<hctl>/device/error_inject/
> instead of
>     /sys/block/sdb/device/error_inject/

But these are the same, no ?
At least on my Fedora box, I see:

/sys/block/sdp/device/ being
/sys/devices/pseudo_0/adapter0/host19/target19:0:0/19:0:0:0

and /sys/class/scsi_device/19:0:0:0/device being
/sys/devices/pseudo_0/adapter0/host19/target19:0:0/19:0:0:0

> 
> ?
> 
> Doug Gilbert
> 
> 
> 

-- 
Damien Le Moal
Western Digital Research