Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0119143d-6841-761f-93c1-159f424ee5e0@oppo.com>
Date:   Mon, 14 Nov 2022 09:42:52 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2 1/2] f2fs: fix to enable compress for newly created
 file if extension matches
Content-Language: en-US
To:     Jaegeuk Kim <jaegeuk@kernel.org>
Cc:     chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
References: <20221111100830.953733-1-shengyong@oppo.com>
 <Y272nVjzr6CynmyQ@google.com>
From:   Sheng Yong <shengyong@oppo.com>
In-Reply-To: <Y272nVjzr6CynmyQ@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDEwMUhWM2REMU1FWkJhOC9iZE0zd2tTT3hrbzgzOWs2Zm5pTFZwYXFXRVoy?=
 =?utf-8?B?bjVETlN2alRwTkRiSHhzd1NpcSt5UUZjblJRSTAwR25sQ0JlMURQRldZaEFl?=
 =?utf-8?B?K2VWV3ZDTW0zbDZZUHErdnYxK3N2MDhtMFpCalVPSnJ0bnJuYjFJY0JtNmZw?=
 =?utf-8?B?Y2xodEJzOE0vbzBrUWwvTkxFWHlGK0Y1VTFxY2hJTFJ6S3czTlJJMm5RL3ph?=
 =?utf-8?B?UW0rVCttUmpZZkttTFoySVgvUTVaa1ZOWjVtYWRRbHUzMVZDTENmU041WlBR?=
 =?utf-8?B?dWlDWTMrUXZYbGY1UHljRWRkU0hyRmVteTVKOHU3Skt4WDVlTi8yZWZMZHNl?=
 =?utf-8?B?MkZqbUVWSjVWSHIyem41cjJVZ2svbW5jeHdDZmd1dFQ2R0JvNWpnL2E0eXNK?=
 =?utf-8?B?amN3UW85dnQ1eWxta3l1UHdoWkkwK3VqT1dONTJ5OUFVWjZMc3ZnenE2Sldp?=
 =?utf-8?B?aDRRSGZidkR1bE5zSkhJZ3FVQmIyQlBSNkJEZ0w0Z0xpcEVWSlY0NkF0Z2Jz?=
 =?utf-8?B?VnB3VnFWeTErMEVDVzJMUXJGQmVmcTk2Zm54Uy9lTHJjTjNOenpIWmJhTVVW?=
 =?utf-8?B?OE81cWExdC9FL1dJZDl5eFVCU29yNGF1azN4QStvcVk3UWt5MWFYUWVReHF0?=
 =?utf-8?B?N2M0NGloam81b1d3ZXFyNC8wK2xubDJvZWhxWDhLelJESUM1d2FVRGFmQis1?=
 =?utf-8?B?WmJhQmdsL2JpdW5RazdaMEFBU3J2UVRybzFCcThJRlE3Q0wyQnl1ZThRSVNn?=
 =?utf-8?B?MzdqOHVMWG1icnBmM3I4SEl0R3NtRTJZRlk5bnQxTFN1aUFLOTFkYURKamEv?=
 =?utf-8?B?ZERCd3krVFFNdW1Nd25EZ2Jqa0FsV29zOStXMmRpNk8wanY3RFYyMDJqOFhB?=
 =?utf-8?B?V3hUUVV1LzJ2dDJKK3FBRWowbmRXNlJoWXd1QXQ1SDg0UXAreW1iT1hYUENY?=
 =?utf-8?B?blNuRk9SWERLUEVBUHhFV1lZNUNMc2RYdllXalR0UitXNGRQNG9jNUJyOTRI?=
 =?utf-8?B?SklHVzFpdDNvQ0tKcGtwRXVLeG1NMUwwWTdkNHFiMUdMbU9mckFML09Hcmdm?=
 =?utf-8?B?VmpFNnpXakVLZERLaXQ3anRZRlZLSGNBM0cxZFNjMXBWbVlSN1VrWXVKeDJo?=
 =?utf-8?B?UFpWMGlQMXN4ZVc4YnJ2TktNcUhaa2E5eFdDRy9JeFBkNDFlU01DZlFkNE0y?=
 =?utf-8?B?YWVQelY1cDhlU2x3a2xiSS9GZjVKU29OQmFuU1N0NlNMY0VZcVorQ2tzT1Zz?=
 =?utf-8?B?T2k3WG8vMEtpZVB0d1EzN0dQTkwwOXNmN3pDZS9ENC9HZ0c4ek15Z1BLYVUy?=
 =?utf-8?B?N0dsRnhCbXBXeFRiRndHeVk3dW5PQTVHREc5Uzd3a2gyUDJFK2x2Qm40L2dU?=
 =?utf-8?B?NnVpYk05UmF6djNXUEJqV2pOUG1kZmlhakJNRUo3OG5Vc1hhcFRwQVhnMkR6?=
 =?utf-8?B?Q2plajlEN0lSMlhoenN6NElGaXR1RVVFRTZQTzRldC93bVVkVjhvUUttb1RZ?=
 =?utf-8?B?V1VIbGlHaktLTDZxaWxKN1JmdXlFeDMxU0ZQNDZmT1lmd1lCYlJsczAyUG5h?=
 =?utf-8?B?VEJDeVE4UnBMUUwvYTVIYlJLSVBjVldSUmp6K2hjNzJFL1FKdnZEQ1ZNMHZC?=
 =?utf-8?B?QU5vckhpa29tT1duUDk2UVFkcmkxQlUyUjJOKzUxam9SY3oxb3ExR211bmFz?=
 =?utf-8?B?cXRaeDdZVEdUTkV5NmxWajA5Tk4yMzNVVU9wNUtHa2Rpc2xKQWFkRDF2a2Jq?=
 =?utf-8?B?Y3Z5cWNkT0hjZVZaZU0yVHBYaTZsUEtHUnRBVjcyL2E2VGEvSk0zTUNyVVBM?=
 =?utf-8?B?MHBETzFUOGpGU1J6RkR6Q2NnazNaTDQwNXNhSVVWWlg4RCtUSVd5cGdaNGov?=
 =?utf-8?B?S01XQVBVY1QwZFB1NUhnMmg2aVl1UEZhQklvd2FwT281aGdnYWdSM2gyZ3JW?=
 =?utf-8?B?L2hXU2w4SFN1eTJ3RVU0dkZ6V1ppWEg0M0IxVW5sZXFOZVAra2VLQk1QTzJn?=
 =?utf-8?B?N1dnbkdOVGE2NDFCSS9oTDFMNThObmo4QzlVTlAweFNKVzA4N00zdW5TcThw?=
 =?utf-8?B?MlFqTlpXenJFL2NIYS85bFJtZmw0Ly9tWElWNTA1dkV1NFZ2dDFTL3hpTS9i?=
 =?utf-8?Q?hRHsLoXzBxOs5O73/hVnW8Fnb?=
X-OriginatorOrg: oppo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88d24e6d-b537-4e4f-9547-08dac5e18d3b
X-MS-Exchange-CrossTenant-AuthSource: SI2PR02MB5148.apcprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 01:42:55.5089
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C+aEPCywxofsGF5f6F1W4kogbtKkLs8VOyRwwRN0vdcSW/PjznPPWE8ZaPdX6LFUMJ/f2ODZNyosLFGuTImiLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR02MB6078
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022/11/12 9:27, Jaegeuk Kim wrote:
> Does thes make sense?
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=608460dfae20b9d23aa222f7448710a086778222
> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=962379487b5cb9f3b85ea367b130c2c6ca584edf
> 
Hi, Jaegeuk,

Absolutely. Thanks for addressing it.

> Second one is needed to address build error.

Sorry for missing adding a hunk of that patch :(
The above 2 commits are already tested, shall I resend a new patchset?

thanks,
shengyong
> 
> On 11/11, Sheng Yong wrote:
>> If compress_extension is set, and a newly created file matches the
>> extension, the file could be marked as compression file. However,
>> if inline_data is also enabled, there is no chance to check its
>> extension since f2fs_should_compress() always returns false.
>>
>> This patch moves set_compress_inode(), which do extension check, in
>> f2fs_should_compress() to check extensions before setting inline
>> data flag.
>>
>> Fixes: 7165841d578e ("f2fs: fix to check inline_data during compressed inode conversion")
>> Signed-off-by: Sheng Yong <shengyong@oppo.com>
>> ---
>>   fs/f2fs/namei.c | 27 +++++++++++++--------------
>>   1 file changed, 13 insertions(+), 14 deletions(-)
>>
>> ---
>> v1->v2: add filename parameter for f2fs_new_inode, and move
>>          set_compress_inode into f2fs_new_inode
>>
>> diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
>> index e104409c3a0e5..36e251f438568 100644
>> --- a/fs/f2fs/namei.c
>> +++ b/fs/f2fs/namei.c
>> @@ -22,8 +22,12 @@
>>   #include "acl.h"
>>   #include <trace/events/f2fs.h>
>>   
>> +static void set_compress_inode(struct f2fs_sb_info *sbi, struct inode *inode,
>> +						const unsigned char *name);
>> +
>>   static struct inode *f2fs_new_inode(struct user_namespace *mnt_userns,
>> -						struct inode *dir, umode_t mode)
>> +						struct inode *dir, umode_t mode,
>> +						const char *name)
>>   {
>>   	struct f2fs_sb_info *sbi = F2FS_I_SB(dir);
>>   	nid_t ino;
>> @@ -119,6 +123,8 @@ static struct inode *f2fs_new_inode(struct user_namespace *mnt_userns,
>>   		if ((F2FS_I(dir)->i_flags & F2FS_COMPR_FL) &&
>>   					f2fs_may_compress(inode))
>>   			set_compress_context(inode);
>> +		if (name)
>> +			set_compress_inode(sbi, inode, name);
>>   	}
>>   
>>   	/* Should enable inline_data after compression set */
>> @@ -293,8 +299,7 @@ static void set_compress_inode(struct f2fs_sb_info *sbi, struct inode *inode,
>>   	unsigned char noext_cnt = F2FS_OPTION(sbi).nocompress_ext_cnt;
>>   	int i, cold_count, hot_count;
>>   
>> -	if (!f2fs_sb_has_compression(sbi) ||
>> -			F2FS_I(inode)->i_flags & F2FS_NOCOMP_FL ||
>> +	if (F2FS_I(inode)->i_flags & F2FS_NOCOMP_FL ||
>>   			!f2fs_may_compress(inode) ||
>>   			(!ext_cnt && !noext_cnt))
>>   		return;
>> @@ -326,10 +331,6 @@ static void set_compress_inode(struct f2fs_sb_info *sbi, struct inode *inode,
>>   	for (i = 0; i < ext_cnt; i++) {
>>   		if (!is_extension_exist(name, ext[i], false))
>>   			continue;
>> -
>> -		/* Do not use inline_data with compression */
>> -		stat_dec_inline_inode(inode);
>> -		clear_inode_flag(inode, FI_INLINE_DATA);
>>   		set_compress_context(inode);
>>   		return;
>>   	}
>> @@ -352,15 +353,13 @@ static int f2fs_create(struct user_namespace *mnt_userns, struct inode *dir,
>>   	if (err)
>>   		return err;
>>   
>> -	inode = f2fs_new_inode(mnt_userns, dir, mode);
>> +	inode = f2fs_new_inode(mnt_userns, dir, mode, dentry->d_name.name);
>>   	if (IS_ERR(inode))
>>   		return PTR_ERR(inode);
>>   
>>   	if (!test_opt(sbi, DISABLE_EXT_IDENTIFY))
>>   		set_file_temperature(sbi, inode, dentry->d_name.name);
>>   
>> -	set_compress_inode(sbi, inode, dentry->d_name.name);
>> -
>>   	inode->i_op = &f2fs_file_inode_operations;
>>   	inode->i_fop = &f2fs_file_operations;
>>   	inode->i_mapping->a_ops = &f2fs_dblock_aops;
>> @@ -689,7 +688,7 @@ static int f2fs_symlink(struct user_namespace *mnt_userns, struct inode *dir,
>>   	if (err)
>>   		return err;
>>   
>> -	inode = f2fs_new_inode(mnt_userns, dir, S_IFLNK | S_IRWXUGO);
>> +	inode = f2fs_new_inode(mnt_userns, dir, S_IFLNK | S_IRWXUGO, NULL);
>>   	if (IS_ERR(inode))
>>   		return PTR_ERR(inode);
>>   
>> @@ -760,7 +759,7 @@ static int f2fs_mkdir(struct user_namespace *mnt_userns, struct inode *dir,
>>   	if (err)
>>   		return err;
>>   
>> -	inode = f2fs_new_inode(mnt_userns, dir, S_IFDIR | mode);
>> +	inode = f2fs_new_inode(mnt_userns, dir, S_IFDIR | mode, NULL);
>>   	if (IS_ERR(inode))
>>   		return PTR_ERR(inode);
>>   
>> @@ -817,7 +816,7 @@ static int f2fs_mknod(struct user_namespace *mnt_userns, struct inode *dir,
>>   	if (err)
>>   		return err;
>>   
>> -	inode = f2fs_new_inode(mnt_userns, dir, mode);
>> +	inode = f2fs_new_inode(mnt_userns, dir, mode, NULL);
>>   	if (IS_ERR(inode))
>>   		return PTR_ERR(inode);
>>   
>> @@ -856,7 +855,7 @@ static int __f2fs_tmpfile(struct user_namespace *mnt_userns, struct inode *dir,
>>   	if (err)
>>   		return err;
>>   
>> -	inode = f2fs_new_inode(mnt_userns, dir, mode);
>> +	inode = f2fs_new_inode(mnt_userns, dir, mode, NULL);
>>   	if (IS_ERR(inode))
>>   		return PTR_ERR(inode);
>>   
>> -- 
>> 2.25.1