Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 13 Nov 2022 18:24:19 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Dmitry Vyukov <dvyukov@google.com>
Cc:     syzbot <syzbot+d07c65298d2c15eafcb0@syzkaller.appspotmail.com>,
        akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, llvm@lists.linux.dev, nathan@kernel.org,
        ndesaulniers@google.com, songmuchun@bytedance.com,
        syzkaller-bugs@googlegroups.com, trix@redhat.com,
        Hillf Danton <hdanton@sina.com>
Subject: Re: [syzbot] WARNING: locking bug in hugetlb_no_page
Message-ID: <Y3Gm01DB9a5PXLOI@monkey>
References: <0000000000009586e205ed4679f4@google.com>
 <CACT4Y+apC6o7jB+nbsZiUua=P76vAT7wVK4GeCfM-hVtWj=scg@mail.gmail.com>
 <Y3E8ffs8jC7041h4@monkey>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y3E8ffs8jC7041h4@monkey>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QWuxdG7AnAi3jiSOQ61jCRFqE/6Q/5rEhMMh3busGvm+iPsRwI0lrrmopt56?=
 =?us-ascii?Q?InF6Z3OqNA8PMxN56W263nAOmtYdcwv9AN4t6hoz0U8Vl/auG0OODex29wGK?=
 =?us-ascii?Q?d5TGP87XFYo3bbTURgbiWodgX0a6YWSaRM/gpOqHMjVanT+rWev+qTZzR1ck?=
 =?us-ascii?Q?nL6Dpybo3ZGUo6WT2p6hDJo0Xj3lMV4QN0Li6e89Nv5RrFfnnZWDw7uyp/gF?=
 =?us-ascii?Q?DvFlQ+Sdb6/7Y0q5dq1gX6tIIm1XiBv+5uhGAnPyHWtP1/ujHoFyXy+ZSXIx?=
 =?us-ascii?Q?XWvVjU/A4S+RlWOG5/LMnpHXS28t8Vo0ZpuwWxgEJKXlHQ6RFNstjSKGpDTF?=
 =?us-ascii?Q?ayMl1yRGMVaZIqRb51J2zf8KwPiig/FXKTRodm6q2npRYefk1OBmZA0+YHwt?=
 =?us-ascii?Q?69bA49gt2vOvXbbEOoMdPQvK+KrV48RawQXedr6h+YnESTwuK8tIYe9X/AzH?=
 =?us-ascii?Q?pZ5f1pXuq+QYu6Pep1Ip269RJw1qEHFegGlSdimhWgyxGrwXTclQUA46zleG?=
 =?us-ascii?Q?dOWM9AUnjiVQ7iyFetRrHrucfNrYDC79AjfCgxT2JbOmODmN/h77FYkKLmZB?=
 =?us-ascii?Q?MPHooLEvTHvKy3hTeRjvUb+nz8By0GW2Rwe+s4Hgbg5o6JL6yVIn/WMYd06p?=
 =?us-ascii?Q?aJ85Z6Mf0eSak5YrViAXsyZ11HsdOI3xrjdgw5qKptr4vPq5RzNo4ZSnDRhV?=
 =?us-ascii?Q?PYJCAbhj2EsPTfZcdrmncoLc57RyD716BBDT8RnonnO6Pl6Wokej0o27T6Xi?=
 =?us-ascii?Q?CfD7Ue6CsvQRQ0rdjUoN02/McdYluB9WlnuAhDKJstuD4cuB6MkXKUI3FdUJ?=
 =?us-ascii?Q?6TTnHCWJ+O9wHFDuhf9QANCLiHqUdSGndDjbfz3741fCX48JaXYj7UUIQc6p?=
 =?us-ascii?Q?ypvPATUeLzSCPbvy9L/XWZjjhnzavXZ1Z9PBjGIhaRwFZPlMb82k33YGkHKq?=
 =?us-ascii?Q?2+U7lQ7hURWPGXcQ01pE64o2qpz14UmmflE+sRE1E1kdtz2+uI5tXxGc+R8N?=
 =?us-ascii?Q?iPyVwVEuWN6NUOJsR1eAJgiT8P96se0eYjUhvYHYNs6EofMUPysonwT+8n3x?=
 =?us-ascii?Q?Gvc0QlLQXWmKg9/dZg9qGP0WtdkCA/V8e/6bCDaRy1A1MhGVYwxU8OtDlf3g?=
 =?us-ascii?Q?kqbMD2HYmo+SKoGM+g8HIRQnda4UH8Nd1GzpgiLwL0s7QEs0f7GE6kpqQ8t5?=
 =?us-ascii?Q?1kesb9Xy14q5OTmULmIeO23ddHJQK+oW6+TdQ8ufGHTEcDHfM5Z8bqGhODKr?=
 =?us-ascii?Q?4zAhvpWAcuxjRfUR2kHkjSKhPc5lATnIThKDaLv9t5K6RIm1vUwBVe1D9XZW?=
 =?us-ascii?Q?hnMaRaw9iRkm8l+6I0aEgwnzpJt2T9zYvX/qkQa2/mU63PbboBn73T0vHE9E?=
 =?us-ascii?Q?gHVrpYCJWP03adp6hHGpVVLPeU/03OXlugqGT7l6N2g/43+eZhpXzEDXRaQa?=
 =?us-ascii?Q?9V6LCV9umSTwO5X3RbeuZZ1R29zJ+XkduAL1abX3eNkHpKRn9fQ0XtNbBFpV?=
 =?us-ascii?Q?MgInsIaFhjGPV8hkAdAES6qICE1OA158mzEomme0bzQVK/zLMGSHIFUmSyBd?=
 =?us-ascii?Q?EjeeZwBOrECVBwQj6og+beYXd4hO75C4/qDJrC8VXu31KmOMrXE62tJIX/UV?=
 =?us-ascii?Q?sw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?p/Xp9Wu3NkhwSIt7FX/YVQRG6VGRsKfBlBC+Q20xgiQFpX22boxVoi5KDusT?=
 =?us-ascii?Q?WNVAm391qkuO3Y4AnnQoflZKLlu6buoi+bHCAlo+qPmy2tdRJYUsjZgdWcHy?=
 =?us-ascii?Q?nA1vsvfcvzOxp6Yl4QzB4Lzy+H/f6jOnATE4ZRQZEfLeN8tknQR4TjrnihjJ?=
 =?us-ascii?Q?PjGuT8iW6XZm5cX72vaN3hSCfr9+nV+DVfuUfRvmUwdW78f7ZBbpi7he32oV?=
 =?us-ascii?Q?rNksKSv6S75f5t7GRAoAojwdtGvvOWOrcrukEGZ3NF/mAdyWXiWNIIsoajJ3?=
 =?us-ascii?Q?7AWNAjieQte+YrYIZ1f6jWenA1wRsWWYNOPQRAw+fUBGi8zJX3wjIoOg5Ys6?=
 =?us-ascii?Q?XS0hu5zuaUOTmkHFC6oepd418HD53HJqKN5NfA5A0Yv3YYN3CsYw4ztsgEFF?=
 =?us-ascii?Q?yBKHqcG4w/Szyte3idyBkg10rgWjlRd6Ky0tO39PQjAvOMwlRcCyUKQHcNtY?=
 =?us-ascii?Q?FpqWtrlzxNlgDBNf8GprtAQ3VUXyy4O5sdO8WUvs+Rr258N3WP1Er7uBjSLc?=
 =?us-ascii?Q?dlx14llEo1TBfZJJwb8L6NmhURiALGd/GNG8zKGjC2T1CZT+AJnNdDeU92TB?=
 =?us-ascii?Q?DgMiPNcdzi6rpZGW+X5612bXJdq2lbRxb6c4JHz2hURq9kHZ5hg4+59v4J0G?=
 =?us-ascii?Q?xDeWPCiMmMS1B2uUmbbq8M11SHaAweSn0pP4HryMFmjqTPon1v+pfRuOcHZC?=
 =?us-ascii?Q?FNN/IkqLD8Sq7zeMXfBdGO0Wsf7877fhp5YvMZfAIzPccXw6VpVxgzMzhor3?=
 =?us-ascii?Q?u8/qLS3ZQEpQH6KzasIMOs968deY4ByDPHmZRYH89Xjh/dFU7STp/FDGE2jr?=
 =?us-ascii?Q?IQTXg3j8PSGDI/9hAcko9ckVGe4QfOthN9bbhyMtRxfAReTRoods2IIgCE/H?=
 =?us-ascii?Q?GPme7E82P6WK/eV/zqFrAUfSrpiFHITNKgrhzQ8DDThixqkGQ13+am75PXy3?=
 =?us-ascii?Q?XuxTY+HI8O8WJJBosdh6olBg5JjbudZDoGeysKWwxC5YNYTfJYOYbblOvevn?=
 =?us-ascii?Q?CLq5s4t06j6HdAWYOyWqX2aExCHTdsjinYPwNMCEwH5qt8OB8XO1/O1h4kHm?=
 =?us-ascii?Q?Y9I9Cwsv1PHixp33ihbsuV1nd7DU8bD1hzw0EKvZWXiRVWeb6UJhXTBJmq/q?=
 =?us-ascii?Q?GtN8AtrZSdyham4zRIhRwskLGC43RM8aXYLCzbozIXUShIgwddiNJ5M=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40a14786-f9bd-4ee8-2c82-08dac5e7574f
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 02:24:23.6310
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N66tDdvbeWFue0UZP4BFWFtxOswNUKCKDf7712cjuoQqfSv39HbFxvap3Rew7LSqT5sXomlypuUrI6mpGHePQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4548
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-14_02,2022-11-11_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 mlxscore=0
 malwarescore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211140015
X-Proofpoint-ORIG-GUID: WhH3wp_wmjOk9xd0LyPjBAorbn1dmKxx
X-Proofpoint-GUID: WhH3wp_wmjOk9xd0LyPjBAorbn1dmKxx
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/13/22 10:50, Mike Kravetz wrote:
> On 11/13/22 16:36, Dmitry Vyukov wrote:
> > On Sat, 12 Nov 2022 at 15:03, syzbot
> > <syzbot+d07c65298d2c15eafcb0@syzkaller.appspotmail.com> wrote:
> > >
> > > Hello,
> > >
> > > syzbot found the following issue on:
> > >
> > > HEAD commit:    1621b6eaebf7 Merge branch 'for-next/fixes' into for-kernelci
> > > git tree:       git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci
> > > console output: https://syzkaller.appspot.com/x/log.txt?x=13bd511e880000
> > > kernel config:  https://syzkaller.appspot.com/x/.config?x=606e57fd25c5c6cc
> > > dashboard link: https://syzkaller.appspot.com/bug?extid=d07c65298d2c15eafcb0
> > > compiler:       Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
> > > userspace arch: arm64
> > > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=13315856880000
> > > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=173614d1880000
> > >
> > > Downloadable assets:
> > > disk image: https://storage.googleapis.com/syzbot-assets/82aa7741098d/disk-1621b6ea.raw.xz
> > > vmlinux: https://storage.googleapis.com/syzbot-assets/f6be08c4e4c2/vmlinux-1621b6ea.xz
> > > kernel image: https://storage.googleapis.com/syzbot-assets/296b6946258a/Image-1621b6ea.gz.xz
> > >
> > > IMPORTANT: if you fix the issue, please add the following tag to the commit:
> > > Reported-by: syzbot+d07c65298d2c15eafcb0@syzkaller.appspotmail.com
> > 
> > This may have the same root cause as:
> > 
> > possible deadlock in hugetlb_fault
> > https://lore.kernel.org/all/CACT4Y+ZWNV6ApzEv0UrsF2T8JWmXez_-H-EGMii-S_2JbXv07Q@mail.gmail.com/
> > 
> > and there is a potential explanation as to what may be the problem.
> 
> Thanks Dmitry!
> 
> An issue with this new hugetlb locking was previously reported and I have been
> working on a solution.  When I look at the reproducer, I see that it is calling
> madvise(MADV_DONTNEED).  This triggers the other issue and could certainly
> cause the issue reported here.
> 
> Proposed patches are here and in next-20221111:
> https://lore.kernel.org/linux-mm/20221111232628.290160-1-mike.kravetz@oracle.com/
> 
> I am currently trying to run the reproducer, but it is not reproducing quickly.
> Since this is a timing issue that as expected.  Interesting that this
> report is run on arm64 and I am trying to reproduce on x86.  Although, the
> issue is not architecture specific in any way.

After tweaking my config, I was able to reliably reproduce.

> I'll keep looking, but am fairly confident this is the root cause.

I was also able to verify the series above addresses the issue.

-- 
Mike Kravetz