Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: QiUTB8wj25i6XVeNBv3njFXR/DLcSPHamnvs2gzNGKneI5RdD5xdxjylcOW/qiSaKfLVDRz/H2
 YKGNum02Qsa6IFOl5YM01qNnLMHIFRRYtL3vXMHCbEu9I8ALalIFCMxNd193ItCCad1l7weNuU
 gK+rQFjDp3PcfHr6Wkrx7rJuuwllq7JqCHBNuxS9/Zzcck9TUHminLBbkFTNSaCm8Jb5lGmAMx
 Plzk+jdpnFxtcxI5xZZU24WGFrwgtGyERtFkV+HO0vyuVwqPGltF+kxz2nKoawW75oa+xyUD93
 q9c=
IronPort-SDR: +M1AIs+hUngks7B+F5jVQ4eDKslap67VGhYqgqg87uazssgCrdYMjObH68mI4PfzPB8jE7zAD7
 PfDZ40S87jDreO9qtlTpn+WSJoUPG/lzpT11k6j8y/0m6Isp0Ulbw7MWAEQozF4EmyY0WYbcVr
 lPPNMVyiWNq43KbiSZSbsyTse9wzhDQHIfFZcIdBJdmGMtC3czqObxleBaDq6+/0FREMALCAsc
 ljnDFO0vEv/9pmoKWvs0l0Km+5RAJ9eFYMe/WQzK5e6Z7Yc0Y7L7LL0XHIUe0J/0FPNINAl4ld
 4ZA=
WDCIronportException: Internal
Message-ID: <26615b48-a20f-1db3-8dba-4de05f260d86@opensource.wdc.com>
Date:   Mon, 14 Nov 2022 11:55:41 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [RFC PATCH 0/5] scsi:scsi_debug:Add error injection for single
 lun
Content-Language: en-US
To:     dgilbert@interlog.com, Wenchao Hao <haowenchao@huawei.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221109155950.3536976-1-haowenchao@huawei.com>
 <58472d12-c1e4-59f3-bb37-a98db17ef2ba@interlog.com>
 <50e1411a-54c4-d9d2-7567-2388219c5bb1@opensource.wdc.com>
 <c9106b58-677b-31e3-5c4e-5cbef5b1fe63@interlog.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <c9106b58-677b-31e3-5c4e-5cbef5b1fe63@interlog.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/14/22 11:54, Douglas Gilbert wrote:
> On 2022-11-13 19:30, Damien Le Moal wrote:
>> On 11/14/22 06:48, Douglas Gilbert wrote:
>>> On 2022-11-09 10:59, Wenchao Hao wrote:
>>>> The original error injection mechanism was based on scsi_host which
>>>> could not inject fault for a single SCSI device.
>>>>
>>>> This patchset provides the ability to inject errors for a single
>>>> SCSI device. Now we supports inject timeout errors, queuecommand
>>>> errors, and hostbyte, driverbyte, statusbyte, and sense data for
>>>> specific SCSI Command
>>>>
>>>> The first patch add an sysfs interface to add and inquiry single
>>>> device's error injection info; the second patch defined how to remove
>>>> an injection which has been added. The following 3 patches use the
>>>> injection info and generate the related error type.
>>>>
>>>> Wenchao Hao (5):
>>>>     scsi:scsi_debug: Add sysfs interface to manager single devices' error inject
>>>>     scsi:scsi_debug: Add interface to remove injection which has been added
>>>>     scsi:scsi_debug: make command timeout if timeout error is injected
>>>>     scsi:scsi_debug: Return failed value for specific command's queuecommand
>>>>     scsi:scsi_debug: fail specific scsi command with result and sense data
>>>>
>>>>    drivers/scsi/scsi_debug.c | 295 ++++++++++++++++++++++++++++++++++++++
>>>>    1 file changed, 295 insertions(+)
>>>
>>> Hi,
>>> This patchset seems to assume all scsi_debug devices will be disk (-like) SCSI
>>> devices. That leaves out other device types: tapes, enclosures, WLUNs, etc.
>>>
>>> Have you considered putting these device specific additions under:
>>>      /sys/class/scsi_device/<hctl>/device/error_inject/
>>> instead of
>>>      /sys/block/sdb/device/error_inject/
>>
>> But these are the same, no ?
>> At least on my Fedora box, I see:
>>
>> /sys/block/sdp/device/ being
>> /sys/devices/pseudo_0/adapter0/host19/target19:0:0/19:0:0:0
>>
>> and /sys/class/scsi_device/19:0:0:0/device being
>> /sys/devices/pseudo_0/adapter0/host19/target19:0:0/19:0:0:0
> 
> Well the patch descriptions are all in terms of /sys/block/sd<letter>/
> which will not exist if scsi_debug is called like this:
>    $ modprobe scsi_debug ptype=1
> 
> That creates a pseudo host with an attached (virtual) tape drive. If
> the patchset works for other peripheral device types (i.e. that don't
> use the sd driver) then the description should at least mention the
> more general case (i.e. /sys/class/scsi_device/<hctl>/device ) IMO.

Got it.

> 
> Doug Gilbert
> 

-- 
Damien Le Moal
Western Digital Research