Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933312AbXHHN3i (ORCPT ); Wed, 8 Aug 2007 09:29:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757432AbXHHN3a (ORCPT ); Wed, 8 Aug 2007 09:29:30 -0400 Received: from one.firstfloor.org ([213.235.205.2]:59043 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761113AbXHHN33 (ORCPT ); Wed, 8 Aug 2007 09:29:29 -0400 Date: Wed, 8 Aug 2007 15:29:26 +0200 From: Andi Kleen To: Steven Rostedt Cc: Andi Kleen , Glauber de Oliveira Costa , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, rusty@rustcorp.com.au, mingo@elte.hu, chrisw@sous-sol.org, jeremy@goop.org, avi@qumranet.com, anthony@codemonkey.ws, virtualization@lists.linux-foundation.org, lguest@ozlabs.org Subject: Re: [PATCH 18/25] [PATCH] turn priviled operations into macros in entry.S Message-ID: <20070808132926.GC14419@one.firstfloor.org> References: <11865467522495-git-send-email-gcosta@redhat.com> <200708081138.23018.ak@suse.de> <200708081424.49896.ak@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1250 Lines: 33 > When I said "this part of the code I don't fully understand" I was not > talking about entry.S. I understand entry.S very well, but the comment > was originally on the paranoid_restore code. Which I thought had to deal > with NMIs and such that I didn't worry about that I simply did the > default. The paranoid path is used for more than just NMIs; it's also used for MCEs, stack faults, double faults or debug exceptions. Anything that might happen with a invalid stack or unknown GS state or system in other unknown state. If you can guarantee your hypervisor never injects any of those it could be ignored; but at least losing debug exceptions would be probably not nice. > > >> paranoid_restore\trace: > >> RESTORE_ALL 8 > >> - iretq > >> + INTERRUPT_RETURN > > > >I suspect Xen will need much more changes anyways because of its > >ring 3 guest. Are these changes sufficient for lguest? This was really a general comment not especially applying to the paranoid path. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/