Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5169521rwb; Sun, 13 Nov 2022 23:35:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf55axUNqaqeI1u0HNX78Q0V2u4TQ+UUb2VDtFBqjpwXwkzyYx9P+7HrFA+f+gRcNJ8LTrZy X-Received: by 2002:a17:906:af5a:b0:7ae:4a7d:813b with SMTP id ly26-20020a170906af5a00b007ae4a7d813bmr8804082ejb.573.1668411327622; Sun, 13 Nov 2022 23:35:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668411327; cv=none; d=google.com; s=arc-20160816; b=sDZNwfTOZfb5CjwaM8qY6srRyfKcHwPyVBN5yoG5STB7nJAEpWSEScDbqImjw4z0cg OUEjLYulJeF+HRhmATjVl32Ae1KyDtkngkBajanDHXEJVvUinJ0AogRp6cpQ2yEij5wC dtmilnc9H3UAv1Ao3E4fMzGmiQhD4ZpwftXY9esUFy8ATA3emc/wsvOxfH754V7UJkVD /N1LTJh/ZpEYSjjtM0Ks6w8GZIyXIIuQxNS+/xaRXlLv+G5FDu8ujrIqDvtPtoyitYv6 ld2YjJMDlEuGdQt352EEwNjXms/DgYlJVNtxm99kUx232wYVn7VAn7ZTEZsuO2h72OhH ULuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=m33Pn0dcHalEOk+euJ8g61goSUJVIuLu2GvtjKpHk8o=; b=iA4V+f1HH4ZlwGdFBz0ujceZG0C9T+QVH/sNABoNkNu4JWvlp1oHh0Mx4lDR6ff227 enaQjCKh/BlQgfasEasUfHTz+9opD8ElRbpg7ChbhXCuJOhf3oDy6mdqhlgWAh0K/SMl qyDw3kdc6riCpHL0xGaf6cK+6GsbSMsWOb96vnfZkx59DiFtOUQMYTXfE2/Cb6lXAnMD 1axIkHUAOBtVgv95sAsrQG742ibBlnW1YjFrB//K/1eH5NjIeKtWORUDdnN/LCGCx02x 3bFMJNEY49+hbP+aM6/KVCPIjK1IAlGAwK/jVYQDLX/sUBMRKGVRgT3WH0nDIIdfq5Ta btFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=yvVmSS7f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u1-20020a1709064ac100b007ae75e99fffsi5816825ejt.487.2022.11.13.23.35.06; Sun, 13 Nov 2022 23:35:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=yvVmSS7f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235930AbiKNHUC (ORCPT + 88 others); Mon, 14 Nov 2022 02:20:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235819AbiKNHUA (ORCPT ); Mon, 14 Nov 2022 02:20:00 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31D521F8 for ; Sun, 13 Nov 2022 23:20:00 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CCAEF60ED2 for ; Mon, 14 Nov 2022 07:19:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B63CC433C1; Mon, 14 Nov 2022 07:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1668410399; bh=PRMT7kECNZoMA7eX2WsddsDL98klDYjZ2EvzH7BYzSQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yvVmSS7fpiHrsezj/H3NMRpqaxHEoW97AIry0hGFuH5x92Jqk/cbSlBCzNmP4jVL5 jImJ+iwicTFgPdO/qn8tkbjTpfNTOjVPleOaTmln3f30h+ebvf/PHU354F2yGgCyS7 eHHMGnsnB3Qyl+amSPWwvr5k7L57ExiWzlOeys5g= Date: Mon, 14 Nov 2022 08:19:56 +0100 From: Greg KH To: Zhengchao Shao Cc: linux-kernel@vger.kernel.org, jirislaby@kernel.org, akpm@linux-foundation.org, paulkf@microgate.com, weiyongjun1@huawei.com, yuehaibing@huawei.com Subject: Re: [PATCH] tty: synclink_gt: release resources when synclink_gt driver open failed Message-ID: References: <20221114010734.314910-1-shaozhengchao@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221114010734.314910-1-shaozhengchao@huawei.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 14, 2022 at 09:07:34AM +0800, Zhengchao Shao wrote: > When synclink_gt driver open failed, it doesn't release resources. Compile > tested only. How was this found? Please always provide the proper required information about stuff like this as our documentation requires. thanks, greg k-h