Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5176330rwb; Sun, 13 Nov 2022 23:46:02 -0800 (PST) X-Google-Smtp-Source: AA0mqf4dXsQLQo+th+zyiV+TuKO6ltJgmyU2DDHHUrgiZ+oPZ/pjC5rG2INcuoSo4vSZv8YY1QjG X-Received: by 2002:a17:906:7143:b0:78c:f5a1:86bf with SMTP id z3-20020a170906714300b0078cf5a186bfmr9169014ejj.245.1668411962094; Sun, 13 Nov 2022 23:46:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668411962; cv=none; d=google.com; s=arc-20160816; b=bKON0CEMctBmSwgwb0iokcpInwTnJeT3iFzBTe9dRt/13UcGQaJgOW/UwtwRoFq0HT 7X8OyJGXXd5B+YkqwVEmVvYk+houhdCLcVCuEUJb+efn+ApG3JhjfwMwGTz8XT3IXhLj CDFhx/x63cV+IDm4JFLd4Y8j+VLdKZAM0EU/j1Ge62Di1h3j0sPFJ6YpupolrSpXY41E LcQi5n963LDQTXyV71Ebz8iHqO4XxTKFk0e/13rpr2Jad1VCgQFTdgEQ003aJN+SWK7V bFX7TUP3Y63ZGXojBoVnYWSMNUHGZ3c1O8nMr+LgCsAZUmb074fyoqGtUCvziwGC7GTw O6EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=KXz6ld+3kTxPSSYyFuR175o0LcKYCqmL723g/hyfaCw=; b=m8hVTMSlSP74VpVqwGOWh5heS7clR397leJeATXnDGwloKwb9D/gcw1RjVjuUaTGiM B2MK/E6M2sNg6RYinSuAt8RTusT6IMez55Kiv07XnpB4c68jCcs/KhkefEMkH1mdCxJQ P5x3lOPGUm6NPNXW8wsCNfbl23dCspti1Vwpk0K47I1Qj2rtyJxlCWOkMfXm2Lz6Sbkm 5NlUTeKwaZasTPt2Mx2jTc/LbL1ROwGCoLxQsYZnTbdqo7Bwjn87olTG74LDrArp47/4 rdrPFqTbBBR+nlkO60pvxThxAW7e2LrtOkuA1BiDc+ROaP9pwGChEbYEpMUws4zq7TPC t0nQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=JdW6pBag; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q11-20020a1709060f8b00b0078261fd56efsi6598530ejj.571.2022.11.13.23.45.40; Sun, 13 Nov 2022 23:46:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=JdW6pBag; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235935AbiKNHYR (ORCPT + 89 others); Mon, 14 Nov 2022 02:24:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235493AbiKNHYP (ORCPT ); Mon, 14 Nov 2022 02:24:15 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB78E6347 for ; Sun, 13 Nov 2022 23:24:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 97F8CB80D1C for ; Mon, 14 Nov 2022 07:24:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE129C433D6; Mon, 14 Nov 2022 07:24:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1668410652; bh=KXz6ld+3kTxPSSYyFuR175o0LcKYCqmL723g/hyfaCw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JdW6pBagwtPiOf5F0zbXlRVhY+hwq3kZ9Mck1JCKkEbtQbrVeSlxddBgxELpe4aXC X2qvf1R5YUe/n20z0EjFbiXLOgsH+XCF0D6TZs0bgXhR7qgEYY527TF1pc1gByXPTg dwlrhB4eF1Dk6aEQa1EPSDNV9uACVvDzSMmuYBK8= Date: Mon, 14 Nov 2022 08:24:09 +0100 From: Greg KH To: Gaosheng Cui Cc: dinguyen@kernel.org, richard.gong@intel.com, atull@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: stratix10-svc: Fix IS_ERR() vs NULL check in stratix10_svc_drv_probe() Message-ID: References: <20221114025921.1194834-1-cuigaosheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221114025921.1194834-1-cuigaosheng1@huawei.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 14, 2022 at 10:59:21AM +0800, Gaosheng Cui wrote: > The svc_create_memory_pool() returns an ERR_PTR() on failure, we should use > IS_ERR() to check the return value, and return it on failure. How was this found and tested? thanks, greg k-h