Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Chiang, Mac" <mac.chiang@intel.com>
To:     Ajye Huang <ajye_huang@compal.corp-partner.google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Mark Brown <broonie@kernel.org>,
        "Rojewski, Cezary" <cezary.rojewski@intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Jaroslav Kysela <perex@perex.cz>,
        "Takashi Iwai" <tiwai@suse.com>, "Lu, Brent" <brent.lu@intel.com>,
        "Zhi, Yong" <yong.zhi@intel.com>,
        ye xingchen <ye.xingchen@zte.com.cn>,
        "Gopal, Vamshi Krishna" <vamshi.krishna.gopal@intel.com>,
        "Reddy, Muralidhar" <muralidhar.reddy@intel.com>,
        "Yang, Libin" <libin.yang@intel.com>,
        "Lin, Chien-Ta" <ctlin0@nuvoton.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: RE: [PATCH v1 1/2] ASoC: Intel: sof_rt5682: add support for
 ALC5682I-VD with amp rt1019p
Thread-Topic: [PATCH v1 1/2] ASoC: Intel: sof_rt5682: add support for
 ALC5682I-VD with amp rt1019p
Thread-Index: AQHY8ypxoqRQYPxb406qxD+wLCJfG64+DPCw
Date:   Mon, 14 Nov 2022 07:36:54 +0000
Message-ID: <PH0PR11MB58329B470ABC721F95EAC6EA84059@PH0PR11MB5832.namprd11.prod.outlook.com>
References: <20221108042716.2930255-1-ajye_huang@compal.corp-partner.google.com>
 <20221108042716.2930255-2-ajye_huang@compal.corp-partner.google.com>
In-Reply-To: <20221108042716.2930255-2-ajye_huang@compal.corp-partner.google.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5ore8NLPaM7XtEc/iOsRYVRV1XW1oMpitMAbOp0akgHx1Fj3bUq0+HKMJIzn?=
 =?us-ascii?Q?qd3KVUsQ94bDsTP/+Rhon2bsRx57bJfEVAc++sULEt2rLvrQaTmPE3I8O0qH?=
 =?us-ascii?Q?42WkOzGui/05z8rdNIHqxIu2/p2oLay0H+aPIBP1gpGqxkXgq6cxAQW3wySQ?=
 =?us-ascii?Q?NN187O40vDz981PZlyUddTN6JG5MG/3Z7A31KYyezST6JKzeVdA8ofKC2dXZ?=
 =?us-ascii?Q?IksanfgWP+o2vAzOmjeuJYmjU1tOTjTQDBxTm+z32Al6qcNdtiTurRzuzWRT?=
 =?us-ascii?Q?bdiclF5FDI3NiLrhNuAOdhXgjkxppIx8GqwYUf3/gbDJMXTusRO/Vuu9Ie2r?=
 =?us-ascii?Q?Rd0TSKfQxatbI6RmDYh7vMui4ILSvHTMuJhD99IK9H5WaN1t4LUFjqbY80jM?=
 =?us-ascii?Q?5dpsgh7YdOzIVgXAbnYIY3ULp/09unclXi9Bor8VSGLqcPw2d2hUcqLh8MpP?=
 =?us-ascii?Q?z1u2JLYagyvGVKCRUlnULIGxzgNb6+Or30U7VLm0oqTCB5D/yrv5wtYEPQOU?=
 =?us-ascii?Q?B/l+C/mVfntOWz4SGJz/6fpdc0tOREjOu9YDcXDd7zhLsjof1zYm7vAR37iX?=
 =?us-ascii?Q?h4IQ6xvc1HoW70Lb1IjOhKnZE6mhStUvNY1JwMHoVHekMdC6+0+F5zYa+RaO?=
 =?us-ascii?Q?shD/zWU1JbQZhBmL6f40GD6V6PvjCN+FYKRYCs5zQdT+9kDv5Ycnnl7t7CEt?=
 =?us-ascii?Q?RxPPuoQ2O458/SKsYdiKcM8Hr93P6xp3TeLyIJ9+XJtdwL8l24IevURghzVw?=
 =?us-ascii?Q?BuipQrG3FheVRItouTZneDrJl/H1SnJGh1adTCNwqt9n7FTA+aHTOlv8TxT9?=
 =?us-ascii?Q?RzytNwoyTr52Zx6AFZzjwdEQS4Jq/aCzYF26hUkJWyEzO7XxZCGCrJAQUPxY?=
 =?us-ascii?Q?js46d+UDZ3xzsF8tIPO7FLk+s6hjNr7ibl3M0DRezh89c8Wh+Ytzzy09qI0m?=
 =?us-ascii?Q?Pffy/8GZWIVUSEP63Zgr51+Zv0wlt8BeVt3Mwe16q56myoR2I73p9BYRqWmd?=
 =?us-ascii?Q?jFKuRi398/vmD5lrwh0a/p/XCNn5P8iSi6dgtQ8/J/1OchNY+VwC1KqaeWmq?=
 =?us-ascii?Q?0f8OZpojjSfx5TejdkVv3aO8e9bGtmXnLWBYwOmOImXqRNBf07NItClhXLHa?=
 =?us-ascii?Q?S7v4asBLGLwUPLUj3UVCHCQxEJIWvN4GYgI1ajvMBhPXPDgt/k2LZOM+MqeK?=
 =?us-ascii?Q?lmszyfcuF668VnoewmTvO77AWDk5o68ZuVe3G3YHppDKIrIU2DAIi4PNsTmd?=
 =?us-ascii?Q?XUQPoHA0trbzIsroRb4uS0kI0ZFHoL35L+IiPAhoeJF/82b92Bee8niYoMwm?=
 =?us-ascii?Q?xiou0KcukJ0tP/t3HlKnkNiOdyBhBa3nA+eyqNr9xW77fIkGPQqNBW9eBhXG?=
 =?us-ascii?Q?1ydK7lwxG7Q+FBuDUznkEHUjcqVgTTCblT1PARNxXAnkmsSmTNz98lq0e4RL?=
 =?us-ascii?Q?PABVvWudDXs+thJiafeOTV6WVSwvPF1MNuHmn7D7lNGiyN8CIwkYNWIKse22?=
 =?us-ascii?Q?TLBhfQJtsNkZJSwzfuaI5A+h016oto9kjHIJ0rB6e9vq3yq6V2d8RRcX58ax?=
 =?us-ascii?Q?54G5dX6IcUA/M6luw5sERJ4E5BXkFCFjNYc4yZmE?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88278201-ec31-478a-8f30-08dac61300bd
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 07:36:54.5291
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: s5Zi1es0v5Zjm/jOBHu9TKAgxZsvDNKiQnAzqvNAGr5Nw7/LXl97QMAER5kwyhg65s2EccSAuYH8rhIw7/asuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5222
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

As per discussed with Ajye, the board co-layouts 5682VS and 5682VD and veri=
fied.
Hi Pierre, could we have your reviews?

> This patch adds the driver data for two rt1019 speaker amplifiers on
> SSP1 and ALC5682I-VD on SSP0 for ADL platform.
>=20
> Signed-off-by: Ajye Huang <ajye_huang@compal.corp-partner.google.com>
> ---
>  sound/soc/intel/boards/sof_rt5682.c               | 3 +--
>  sound/soc/intel/common/soc-acpi-intel-adl-match.c | 4 ++--
>  2 files changed, 3 insertions(+), 4 deletions(-)
>=20
> diff --git a/sound/soc/intel/boards/sof_rt5682.c
> b/sound/soc/intel/boards/sof_rt5682.c
> index 2358be208c1f..0e803c1c2b06 100644
> --- a/sound/soc/intel/boards/sof_rt5682.c
> +++ b/sound/soc/intel/boards/sof_rt5682.c
> @@ -1092,10 +1092,9 @@ static const struct platform_device_id board_ids[]=
 =3D
> {
>  					SOF_SSP_BT_OFFLOAD_PRESENT),
>  	},
>  	{
> -		.name =3D "adl_rt1019_rt5682s",
> +		.name =3D "adl_rt1019_rt5682",
>  		.driver_data =3D (kernel_ulong_t)(SOF_RT5682_MCLK_EN |
>  					SOF_RT5682_SSP_CODEC(0) |
> -
> 	SOF_RT5682S_HEADPHONE_CODEC_PRESENT |
>  					SOF_SPEAKER_AMP_PRESENT |
>  					SOF_RT1019_SPEAKER_AMP_PRESENT
> |
>  					SOF_RT5682_SSP_AMP(1) |
> diff --git a/sound/soc/intel/common/soc-acpi-intel-adl-match.c
> b/sound/soc/intel/common/soc-acpi-intel-adl-match.c
> index 9990d5502d26..3ca0a96d94de 100644
> --- a/sound/soc/intel/common/soc-acpi-intel-adl-match.c
> +++ b/sound/soc/intel/common/soc-acpi-intel-adl-match.c
> @@ -489,8 +489,8 @@ struct snd_soc_acpi_mach
> snd_soc_acpi_intel_adl_machines[] =3D {
>  		.sof_tplg_filename =3D "sof-adl-max98360a-nau8825.tplg",
>  	},
>  	{
> -		.id =3D "RTL5682",
> -		.drv_name =3D "adl_rt1019_rt5682s",
> +		.comp_ids =3D &adl_rt5682_rt5682s_hp,
> +		.drv_name =3D "adl_rt1019_rt5682",
>  		.machine_quirk =3D snd_soc_acpi_codec_list,
>  		.quirk_data =3D &adl_rt1019p_amp,
>  		.sof_tplg_filename =3D "sof-adl-rt1019-rt5682.tplg",
> --
> 2.25.1