Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Nov 2022 09:26:24 +0100
Message-ID: <87r0y63psf.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Daniil Tatianin <d-tatianin@yandex-team.ru>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Tim Crawford <tcrawford@system76.com>,
        Stefan Binding <sbinding@opensource.cirrus.com>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Meng Tang <tangmeng@uniontech.com>,
        Lucas Tanure <tanureal@opensource.cirrus.com>,
        Philipp Jungkamp <p.jungkamp@gmx.net>,
        Werner Sembach <wse@tuxedocomputers.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        lvc-project@linuxtesting.org, yc-core@yandex-team.ru
Subject: Re: [PATCH v1] sound/pci/hda/patch_realtek: don't call alc_shutup_pins without a spec
In-Reply-To: <20221114082048.3477027-1-d-tatianin@yandex-team.ru>
References: <20221114082048.3477027-1-d-tatianin@yandex-team.ru>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 14 Nov 2022 09:20:48 +0100,
Daniil Tatianin wrote:
> 
> alc_shutup_pins always expects the spec to be present, so make sure
> it is before we call it.
> 
> Found by Linux Verification Center (linuxtesting.org) with the SVACE
> static analysis tool.
> 
> Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>

In which path can it be without spec assigned?
That's the internal callback that is set only by the codec driver
where the allocation of codec->spec is mandatory.


thanks,

Takashi


> ---
>  sound/pci/hda/patch_realtek.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 60e3bc124836..2cf4b64971d7 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -939,10 +939,12 @@ static inline void alc_shutup(struct hda_codec *codec)
>  {
>  	struct alc_spec *spec = codec->spec;
>  
> +	if (!spec)
> +		return;
>  	if (!snd_hda_get_bool_hint(codec, "shutup"))
>  		return; /* disabled explicitly by hints */
>  
> -	if (spec && spec->shutup)
> +	if (spec->shutup)
>  		spec->shutup(codec);
>  	else
>  		alc_shutup_pins(codec);
> -- 
> 2.25.1
>