Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b39171e6-4af3-6102-2207-aad57dc92226@linux.intel.com>
Date:   Mon, 14 Nov 2022 16:35:35 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [RFC PATCH v2 3/6] perf vendor events arm64: Add cache metrics
 for neoverse-n2
To:     Jing Zhang <renyu.zj@linux.alibaba.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        John Garry <john.garry@huawei.com>,
        Will Deacon <will@kernel.org>,
        James Clark <james.clark@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Andrew Kilroy <andrew.kilroy@arm.com>,
        Shuai Xue <xueshuai@linux.alibaba.com>,
        Zhuo Song <zhuo.song@linux.alibaba.com>
References: <1668411720-3581-1-git-send-email-renyu.zj@linux.alibaba.com>
 <1668411720-3581-4-git-send-email-renyu.zj@linux.alibaba.com>
Content-Language: en-US
From:   Xing Zhengjun <zhengjun.xing@linux.intel.com>
In-Reply-To: <1668411720-3581-4-git-send-email-renyu.zj@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/14/2022 3:41 PM, Jing Zhang wrote:
> Add cache related metrics.
> 
> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
> ---
>   .../arch/arm64/arm/neoverse-n2/metrics.json        | 77 ++++++++++++++++++++++
>   1 file changed, 77 insertions(+)
> 
> diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json
> index 324ca12..1690ef6 100644
> --- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json
> +++ b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json
> @@ -54,5 +54,82 @@
>           "BriefDescription": "The rate of DTLB Walks to the overall TLB lookups",
>           "MetricGroup": "TLB",
>           "MetricName": "dtlb_walk_rate"
> +    },
> +    {
> +        "MetricExpr": "L1I_CACHE_REFILL / INST_RETIRED * 1000",
> +        "PublicDescription": "The rate of L1 I-Cache misses per kilo instructions",
> +        "BriefDescription": "The rate of L1 I-Cache misses per kilo instructions",
> +        "MetricGroup": "Cache",
> +        "MetricName": "l1i_cache_mpki"
> +    },
> +    {
> +        "MetricExpr": "L1I_CACHE_REFILL / L1I_CACHE",
> +        "PublicDescription": "The rate of L1 I-Cache misses to the overall L1 I-Cache",
> +        "BriefDescription": "The rate of L1 I-Cache misses to the overall L1 I-Cache",
> +        "MetricGroup": "Cache",
> +        "MetricName": "l1i_cache_miss_rate"
> +    },
> +    {
> +        "MetricExpr": "L1D_CACHE_REFILL / INST_RETIRED * 1000",
> +        "PublicDescription": "The rate of L1 D-Cache misses per kilo instructions",
> +        "BriefDescription": "The rate of L1 D-Cache misses per kilo instructions",
> +        "MetricGroup": "Cache",
> +        "MetricName": "l1d_cache_mpki"
> +    },
> +    {
> +        "MetricExpr": "L1D_CACHE_REFILL / L1D_CACHE",
> +        "PublicDescription": "The rate of L1 D-Cache misses to the overall L1 D-Cache",
> +        "BriefDescription": "The rate of L1 D-Cache misses to the overall L1 D-Cache",
> +        "MetricGroup": "Cache",
> +        "MetricName": "l1d_cache_miss_rate"
> +    },
> +    {
> +        "MetricExpr": "L2D_CACHE_REFILL / INST_RETIRED * 1000",
> +        "PublicDescription": "The rate of L2 D-Cache misses per kilo instructions",
> +        "BriefDescription": "The rate of L2 D-Cache misses per kilo instructions",
> +        "MetricGroup": "Cache",
> +        "MetricName": "l2d_cache_mpki"
> +    },
> +    {
> +        "MetricExpr": "L2D_CACHE_REFILL / L2D_CACHE",
> +        "PublicDescription": "The rate of L2 D-Cache misses to the overall L2 D-Cache",
> +        "BriefDescription": "The rate of L2 D-Cache misses to the overall L2 D-Cache",
> +        "MetricGroup": "Cache",
> +        "MetricName": "l2d_cache_miss_rate"
> +    },
> +    {
> +        "MetricExpr": "L3D_CACHE_REFILL / INST_RETIRED * 1000",
> +        "PublicDescription": "The rate of L3 D-Cache misses per kilo instructions",
> +        "BriefDescription": "The rate of L3 D-Cache misses per kilo instructions",
> +        "MetricGroup": "Cache",
> +        "MetricName": "l3d_cache_mpki"
> +    },
> +    {
> +        "MetricExpr": "L3D_CACHE_REFILL / L3D_CACHE",
> +        "PublicDescription": "The rate of L3 D-Cache misses to the overall L3 D-Cache",
> +        "BriefDescription": "The rate of L3 D-Cache misses to the overall L3 D-Cache",
> +        "MetricGroup": "Cache",
> +        "MetricName": "l3d_cache_miss_rate"
> +    },
> +    {
> +        "MetricExpr": "LL_CACHE_MISS_RD / INST_RETIRED * 1000",
> +        "PublicDescription": "The rate of LL Cache read misses per kilo instructions",
> +        "BriefDescription": "The rate of LL Cache read misses per kilo instructions",
> +        "MetricGroup": "Cache",
> +        "MetricName": "ll_cache_read_mpki"
> +    },
> +    {
> +        "MetricExpr": "LL_CACHE_MISS_RD / LL_CACHE_RD",
> +        "PublicDescription": "The rate of LL Cache read misses to the overall LL Cache read",
> +        "BriefDescription": "The rate of LL Cache read misses to the overall LL Cache read",
> +        "MetricGroup": "Cache",
> +        "MetricName": "ll_cache_read_miss_rate"
> +    },
> +    {
> +        "MetricExpr": "(LL_CACHE_RD - LL_CACHE_MISS_RD) / LL_CACHE_RD",
> +        "PublicDescription": "The rate of LL Cache read hit to the overall LL Cache read",
> +        "BriefDescription": "The rate of LL Cache read hit to the overall LL Cache read",
> +        "MetricGroup": "Cache",
> +        "MetricName": "ll_cache_read_hit_rate"
>       }
>   ]
> \ No newline at end of file

It is better to fix this by adding a newline at the end of the file.

-- 
Zhengjun Xing