Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Nov 2022 09:54:50 +0100
Message-ID: <87o7t9531h.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Daniil Tatianin <d-tatianin@yandex-team.ru>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Tim Crawford <tcrawford@system76.com>,
        Stefan Binding <sbinding@opensource.cirrus.com>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Meng Tang <tangmeng@uniontech.com>,
        Lucas Tanure <tanureal@opensource.cirrus.com>,
        Philipp Jungkamp <p.jungkamp@gmx.net>,
        Werner Sembach <wse@tuxedocomputers.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        lvc-project@linuxtesting.org, yc-core@yandex-team.ru
Subject: Re: [PATCH v1] sound/pci/hda/patch_realtek: don't call alc_shutup_pins without a spec
In-Reply-To: <d3a31735-8f5c-3168-6a0d-2cf1e9005864@yandex-team.ru>
References: <20221114082048.3477027-1-d-tatianin@yandex-team.ru>
        <87r0y63psf.wl-tiwai@suse.de>
        <d3a31735-8f5c-3168-6a0d-2cf1e9005864@yandex-team.ru>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 14 Nov 2022 09:35:10 +0100,
Daniil Tatianin wrote:
> 
> 
> 
> On 11/14/22 11:26 AM, Takashi Iwai wrote:
> > On Mon, 14 Nov 2022 09:20:48 +0100,
> > Daniil Tatianin wrote:
> >> 
> >> alc_shutup_pins always expects the spec to be present, so make sure
> >> it is before we call it.
> >> 
> >> Found by Linux Verification Center (linuxtesting.org) with the SVACE
> >> static analysis tool.
> >> 
> >> Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
> > 
> > In which path can it be without spec assigned?
> > That's the internal callback that is set only by the codec driver
> > where the allocation of codec->spec is mandatory.
> 
> Would you then say that the "if (spec && ...)" that was there before
> was redundant?

Yes.


Takashi