Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Arunachalam Santhanam (MS/ETA-ETAS)" 
        <Arunachalam.Santhanam@in.bosch.com>
To:     Zhang Changzhong <zhangchangzhong@huawei.com>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Wolfgang Grandegger <wg@grandegger.com>,
        "EXTERNAL Kleine-Budde Marc (Pengutronix, XC-CT/ECP2)" 
        <mkl@pengutronix.de>, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
CC:     "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] can: etas_es58x: free netdev when register_candev()
 failed in es58x_init_netdev()
Thread-Topic: [PATCH v2] can: etas_es58x: free netdev when register_candev()
 failed in es58x_init_netdev()
Thread-Index: AQHY9/5Vp33phWcsf02Yanf1AaJBUa4+FjJw
Date:   Mon, 14 Nov 2022 08:32:52 +0000
Message-ID: <AM6PR10MB232575E04F886D1B9341DD21C7059@AM6PR10MB2325.EURPRD10.PROD.OUTLOOK.COM>
References: <1668413685-23354-1-git-send-email-zhangchangzhong@huawei.com>
In-Reply-To: <1668413685-23354-1-git-send-email-zhangchangzhong@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uIK4YFWfqoEFD3JOV4Jcfn6y2DhfefgAv8YKwZ6UEYRic4j8A/w1ciqGy2++?=
 =?us-ascii?Q?vXprgBzwkFEVxM5E6l3aybZnvaX2Xna0gtMP7YllxsBtPlmPr9rZ+e03FmUA?=
 =?us-ascii?Q?5B/Y2ih9UqwODzv3LV461MlixpRcMRNrA5v0J7mF2bh1pylRppwxm3k0HPjl?=
 =?us-ascii?Q?1jJCL7xJH4E8+9xP+bIHrdJXVvCJmODo8HI1uoSvAAPNKmkCz9aD2WnExHVd?=
 =?us-ascii?Q?FQVd74fN9D2s55w5pwncaGG59lF8k03BKvgDzOZNagZ450jz3mxcAUn8cEZ2?=
 =?us-ascii?Q?DI4pv2wZ9LL8fkgQ0OHFvMMBeZfH074VHEm4KGDi7tHyLVf+SSoZrVvxOopo?=
 =?us-ascii?Q?uijVTNCNQVfoxNAZYPqfic1SCop6krMentpI4YLLuGcmjHvf3H29G7TwtFA3?=
 =?us-ascii?Q?H9CzlE1H5ydPT2BWFFkKv7RGQS3imbqZHcgtIsaV6lSCjnrZwlOnZ2tSsNnt?=
 =?us-ascii?Q?5tyHsgnMcqK8B5EO6i7zNSF+y1g2VeCHnvW+UHGxTKEO3N/rQVGFRUkSAD0h?=
 =?us-ascii?Q?69XjoF+jIL4PTfaTxAF+aW+4chSQ7NX1/EsKh0nFdsMeI8eMIcPnn8rWu4PN?=
 =?us-ascii?Q?AEhvOQ0ZKkArQvCO5vQ3x55cmfJljjx+dO/8YygxkOy85/p4brxyc3OahQ3u?=
 =?us-ascii?Q?mQ0cQ0l4/PoMUPfDWEbByhW/v/2qwyZs68cqfHhagEBYzBtsEztgJaclFQgK?=
 =?us-ascii?Q?nEAaD/eRa17M4zAI+NmXXUbjlKWmVOKvvBcsoK5hGPlEoZkASg+LOp9R7e1/?=
 =?us-ascii?Q?BkSJQGBjOrOVTNlvYmBuZjarkfJhoefNhieUE+WWssYJmTKvtJI078Z0vd19?=
 =?us-ascii?Q?UWhWt3wekVGHf7iVBJW/aHbKFPOk1NNqR42XBXFBW5qRXYr+Bt45fDcGyr5m?=
 =?us-ascii?Q?N1Hf3yVQGyvVG3NRJAF/xo22oYL0WDWSDBgazRFrezn6uC+WxIA7Zl9iRZ8D?=
 =?us-ascii?Q?/7XCw54RNpeBLCjpSqTl6xuzkYWOJ8mepmYXNrFczPzIvBHpwI/vsEBFTznF?=
 =?us-ascii?Q?t7Atie6Rv2VPl/kETNrQQhpM56LGXWQGk8CmtPfyNRKvuUP4WSUaEH/Uj0+u?=
 =?us-ascii?Q?NOLLg6UxV6OAwM4/3rsbUtE+6jhQ+l3+W+hV0HACzB9myUFaM+jXFsOZGG+j?=
 =?us-ascii?Q?Qhjnd2tElIdNGliPSXIc2rfQz9mioKUL5gA4pWDc4h84gJGubx2wfVikO6db?=
 =?us-ascii?Q?Q2Q+oU/IEJM3Be9xShRUmHcj6nw8wWq9Hl/9w+zOaI3ulTbrIAjjfs4+yPvR?=
 =?us-ascii?Q?oC6DmSdJ+pNf3u3vynq9OtfGzGjeOgIpP2WNBM9W35qpeQb+lij/5tUWyZok?=
 =?us-ascii?Q?oBCSFjk5c+TA1brk1BC1nWVSc8L9WXbnBgHT4+Y9xxDwrmbOc8ipZ/ltNXIR?=
 =?us-ascii?Q?L7KGYRtbMWVTRNW9tEmA0ccc+3WAiRuzgEBpehsMZ09XAOEdTWmUheh9Zwck?=
 =?us-ascii?Q?nhrfBJ2SVNrJCg2DuSngqxQA5xJRp1ejEsUEXLuDRhHtKXwpV8CrGzHfqkAv?=
 =?us-ascii?Q?iUuI6x0NbYXfb6V8gHtXSxSEp+x1GkQSl2WNHIgPPWkEBL9XyIMnNK5lP8R+?=
 =?us-ascii?Q?B0PWBRQeKYzUAPV8OBs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: in.bosch.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM6PR10MB2325.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 22f2b716-35a7-44c3-93ef-08dac61ad256
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 08:32:52.6216
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0ae51e19-07c8-4e4b-bb6d-648ee58410f4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RCnGI6dUo2cKKmrG/QwVoSgehpieztgrQopn4buhDod/HgGYcO3oFKhIOtjaB4eJZOKxfPJAVGV1KNjG4RtYUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB3473
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Zhang,

Thank you for the update and patch.

-----Original Message-----
From: Zhang Changzhong <zhangchangzhong@huawei.com>=20
Sent: 14 November 2022 13:45
To: Vincent Mailhol <mailhol.vincent@wanadoo.fr>; Wolfgang Grandegger <wg@g=
randegger.com>; EXTERNAL Kleine-Budde Marc (Pengutronix, XC-CT/ECP2) <mkl@p=
engutronix.de>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumaz=
et@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redha=
t.com>; Arunachalam Santhanam (MS/ETA-ETAS) <arunachalam.santhanam@in.bosch=
.com>
Cc: Zhang Changzhong <zhangchangzhong@huawei.com>; linux-can@vger.kernel.or=
g; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH v2] can: etas_es58x: free netdev when register_candev() fai=
led in es58x_init_netdev()

In case of register_candev() fails, clear es58x_dev->netdev[channel_idx] an=
d add free_candev(). Otherwise es58x_free_netdevs() will unregister the net=
dev that has never been registered.

Fixes: 8537257874e9 ("can: etas_es58x: add core support for ETAS ES58X CAN =
USB interfaces")
Signed-off-by: Zhang Changzhong <mailto:zhangchangzhong@huawei.com>
---
v1 -> v2: change to the correct 'Fixes' tag according to Vincent Mailhol

Acked-by: <arunachalam.santhanam@in.bosch.com>

 drivers/net/can/usb/etas_es58x/es58x_core.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c b/drivers/net/can/=
usb/etas_es58x/es58x_core.c
index 25f863b..ddb7c57 100644
--- a/drivers/net/can/usb/etas_es58x/es58x_core.c
+++ b/drivers/net/can/usb/etas_es58x/es58x_core.c
@@ -2091,8 +2091,11 @@ static int es58x_init_netdev(struct es58x_device *es=
58x_dev, int channel_idx)
 	netdev->dev_port =3D channel_idx;
=20
 	ret =3D register_candev(netdev);
-	if (ret)
+	if (ret) {
+		es58x_dev->netdev[channel_idx] =3D NULL;
+		free_candev(netdev);
 		return ret;
+	}
=20
 	netdev_queue_set_dql_min_limit(netdev_get_tx_queue(netdev, 0),
 				       es58x_dev->param->dql_min_limit);
--
2.9.5