From: Andi Kleen <ak@suse.de>
Organization: SUSE Linux Products GmbH, Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
To: "Glauber de Oliveira Costa" <glommer@gmail.com>
Subject: Re: [PATCH 3/25] [PATCH] irq_flags / halt routines
Date: Wed, 8 Aug 2007 16:14:52 +0200
User-Agent: KMail/1.9.6
Cc: "Glauber de Oliveira Costa" <gcosta@redhat.com>,
       linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
       rusty@rustcorp.com.au, mingo@elte.hu, chrisw@sous-sol.org,
       jeremy@goop.org, avi@qumranet.com, anthony@codemonkey.ws,
       virtualization@lists.linux-foundation.org, lguest@ozlabs.org,
       "Steven Rostedt" <rostedt@goodmis.org>
References: <11865467522495-git-send-email-gcosta@redhat.com> <200708081114.21260.ak@suse.de> <5d6222a80708080710n296f6da8i1dc08d914baeb27a@mail.gmail.com>
In-Reply-To: <5d6222a80708080710n296f6da8i1dc08d914baeb27a@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200708081614.52391.ak@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1274
Lines: 44

On Wednesday 08 August 2007 16:10:28 Glauber de Oliveira Costa wrote:
> On 8/8/07, Andi Kleen <ak@suse.de> wrote:
> >
> > > +#ifdef CONFIG_PARAVIRT
> > > +#include <asm/paravirt.h>
> > > +#  ifdef CONFIG_X86_VSMP
> > > +static inline int raw_irqs_disabled_flags(unsigned long flags)
> > > +{
> > > +     return !(flags & X86_EFLAGS_IF) || (flags & X86_EFLAGS_AC);
> > > +}
> > > +#  else
> > > +static inline int raw_irqs_disabled_flags(unsigned long flags)
> > > +{
> > > +     return !(flags & X86_EFLAGS_IF);
> > > +}
> > > +#  endif
> >
> > You should really turn the vsmp special case into a paravirt client first
> > instead of complicating all this even more.
> 
> By "client" you mean a user of the paravirt interface?

Yes

> 
> > > +#ifndef CONFIG_PARAVIRT
> > > +#define raw_safe_halt        native_raw_safe_halt
> > > +#define halt         native_halt
> > > +#endif /* ! CONFIG_PARAVIRT */
> >
> > This seems inconsistent
> Sorry andi. Can't see why. Could you elaborate?

Hmm, must have misread it. It's ok

-Andi


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/