Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5306836rwb; Mon, 14 Nov 2022 02:33:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf4iPKc7xI1FggJxcDzUCNjBTSUmhn/Olx4lXyLuIEQfp0ngv5nPTImQcoRmCL98TxkLxZHZ X-Received: by 2002:a17:90a:3d48:b0:218:8f2:5af9 with SMTP id o8-20020a17090a3d4800b0021808f25af9mr12981943pjf.65.1668422008697; Mon, 14 Nov 2022 02:33:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1668422008; cv=pass; d=google.com; s=arc-20160816; b=FJlBOttiEruh2CQymv9lcRz4wPsB5/ji767EIjr0I/TFOe2mA+qjAbtqgBBRyXUkmu BztYAbWLf1+UniCSRRW34moQSuMMwvHWYw4MopIGIJDtEVea5gGGPBjl4DA4A74SDIcu VvZsUb9eo/YwKcbEa1xiJh8KIlH6q4PxkpghdJ+AOm4RLRQMZACf/ouCzUXoORmPvmK3 dRX6wgnDo6eG1FUkG8FJIw1kXRyVaHR3dXaT4az6kumxWskYm3C7dQF5B9fyVcEYl/To kxCSm1nWNALpMOMrgdBNahHzc55UmttKWqUrLFGN/YeuibYY0GcldesJBh+8cvrk8SY3 8DjA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=n0E8YgTPeMlZaTVJH+p1nlFsfAcKuXhV2rFQ22qn48c=; b=OPE2ysJ0SFS7guzD/XnqxK7zOlbBeLk8AOUGrr51PBZbGL41DKGAVmovGYi2DDZjjR YrfZoaPyJ3VqA5JZtqOoUPgClAvwB4nKlVh0tsWO+Z2oIEkZGIvctMPWEJ3Aw6No4axi k8dE1FCcF3gNZol7GmOu7WRKO9srdYkC6a+m/iRaJkUZGk0mpyC0K/qTPWOpI8MMWfSv rneD5VaDYzIzNUZBEmgYze63+yQXNu6zHus74P9QS5J787XI2GTqR/Tk4Cc1yxe+7ynM NIEd2NYcLtu6J3iemqn8hS5c9OSXJnGgcLoNanPKEpbDOBIwLYoEhvcliVEzseLEL3ej WOgA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@iki.fi header.s=lahtoruutu header.b=MuhPojJu; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e9-20020a635449000000b0044fb27b64c7si9571394pgm.326.2022.11.14.02.33.15; Mon, 14 Nov 2022 02:33:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@iki.fi header.s=lahtoruutu header.b=MuhPojJu; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236557AbiKNKHy (ORCPT + 88 others); Mon, 14 Nov 2022 05:07:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237202AbiKNKHS (ORCPT ); Mon, 14 Nov 2022 05:07:18 -0500 Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [IPv6:2a0b:5c81:1c1::37]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ED4CCE0A; Mon, 14 Nov 2022 02:06:46 -0800 (PST) Received: from hillosipuli.retiisi.eu (dkxjnptf9d2bpn7gcmbty-3.rev.dnainternet.fi [IPv6:2001:14ba:44ce:b640:9d1d:82c5:eca2:5060]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sailus) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id E40E31B00120; Mon, 14 Nov 2022 12:06:42 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1668420403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n0E8YgTPeMlZaTVJH+p1nlFsfAcKuXhV2rFQ22qn48c=; b=MuhPojJumg96qXDDlbrabUiYNYg8DcQZv1EJSsFMyIF6MyW0Vh+8sEnczpe+aD3M62my47 aIFsa8W8vIIWUFPOMph2ODZyvcz3wi4rEfazTeXTOc2gp5bHj/NBnAel+JHLpGJpRgy5mp Kna6eH8mRIg4fMu98Lbx/y23F97XEoqNym1cR/3+EV4bXTjujS24MGECr21SbrhQMglJve N5zTfaNew1/qt182IHViBRdU2ygu2SzXNBeB/G+C7rdG2fwxmwAuTomnuIxcOsq5ufMxaO gIFl/MKK4NF7eoOUDhNaiQ54xMnbQIJf8FzsKHwnbFt1oQ573iglWIPj9ieNcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1668420403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n0E8YgTPeMlZaTVJH+p1nlFsfAcKuXhV2rFQ22qn48c=; b=Y7aT1VsbOGmSSq0I11cX04+ntBpkgrH+238otZdCyVwtdq0kmDNgAwbqnw2uJHmAwlXOhp 4OWi9/qmTpRIH9nEODPdN+JHljny2C2A/oLd67LairhSX9OLgw151jmgyRpv/YWYwTJNqr xw0N7qRGnsAlfCk1sGcZdxETsGw4neW9z3V3rH3s9PwiEw5Tbvebsx+vDcpUVOWeAxju+n UJn5YyibKo7fJjWDj6p1ybGaWQgn8WngXgLkKhE8gEULUzMJjY+0B5Kr1g8lWCoD8aiglc XaMpEbYeBnjnKxFGjVhMXU8dY4wM5ye7w2Zr5gLLSlctguS2A+zZDtLfAs2VcA== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=sailus smtp.mailfrom=sakari.ailus@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1668420403; a=rsa-sha256; cv=none; b=IMUzKT1HHR3XdI0gIP1tP9McRHkNwkZxTDbqyBNTHnGJoEl7a09jiaSwNs1dIwaGQ4J4z7 meXNjGkXeywM6mYFzXmtOF4EU05jXt+t0AG/kqMRuQ/RUQxEKqNIzPZQgTGZ1uZdXlxM0a 2CC+UWWvxv3yIKTGWfBH2xsghWpY83FY6YmXRxerN4JD0LbqHyXH/tkjm/3+oD6HcoBSWu 3EtJkg0KUty7702ZQvNseszepNz1SXgn5UZhyTjY7XmDpJe31YYSNDCqvquD4t++pHY4N8 lMWHl24CWAcoKOYPnpdXUPEo0GOaS7qbj8wolwFQ78JqD0Aw0v8Z/sW7TO6sAQ== Received: from valkosipuli.retiisi.eu (valkosipuli.localdomain [192.168.4.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.eu (Postfix) with ESMTPS id 7D31F634C97; Mon, 14 Nov 2022 12:06:42 +0200 (EET) Date: Mon, 14 Nov 2022 12:06:42 +0200 From: Sakari Ailus To: Paul Kocialkowski Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Yong Deng , Mauro Carvalho Chehab , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Laurent Pinchart , Maxime Ripard , Thomas Petazzoni , Maxime Ripard Subject: Re: [PATCH v7 02/28] media: sun6i-csi: Rename sun6i_video to sun6i_csi_capture Message-ID: References: <20221103163113.245462-1-paul.kocialkowski@bootlin.com> <20221103163113.245462-3-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221103163113.245462-3-paul.kocialkowski@bootlin.com> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On Thu, Nov 03, 2022 at 05:30:47PM +0100, Paul Kocialkowski wrote: > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c > similarity index 58% > rename from drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c > rename to drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c > index fa83211a2c5a..9838a5a43c2d 100644 > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c > @@ -15,7 +15,7 @@ > #include > > #include "sun6i_csi.h" > -#include "sun6i_video.h" > +#include "sun6i_csi_capture.h" > > /* This is got from BSP sources. */ > #define MIN_WIDTH (32) > @@ -26,7 +26,7 @@ > /* Helpers */ > > static struct v4l2_subdev * > -sun6i_video_remote_subdev(struct sun6i_video *video, u32 *pad) > +sun6i_csi_capture_remote_subdev(struct sun6i_csi_capture *capture, u32 *pad) > { > struct media_pad *remote; > "video" was still being used a few lines below this, fixed that while applying. The PR has been sent already. Just FYI. -- Kind regards, Sakari Ailus