Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Nov 2022 11:15:30 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Rob Herring <robh@kernel.org>
Cc:     Jon Hunter <jonathanh@nvidia.com>, Wayne Chang <waynec@nvidia.com>,
        mathias.nyman@intel.com, p.zabel@pengutronix.de,
        devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
        linux-tegra@vger.kernel.org, singhanc@nvidia.com, balbi@kernel.org,
        linux-phy@lists.infradead.org, vkoul@kernel.org, ajayg@nvidia.com,
        heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
        treding@nvidia.com, jckuo@nvidia.com, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 02/13] dt-bindings: usb: Add NVIDIA Tegra234 XUSB host
 controller binding
Message-ID: <Y3IVQtY94GenVpGL@orome>
References: <20221111101509.999589-1-waynec@nvidia.com>
 <20221111101509.999589-3-waynec@nvidia.com>
 <166817308790.3060162.14990231448404857914.robh@kernel.org>
 <5782d31a-9a0c-33da-ff84-20cae29f977e@nvidia.com>
 <20221111173236.GA3561612-robh@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="2hyjIjtsn0nH3kf8"
Content-Disposition: inline
In-Reply-To: <20221111173236.GA3561612-robh@kernel.org>
User-Agent: Mutt/2.2.8 (2022-11-05)
Precedence: bulk


--2hyjIjtsn0nH3kf8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 11, 2022 at 11:32:36AM -0600, Rob Herring wrote:
> On Fri, Nov 11, 2022 at 02:38:21PM +0000, Jon Hunter wrote:
> >=20
> > On 11/11/2022 13:30, Rob Herring wrote:
> > >=20
> > > On Fri, 11 Nov 2022 18:14:58 +0800, Wayne Chang wrote:
> > > > Add device-tree binding documentation for the XUSB host controller =
present
> > > > on Tegra234 SoC. This controller supports the USB 3.1 specification.
> > > >=20
> > > > Signed-off-by: Wayne Chang <waynec@nvidia.com>
> > > > ---
> > > > V1 -> V2: new change for adding nvidia,tegra234-xusb.yaml
> > > >   .../bindings/usb/nvidia,tegra234-xusb.yaml    | 159 +++++++++++++=
+++++
> > > >   1 file changed, 159 insertions(+)
> > > >   create mode 100644 Documentation/devicetree/bindings/usb/nvidia,t=
egra234-xusb.yaml
> > > >=20
> > >=20
> > > My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_ch=
eck'
> > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > >=20
> > > yamllint warnings/errors:
> > >=20
> > > dtschema/dtc warnings/errors:
> > > Error: Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.exa=
mple.dts:36.27-28 syntax error
> > > FATAL ERROR: Unable to parse input tree
> > > make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bind=
ings/usb/nvidia,tegra234-xusb.example.dtb] Error 1
> > > make[1]: *** Waiting for unfinished jobs....
> > > make: *** [Makefile:1492: dt_binding_check] Error 2
> >=20
> > This compiles fine on top of -next. We are just missing the change that
> > populates the required definitions.
>=20
> Where exactly is that mentioned in the commit msg?
>=20
> No maintainer can take patches which apply against linux-next, so not a=
=20
> good dependency to mention either.

It would probably be easiest for me to pick this up into the Tegra tree
since that's where the dt-bindings header file change is that adds these
symbols. Alternatively we could strip the symbols from the example and
use literals instead.

Thierry

--2hyjIjtsn0nH3kf8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmNyFUIACgkQ3SOs138+
s6H1Uw//WLqL8StUoYtObkq8iiJpsfdxOjQvDdyaW0F4virLoWtaqoLEFVpbja40
YjX08K9B0iNoo58bTXGyUrgTKPsrj4GxOFqD13ons2T7NkjDGd+k0MHhoe/5dY02
rshoIdDbqd+ZjQMyrtPCyWgHfgcKeMVd0xmBhJKF7eBUljX6mhZTboCmWTKvFake
wWCQQs+5m83Zm5oFOQyu2zcl7Y+127zrofOluMv1l5pRYESmmzndykB5ZTGBmWJm
IE3NExzLNoAjRn0v/0fC9yaPi8GCYVDxmuKYZYuYXKGUioesTOHpeu29iEVcfVLI
e1+Et89Z+Sot37r4qenXlZmLcXMu29UvC5mrckAGxynu8eB7LgfRUMDoXr+2/teg
sOUltlxbzw4wdQsh2sf+aRZZdDtFUlpIZpxkijsHsO1Rhz/q8e4kkOab5VUx6jCe
VmEcjSlsiQkYSNzyFilJhx7t14AIqLIcmW0M9086JbcFulyJdojZjov/9iP9xPZa
NVVTrlvhskA6ouRJYmtS6bp5/RRfEVMHV+rKjjU+gkWW5mE5gC3uwJWtFR/qDCjq
nbPXWgj2OOZJVQovD5ahbziAkHKSPcsx8J2dhNnF15S+/dC0LkHdBzNWbVGRnGk5
bIAhSqcG9BMu2rOmf+L4J5P3dcTSvlOnTnrfgA0RuYby/sbaMDc=
=QvgG
-----END PGP SIGNATURE-----

--2hyjIjtsn0nH3kf8--